Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9f3e7030-c439-b8fe-7d30-80b11f4d06bb@amd.com>
Date:   Tue, 18 Apr 2023 10:17:22 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] [v2] drm/amd/display: fix is_timing_changed() prototype
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Lyude Paul <lyude@redhat.com>,
        Wayne Lin <Wayne.Lin@amd.com>, hersen wu <hersenxs.wu@amd.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>,
        Aurabindo Pillai <Aurabindo.Pillai@amd.com>,
        Alan Liu <HaoPing.Liu@amd.com>,
        Wenjing Liu <wenjing.liu@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Alex Hung <alex.hung@amd.com>,
        Mario Kleiner <mario.kleiner.de@gmail.com>,
        Aric Cyr <Aric.Cyr@amd.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        Alvin Lee <Alvin.Lee2@amd.com>,
        Jasdeep Dhillon <jdhillon@amd.com>,
        Roman Li <roman.li@amd.com>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230417220827.3481168-1-arnd@kernel.org>
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230417220827.3481168-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0RJQmVtZ3VrM1pXT1NZTlhIYXczQmYzdFBHeDRJZEVHalcxZi96MngrZU5U?=
 =?utf-8?B?L2lpbURoNlBHWk5KR2ZRWVZuZk0yYlFiY1oyTkxKa0REeVhrYkhYdlowMW5S?=
 =?utf-8?B?VWFRbE93R0pHUHVGVWZLYUxaSm9xUlM0SUNZUWlWYjJ5SmoxdVhmQytpRW0x?=
 =?utf-8?B?anNzOWlnN3dNc0xacUFqQzZheWdjZUx6K0h6VmFOQkdVdkw1cEpqKzkzWU0v?=
 =?utf-8?B?RkRBVGJBa0lQM1VyWklmWVEyL0dlM3hjSFp1b3BRZUNuUCtxNEw3V0hROUt2?=
 =?utf-8?B?ak1WYzh3RVNvMXQ4UllQeW45V1p1cUlNMEQ0SmlYdmZ2SjRtOU5sMGU4dG1U?=
 =?utf-8?B?NlovazVFeUY5ZEZ4WG0wWTlvcU91dFN6MVh6Nnd3TVV3S2RYM3B1c0FhSFVO?=
 =?utf-8?B?NmIvamEwNU1Pd0JyK0lKa0VZcW9UNmNRRXdvaERDamVkV2taK1I3SUtmUTh2?=
 =?utf-8?B?UXpKUFhCcWZuNEhsMmIzazlDTTdZVDFkTHFGeGcxbXd5YzFnNDVtL1pGU25n?=
 =?utf-8?B?WHZmTWtKUjd0ZG1hWEpvM2N0d09iciswbnU2Q2ZaS2g1cGhoN3JlYyszQ1Yw?=
 =?utf-8?B?Vm1jMyttVDZnRDJaYndDYWMvZVpmWUNtbGppcGhudEVWMWFvWm1LQjRvYVlF?=
 =?utf-8?B?WUFVTkhMd0NPc0tlRDEvNFU1VHpKYTFOQ2ZnQXhoUUZSeW9QbklmaHZPTUZo?=
 =?utf-8?B?QXA5L1pEakZFblFmaU1wVllVUFFYRG9uT2hhWklRVllnNTJRS2t4VkRSWXVW?=
 =?utf-8?B?czkzMGFxcVVLSXN3TjR5SzU1bVdsc3FwZDdwWXpDeEJUUm9zRjFyNmx2Y09E?=
 =?utf-8?B?M0VmNCtBTXozVEU5SkRkSjA0MzB4bGVnbEJ3VGlyMUQrakZuc3VPY2tQYmFp?=
 =?utf-8?B?RXdIcER6aytqd2t2SlRlcFZ1cUxJdEp1Mld3eWovL3VCU3lXdkdGTm9EZ3FT?=
 =?utf-8?B?amlEcmM4aGk0cXI1Wk56czhLNXZXVFljSVZDajBWRFF5aTIzL2pLejlBSEh0?=
 =?utf-8?B?cmowa3Q2TURqbk12WkJGTnBWMWhManlwaU51MHhKUURGT0diQk5iNW9jbTE2?=
 =?utf-8?B?VFoxWnFDSWU2TUlBaDFmdXZaazFSbm5wWHA4c3RIUVBpdWcyTldtWGc1b0Zk?=
 =?utf-8?B?bUVLWW1LaTUwbHdZTW1rWHVpR3BIdW80S1ZDUDdha004eEZ4NS9sQlZkTzRj?=
 =?utf-8?B?SDFFYnlUOG4reWNnczEweDBZejhnb2szRmYyRUo4MzhHTHNTTGt3R0NpWlR1?=
 =?utf-8?B?eFg2WnZUSm0vU1BEdjg2R09mbzNaN0VjQWFydWNUL1lBcWg5UzJzWUFnaWxY?=
 =?utf-8?B?cmttejlnYXVacFZJc1lBRUNUNHpFWTBadTNHUDMxeHd3RGtlTTNyZUhwUHYw?=
 =?utf-8?B?OHlUSlIwRnNoOCtwSTZTTERmclZzVmhXUlpLc1h0ZU5jamNhN3Iya3BNTEVU?=
 =?utf-8?B?M1I3NFVZWHVxMVVtbTdPT0Q4S2FMcVlvdm83M0w0SnVleXNLQW91bUNqblBE?=
 =?utf-8?B?YnNYaGN4ekJHazM3R2liVmhWVDZHRGFick1hSXpoZGRnblI5eW5sNGRLc2k3?=
 =?utf-8?B?dWJwTDJBOVVUMFBCU3dZVDFhVWJlcXdPNzh4UVZmc2pFTWdmallqMURwZmZU?=
 =?utf-8?B?Z2lHclljME5SaEdCQXRqelBFTk84dS9TNjFpTXdYS3c0SVlJQmtIOHpabGtp?=
 =?utf-8?B?R1VLK0l3dCtmSEZHcEs4T2xLT3hacmlvTUhybFoxUUtMVnYyWmJOb3dBRFZQ?=
 =?utf-8?B?SUtkK2QzNFNkVE9FY05rR1BwamRtcTdVN09pNHVHOFJXN1BqdmQvSkIzNS9Q?=
 =?utf-8?B?MlRzdldFZlVOS3lvSmhRQUt1WDRNd1Uva1Z6MEJaQzAvbjN4WVJsWWpGdUx1?=
 =?utf-8?B?R2Znb3QwdWVRY0FmV09NS3AvZEJWbTZGTTVXbFRNdjVNUXM5K3djKzJBaTdS?=
 =?utf-8?B?RWllQ0pFVjB3YkNOc1RUUDZ4Rzd0aVg1dFMrUDlUOXpSbWROQ1A5UXpDZGNp?=
 =?utf-8?B?cTNCbTBXMkFOQlMveE5GTW5xTXpwZzBBRTlMeVQzcUxwZTNlTlloNzhzQkRx?=
 =?utf-8?B?U2lGK0ZPYmUwS1ZUdWVXNUVMMXZWb1BtdzFiMU51VnByMXcwMDQ2eng4eUVo?=
 =?utf-8?Q?4nNBU5HmB3sSs4eKSlWCMOI+S?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d5cfc01-b740-46cb-f6e4-08db401770b0
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 14:16:02.4237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q4YGbV5ivX4cP5BMtrA+9gBsBir8BRjX8lcqIeHAtGbtRUR1FlzLf+T2oEqIR6Y8CyhH9Is1QKHWWcfK/lzvRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB8606
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/17/23 18:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Three functions in the amdgpu display driver cause -Wmissing-prototype
> warnings:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no previous prototype for 'is_timing_changed' [-Werror=missing-prototypes]
> 
> is_timing_changed() is actually meant to be a global symbol, but needs
> a proper name and prototype.
> 
> Fixes: 17ce8a6907f7 ("drm/amd/display: Add dsc pre-validation in atomic check")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 5 ++---
>   drivers/gpu/drm/amd/display/dc/core/dc_resource.c           | 6 +++---
>   drivers/gpu/drm/amd/display/dc/dc.h                         | 3 +++
>   3 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 994ba426ca66..442511061178 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -45,8 +45,7 @@
>   #endif
>   
>   #include "dc/dcn20/dcn20_resource.h"
> -bool is_timing_changed(struct dc_stream_state *cur_stream,
> -		       struct dc_stream_state *new_stream);
> +
>   #define PEAK_FACTOR_X1000 1006
>   
>   static ssize_t dm_dp_aux_transfer(struct drm_dp_aux *aux,
> @@ -1417,7 +1416,7 @@ int pre_validate_dsc(struct drm_atomic_state *state,
>   		struct dc_stream_state *stream = dm_state->context->streams[i];
>   
>   		if (local_dc_state->streams[i] &&
> -		    is_timing_changed(stream, local_dc_state->streams[i])) {
> +		    dc_is_timing_changed(stream, local_dc_state->streams[i])) {
>   			DRM_INFO_ONCE("crtc[%d] needs mode_changed\n", i);
>   		} else {
>   			int ind = find_crtc_index_in_state_by_stream(state, stream);
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> index 85d54bfb595c..344533623cb9 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> @@ -1855,7 +1855,7 @@ bool dc_add_all_planes_for_stream(
>   	return add_all_planes_for_stream(dc, stream, &set, 1, context);
>   }
>   
> -bool is_timing_changed(struct dc_stream_state *cur_stream,
> +bool dc_is_timing_changed(struct dc_stream_state *cur_stream,
>   		       struct dc_stream_state *new_stream)
>   {
>   	if (cur_stream == NULL)
> @@ -1880,7 +1880,7 @@ static bool are_stream_backends_same(
>   	if (stream_a == NULL || stream_b == NULL)
>   		return false;
>   
> -	if (is_timing_changed(stream_a, stream_b))
> +	if (dc_is_timing_changed(stream_a, stream_b))
>   		return false;
>   
>   	if (stream_a->signal != stream_b->signal)
> @@ -3505,7 +3505,7 @@ bool pipe_need_reprogram(
>   	if (pipe_ctx_old->stream_res.stream_enc != pipe_ctx->stream_res.stream_enc)
>   		return true;
>   
> -	if (is_timing_changed(pipe_ctx_old->stream, pipe_ctx->stream))
> +	if (dc_is_timing_changed(pipe_ctx_old->stream, pipe_ctx->stream))
>   		return true;
>   
>   	if (pipe_ctx_old->stream->dpms_off != pipe_ctx->stream->dpms_off)
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index 23ee63b98dcd..e7ab6cb3769b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -2225,4 +2225,7 @@ void dc_process_dmub_dpia_hpd_int_enable(const struct dc *dc,
>   /* Disable acc mode Interfaces */
>   void dc_disable_accelerated_mode(struct dc *dc);
>   
> +bool dc_is_timing_changed(struct dc_stream_state *cur_stream,
> +		       struct dc_stream_state *new_stream);
> +
>   #endif /* DC_INTERFACE_H_ */
-- 
Hamza