Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756198AbXI0Ujh (ORCPT ); Thu, 27 Sep 2007 16:39:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753790AbXI0Uj3 (ORCPT ); Thu, 27 Sep 2007 16:39:29 -0400 Received: from verein.lst.de ([213.95.11.210]:52934 "EHLO mail.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469AbXI0Uj2 (ORCPT ); Thu, 27 Sep 2007 16:39:28 -0400 Date: Thu, 27 Sep 2007 22:39:22 +0200 From: Christoph Hellwig To: Greg KH Cc: jblunck@suse.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, hch@lst.de, agruen@suse.de, tiwai@suse.de Subject: Re: [patch 02/10] Dont touch fs_struct in usermodehelper Message-ID: <20070927203922.GA15477@lst.de> References: <20070927141200.820970144@X40.localnet> <20070927141227.559764756@X40.localnet> <20070927174604.GA8339@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070927174604.GA8339@kroah.com> User-Agent: Mutt/1.3.28i X-Spam-Score: 0 () Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 23 On Thu, Sep 27, 2007 at 10:46:04AM -0700, Greg KH wrote: > On Thu, Sep 27, 2007 at 04:12:02PM +0200, jblunck@suse.de wrote: > > This test seems to be unnecessary since we always have rootfs mounted before > > calling a usermodehelper. > > Are you sure this is true? I thought we called the usermode helper for > hotplug _very_ early in the boot sequence when the device tree starts to > get populated. rootfs is mounted by init_mount_tree, and curret->fs is set up for init there aswell. This is called by mnt_init, which is called by vfs_caches_init, which is called by start_kernel far before we go to rest_init which finally creates a thread to call kernel_init which then calls do_basic_setup which calls do_initcalls to initialize drivers and afterwards runs the initrd/initramfs. While the actual function names in main.c changed quite a bit we've initialized the initial namespace very early on since the 2.5 days. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/