Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5637766rwe; Tue, 18 Apr 2023 09:20:37 -0700 (PDT) X-Google-Smtp-Source: AKy350brIildNB83bs93NiQ2CoKAMyW/Fy2+G9/zdL2iaLv8FY0CG9twdPz8DKOYer7L5RX++SzY X-Received: by 2002:a05:6a00:2d14:b0:63d:254a:3909 with SMTP id fa20-20020a056a002d1400b0063d254a3909mr275457pfb.32.1681834836726; Tue, 18 Apr 2023 09:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681834836; cv=none; d=google.com; s=arc-20160816; b=Pkgf+B3fpgTJaLYsBkP0rmJnIf0pC7zvc9SWzEUbk3dc4wCsbmtioAJwSHL8P/Q8k7 XJQnjiteEpWX+PBrmXDA0UzGIZgwr1wq4ljfGC9egSrM/cUP5usU4ybt6QPBzcmscIfZ geiE93qcwW8s+7fWnJAbdxCUDeRbTOtt7aqHQeKFTLcQbKzuN8oQ3E6Kc67dqW74uKUO jaMvShCePiD+3H6/YGqUQ8hNpE5TzyflSw1T4RxPg9xGqe+mrMi0uf164TuG5ZqbKvpH CqwC7nB6hui7Yt2APft8rY9h3PxrinZuSnlNNpoh78Q2tAztAlO7vUum0FW7N8io+Kzr tOyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=anWyvRSLQ2R8CpDI4TbnpyM9aRqD9vXygDkn+RJxXzQ=; b=CDrjm6W5uTHIFfWEzgm0njgfLbhwRuVtxHFo3Y7XAKEvOgNvyb+sbJrZl2sd78TUf7 Qbbse5f/NhcsUDHBGd8tcgWPCfYM7K9sf37j9hauEjxSiWkp97ktcO5WqXWVAIj1u2lC tGvQTUMHUk3I/yC7s8I9e7YW1/35bMnHF7/E4YAvfwvYqI1gwRP9DF3pMM8jdk3pl2H/ UThFwne0yxe3V2Ldkr112JCxDwmzeS+foSgsmlLNXhZJLuJ/KCaOkJdsEEgtZYFr/SJ0 tZviIAqFh5v37qzwBwwCa37c9/RcY2Qm7kzU+jdWzJVIY3sty0GLfOnry/+Z/RTX5tKN h6dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="SUF0Ky5/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z66-20020a626545000000b0063a6dbeaa56si13784516pfb.60.2023.04.18.09.20.25; Tue, 18 Apr 2023 09:20:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="SUF0Ky5/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232327AbjDRQHT (ORCPT + 99 others); Tue, 18 Apr 2023 12:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232290AbjDRQHM (ORCPT ); Tue, 18 Apr 2023 12:07:12 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6746813F89; Tue, 18 Apr 2023 09:06:49 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33IFU0pd006152; Tue, 18 Apr 2023 16:06:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=anWyvRSLQ2R8CpDI4TbnpyM9aRqD9vXygDkn+RJxXzQ=; b=SUF0Ky5/vJbFKiSBYsE2Y+2bw8BpPZh1H36h4WZsVM6UWolEeBtwIMktf/PiTGDW1DXa k9TIeOy7BIcUoIexvPBe1nPTaz93Q/9vrNttflzwJ7ANNdrbXivn24wwlqacpQwv/fes AxxylHYtBaYjJQnkQLrsEsh2VgB7hKwHAYNH8ea0XYMIJ3LuUwtH0YibfbXeIkG+kjl4 ogLXNr8ctBEGBhtw/CA66Ropf+e7Gbb1C8VQSScl+xwA6v9NikBXcKsT9Sxnem6fMcxc Zj7rJNhdRQUESaSNqFuGKt+5CJ6JpPOgFcm0RH01QccAVyDCzbCfg4coqUXMsUVdK2In jA== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q1v190em2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 16:06:37 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33IG6bN4010158 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 16:06:37 GMT Received: from [10.110.98.241] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 18 Apr 2023 09:06:35 -0700 Message-ID: <60bb4a4a-f414-e926-df53-d6d1a01fc221@quicinc.com> Date: Tue, 18 Apr 2023 09:06:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask Content-Language: en-US To: Marijn Suijten , Rob Clark , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter CC: <~postmarketos/upstreaming@lists.sr.ht>, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Jordan Crouse , , , , References: <20230418-dpu-drop-useless-for-lookup-v1-0-b9897ceb6f3e@somainline.org> <20230418-dpu-drop-useless-for-lookup-v1-2-b9897ceb6f3e@somainline.org> From: Abhinav Kumar In-Reply-To: <20230418-dpu-drop-useless-for-lookup-v1-2-b9897ceb6f3e@somainline.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Y4QKOVO5AxmNisp-ZDaWfYTJM9oyJoNM X-Proofpoint-GUID: Y4QKOVO5AxmNisp-ZDaWfYTJM9oyJoNM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-18_11,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 mlxscore=0 spamscore=0 clxscore=1015 mlxlogscore=853 bulkscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304180136 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/17/2023 4:14 PM, Marijn Suijten wrote: > The WB debug log mask ended up never being assigned, leading to writes > to this block to never be logged even if the mask is enabled in > dpu_hw_util_log_mask via sysfs. This should be debugfs not sysfs. > > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") > Signed-off-by: Marijn Suijten > --- With that fixed, Reviewed-by: Abhinav Kumar