Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 19:17:15 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mscc: ocelot: remove incompatible prototypes
Message-ID: <20230418161715.3lig6wyv3baokvpe@skbuf>
References: <20230417205531.1880657-1-arnd@kernel.org>
 <20230417205531.1880657-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230417205531.1880657-1-arnd@kernel.org>
 <20230417205531.1880657-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2a/q6x9F8tlAuiRJ9/NRyK3jt+KyAFS97tf8Zah+YLsAoIrB/ur0TuFm/8Lq?=
 =?us-ascii?Q?CDB4HZbTbu8NyYrFwk9dBjWm0gMRy53HK5Rs0gzRAljmQSz3X9zgsUd6Ms1F?=
 =?us-ascii?Q?eRPKLeWcL0cGJeHZRubtt/yhKfADwfdPvteK1Sadf5m80y2NvgLfBxcOYYPv?=
 =?us-ascii?Q?4yOyZNV6Y9jxsib4MvnQC6Zzq7npfb6mXM6E5X9OIhWnWgXERTOm8zDHNfFo?=
 =?us-ascii?Q?yYpcpOjLoWNSCVda7r3j0PMOmuz2H3jZWVuOTabN22torsdwDuVgsBuM0GiV?=
 =?us-ascii?Q?zec4dV/jsFd4NCace9gFuzrOoxlbdXLIhspFKTj39D/F4yFedSyP8MyJigQc?=
 =?us-ascii?Q?uAqZ0hVwXyVqR3RqYSCBuPEL5QXG3z/4X2HdXE18J5Wzz8X3aPwlCuTPvW09?=
 =?us-ascii?Q?lgg79Jex2KNieBgnPVCBXdhKimYpJYhSO/Kn+2KHkZFfdOlPnFWd4SLl4K+q?=
 =?us-ascii?Q?bsodKSwgmM6YEqTVptDJeWhCfYPN7KflFt3Qflj1J8OdFwsATFIHfBKE2/1E?=
 =?us-ascii?Q?9gsWUVHHbMh5c9hCGGoKPE7a+UoN6BwGN+bxTnZlC8qGWIO2XfEscjXzLA1j?=
 =?us-ascii?Q?OjzJyTcgvPUl0vk5IzGrg7sBij3EAFK6fYaVLU9nL0MUu1/wYM2vPb24YryK?=
 =?us-ascii?Q?XZgUrmfYSvx+uIsFAPKxHUu0Q7h3ZOXQh720xaxSfcRes4ZN0SJRvJviuPWJ?=
 =?us-ascii?Q?l6qGayv+JLjVG/YavcVvQWNmy/8+U5a6QQ2lBAIW/bMZb9Se0pdcZmFtUTIC?=
 =?us-ascii?Q?2YYGc9ExARThp1+KIHBhu1023aRzlRWygvAf3LN2wnL00etp564S4dmZNbbu?=
 =?us-ascii?Q?rpDLWua1Xt/LoDkWYLKky/QpYHnRv7wiyczI6CehHIZ5YLbEnypWYdIvDT1A?=
 =?us-ascii?Q?vpMAcjBM3zTxqRVwupGervRe6N68+Mw7xcAYY+x8TWsAyRfcOG+LZ722fLAU?=
 =?us-ascii?Q?lOgomnffmYTOAl/vXNJNu4TnZnKWdGN3iISHRCtUplWVuJoaKSnYpvf/DqGa?=
 =?us-ascii?Q?tZo+BK0yrJs0MwXHpnC18zuKIBNX/1h1P3HX7xu9HMRg0Gfk1enOlWW3ZTEo?=
 =?us-ascii?Q?h3lJLnOSo6WU69G99WDonTb8VlOb5sgNhdJ9XjRMIwn55ZEBmGH0CL3ZIP0e?=
 =?us-ascii?Q?lMc0BEwNJ39dVYYhudMabYWkqciGMNwz0Iu7+313ic+hkPzhmtID8qsRkbY6?=
 =?us-ascii?Q?LJRC0rvBjx62c7j20NrHe3gC2Lo8jBKUwmZNQ2CqEwCLtaQgsJ0Xy58nsN+I?=
 =?us-ascii?Q?Kpdpus6jOJVeazAUB6ZyE8aDZNEfT4qqmj1Ct7uqYBa427LH8d5umiFl0wf+?=
 =?us-ascii?Q?vq6rsHIXziIOBPeIgo2bWkPzR9yEdmDkZ1/a5kRYEy5H8JQty6FYVlZfSmhZ?=
 =?us-ascii?Q?ZrWmZZPDS7Im/Wsul4sx6OMdD2TtNUQQKFqscsYy36FZsbSwA5iQ9jbJ2l0X?=
 =?us-ascii?Q?sU2CKvZXiMkDjzOtrBA01h3lr+eZWuXOKDOPBSxrvEq4OG5+89rRERtvADqd?=
 =?us-ascii?Q?Y3trDhnFs19os5P/lC1CUPrs9zymwlrDBhqWp6taJKr9Ml91oKb+FBUJrWmy?=
 =?us-ascii?Q?QNbAmQ/qd3NxLZpVrmpLv8TgKC8GEUSmnViwFw7I/xhkQXOWnKGPYKgB1V4h?=
 =?us-ascii?Q?Eg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb1d9fdf-f2f4-470e-fc52-08db402861ee
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 16:17:19.0631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WkTSFNyeb7sZ0oX7/hT7p/TRTacvB0NdMKGGMlwkSGA3ejr/mhLbS8ZNhAT/s9FTucbxij9xJ43eCasIyYBEhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6911
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 17, 2023 at 10:55:25PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The types for the register argument changed recently, but there are
> still incompatible prototypes that got left behind, and gcc-13 warns
> about these:
> 
> In file included from drivers/net/ethernet/mscc/ocelot.c:13:
> drivers/net/ethernet/mscc/ocelot.h:97:5: error: conflicting types for 'ocelot_port_readl' due to enum/integer mismatch; have 'u32(struct ocelot_port *, u32)' {aka 'unsigned int(struct ocelot_port *, unsigned int)'} [-Werror=enum-int-mismatch]
>    97 | u32 ocelot_port_readl(struct ocelot_port *port, u32 reg);
>       |     ^~~~~~~~~~~~~~~~~
> 
> Just remove the two prototypes, and rely on the copy in the global
> header.
> 
> Fixes: 9ecd05794b8d ("net: mscc: ocelot: strengthen type of "u32 reg" in I/O accessors")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Interesting, I didn't even realize we had these duplicated there. Thanks.
FWIW, they were duplicated in commit 5e2563650232 ("net: mscc: ocelot:
publish structure definitions to include/soc/mscc/ocelot.h") and haven't
bothered anybody since then.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>