Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd46521c-a167-2872-fecb-2b0f32855a24@oracle.com>
Date:   Tue, 18 Apr 2023 21:47:33 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: [PATCH 5.15 00/91] 5.15.108-rc1 review
To:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Waiman Long <longman@redhat.com>
Cc:     stable@vger.kernel.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
        patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
        jonathanh@nvidia.com, f.fainelli@gmail.com,
        sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de,
        Tejun Heo <tj@kernel.org>,
        =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>,
        =?UTF-8?Q?Daniel_D=c3=adaz?= <daniel.diaz@linaro.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        Tom Saeger <tom.saeger@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>,
        Vegard Nossum <vegard.nossum@oracle.com>
References: <20230418120305.520719816@linuxfoundation.org>
 <CA+G9fYs9sHnfhn4hSFP=AmOfgj-zvoK9vmBejRvzKPj4uXx+VA@mail.gmail.com>
Content-Language: en-US
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <CA+G9fYs9sHnfhn4hSFP=AmOfgj-zvoK9vmBejRvzKPj4uXx+VA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmcyaWkrR2E4YVRTS3JMeStJdXI5SnNidXF1TnJqTm9ibWtDRlJDMnI1bklE?=
 =?utf-8?B?Skk2R2xNc29iUlNmMnM3b1pQL0xwU291ZDBsdXNITDdKUHJic3J3Qi84TENX?=
 =?utf-8?B?dkEvKzZwMGxqSTUremVwdUN5dXZySzNTdGlNdUlTMWdYRnVyaGphMDR2U3dQ?=
 =?utf-8?B?dkF4N2tKVDJSNFl0YzgzbnZudmcwaEZuaFN5RndvTzh0dDRDSVFrQzNZUHhl?=
 =?utf-8?B?alByNTJiZUIrNFJSaXZCb2hhUGNMN20rY0NCaDNkbXJJWDhrbnpxbXBjdVJz?=
 =?utf-8?B?R0tVK244WitqTkEvN0VTTTdNM0RWaW9GY3I0NzI0b0I2YlhoQ3NxdUJHa01V?=
 =?utf-8?B?YS9PTHFwRDZCNW5GRVoyeVVtcmhkWHhaL1pFVkh1UURxYjYvTjhHc2wrV2JW?=
 =?utf-8?B?ZlBMcUFkWG5iaFlhVkxzdXR5MGY2VFNLcVpxQWVVOGpKTnY1ZitYekdmWVlH?=
 =?utf-8?B?MENxMTFNSzhrRjR2V3VYVVNtTnlhcmE0OFdqTjdqNEowRkZ0SENWZ0pYamdW?=
 =?utf-8?B?cUVMaWlUcGFnYXdCTVVHNzlCS215b00wclpNK0dGODFSMTdkcFBoOE9zNUln?=
 =?utf-8?B?WWxvdjJvb2NIRUtyTElYbW4zL1BxSmZoZlZSYW42MEtyVitLN2piQThYblFy?=
 =?utf-8?B?TklIeElHcnlhbyt1bkswU1IyZkFNKzg0VXo1Ym1rd05XTWFMN0hiMmdmamVn?=
 =?utf-8?B?T25KN3dkMEF4YWRtSGw5aVJlZTlUa0FnODlLMzhCUmNuNndoemZCSGNkZUZ1?=
 =?utf-8?B?d3F1cWRoUVJyMU54V3ZJYnNyZTNGaTQyTFRXMTlubDBzdXhHR09FQ1ZnL0Fa?=
 =?utf-8?B?cXpPNW9wYW1GSWptUW1VNEF1dm1lSW5HVGtoZG5WTGN0UzQvRjZubklRdXA5?=
 =?utf-8?B?L1htOEdLaWFrMlFaNlF3c1kxVSs4dVlDeDVzUHdYVXF3cWoyNnFzN29OWTRE?=
 =?utf-8?B?NGxnWUNSSjdQSjVFZ0x1NmowZ1JmRVNXVVJNbURPV0VmT00ycVByeTdyR0gx?=
 =?utf-8?B?T0JSZzdoNUdLb1Z1SERZVXhDQ2NaZ2pnWTFXVi9OeVA2NnhHbjhDaHVBblBP?=
 =?utf-8?B?MDY4V2hxRDYvZzRoZVJhR0RkN1pWczZzY0JBN3pTdTNLendvSU9RQVk5d1la?=
 =?utf-8?B?VUk4azhjSHhCSnhTSE5SUjkzemlJN2RBemRTdEl6a25OSm1KVjlxd1puMTRh?=
 =?utf-8?B?Ui9XdHNneFkzWDlOa2ZuTklxVE5wMmU4QWlibWpTa2N1SFhMb1RxckVJMTdJ?=
 =?utf-8?B?YWUzcC94V3lDbkp2YWtjTXRFbGg1NFJCLzBnVFc3WW5WdWozbmhJeW9ZdTN6?=
 =?utf-8?B?VUNKTTgvWWhCVGt0YWduSy9yYjFZN0Y1QzNQUDIzZlBMaHE1bjZVQ1pIQ3cw?=
 =?utf-8?B?T1JqazVMUXZRN3llNWMvY0hONjlkWUJhaWEzN3dMM0lMUFlodFVnWW9CQTI0?=
 =?utf-8?B?MkM5eG5VQnFQUDlmVGxVT0dNSGdCZnUzeFUvVEdwQWlvV0NIazI2NXBMVkVl?=
 =?utf-8?B?dGRPbXhZSHFzdFZETGZlK1dPYkVremJZb1hmUExKZnRFcEh1SzVwTXVlR3Bx?=
 =?utf-8?B?RVlmeThFMHprWnNETHBxTG8xR0sydFozS1lLcW5WVlBRcGI4SXIydEh2NWd5?=
 =?utf-8?B?Vko1TEF6TFV1cDJxQnVKZVJLbUxQd2FHNU95NDM5aUVKeDlwQWtuZERQdVha?=
 =?utf-8?B?RFI3TTNRWVI3MkhzSmFUQUZveHVRd1htKzN5R1JVM3l3OEtxWkRhS1FzODJv?=
 =?utf-8?B?WGdXY2Z6azRsYmJmSDJiSERBcm5WazQ5Sm9lWm9KQ0hVYXkrT1VwejlXYjZU?=
 =?utf-8?B?bEh0bGFSVUxJRTJQa1doRGVNK3BKQkJoZC95KzNRZlZtNUh0MEU1ZE45dWpS?=
 =?utf-8?B?TzVFaUsxMjlkTFdyeXRkRmxjYjlYbUlVWUIxTFFja1BtS2J1elU3NkZrOFBQ?=
 =?utf-8?B?YnlvVHd3RUEvbkIzaXljTUJrY3pmS1k4bStqRjFDUU43Ympick1lK1JGd3NG?=
 =?utf-8?B?UGhZd05ZSmlLNkRhUFNGSEsySTcyWUQ1Y3BQWUJ6YXZXakFadDdTcDZWcUZw?=
 =?utf-8?B?VTJhRmtYV2NoVVEyT0ljTXo1UzRWVGcvUHNmb0haT3d3ZWlYaG5hc3ZkV3ZE?=
 =?utf-8?B?ajdiZGwyOUxsV0lkQWZrWUcvWjZ5bjlCWnlEaXJvNG16RENHbDFlTlpuMnBo?=
 =?utf-8?Q?WrWdLOuNcox8k48JhzzFLto=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?TzlCSXJQQmw1ZkZnd3o3dTcwRlF2YUNVa3MzbEZhQWtrQ1BKU3FJamR5VXRi?=
 =?utf-8?B?V3NkQUx5cjliQW9scjZwQW9NRThWa210cFE3OU01eDlyYlBza3pJbGJUV2kr?=
 =?utf-8?B?Z2xnZlhYaDQ4MWJpRDlRRnVlNSs5U0dIVW4zM3RIcndTZm9sTFpTVGNZdUxh?=
 =?utf-8?B?S28rcFF4L0pVK0RGM0drWFJhOE01SEV4V05YdjhjcjhaTVM5bktaR1pjanhW?=
 =?utf-8?B?UGR3YVM3U0Vpa0d2Njh1Z0k3TWRycE42UDhRc1hxc1QvdVBpYnB1S0E4RTUv?=
 =?utf-8?B?WkRESHBFb21GWjRlN25JRk13RkdpQ2w3UEF6c2VnT0dQQ1lXYlNlbmRNWWNQ?=
 =?utf-8?B?QjN6QlhQUVgraG1vQU9VV2R3RHF6bW5LbDNiYTFLdkh0cUt5K0c4SWx1RVU2?=
 =?utf-8?B?aUtYLzE0MmlyYzAwaStvTjUvcVBCdzVRSDVOcXR6QUFTWExIUDhReVZYUVdz?=
 =?utf-8?B?ZE5QZDd5UEZtc0k4c3I5dnJraE5QVDczVGVMVHdoU0JXbVhEc3k2WVFCdHlD?=
 =?utf-8?B?YzlYOVB6dXhwa2szNkxDekhielNYRFI4R1FIb1lWakU4VTd5d004WnRNcC8x?=
 =?utf-8?B?UzFyVnE1Tk1XMGFFanpRVXRsVXV6TXNLb1JIcGpMTWZPeXd5S29QRi9BT2pP?=
 =?utf-8?B?ZHJkbVBJZmhoVDF3UUNIR3BMNW1hSlR1cDdudGxNbHhHRHJOOThGVmxwQnNH?=
 =?utf-8?B?NGtOY1lkY2pKd2gzc1FzZ1lieWE5djByR1NTNGlMa1hxNDZ6YlBFSjdCTERG?=
 =?utf-8?B?NGFpZ2pTNDNNa0lWT0wzcGNrbTRiV2s0alZNOFRGdFdQdzBiVm1hbnhNRE9I?=
 =?utf-8?B?cjMrR2FhSjZoMHJQL1BEcjdqY2tScGduRFVGZFNCVHFIQS82YTk4b00yQXF0?=
 =?utf-8?B?U2xIY24rU0dkdFVtUTNuTDQ0Q1lEdXZWbmV6RThIWXFjYmdFdDhBaDlxMVNU?=
 =?utf-8?B?aUVLV1lYS1djVmZmcmZ4WjNhNjVhcTBQaFNqbGJONDZaRVFEWlRtM0xjZDl6?=
 =?utf-8?B?MFA0OTRnSE5pZS8zV1ZhTmpia1gvb0pnTGNRNCtmaGFCcXpQYXg5NUZpWTQy?=
 =?utf-8?B?SWlzMVByMVJ0UVIxS1MrMjRWYXZMRGxtZ1IxNUJzamxSdG9IYkxkb08xem5G?=
 =?utf-8?B?d0tGMktldGhEbk1NQ3ozQ3RWbjVKd1VqaHZUeW52Z0QzL0xOM2ZUL0JTTVdp?=
 =?utf-8?B?TXpLY241TDlXVWlRNnFvVFFWZy8rZklhOUd1dkpmcFZYVzVpdDJ1M0E1MmIy?=
 =?utf-8?B?M1VSTEJ0TjFRbkc1Snd4WHEyOEo0bTU3dmxYTytIR25ScGptczRMWklnbkgv?=
 =?utf-8?B?UmgvQ1lMUGFibEU1Z2dXc0djRTR5OU1JdG44WU8rMlJzL0N2bW1sakd4RDNx?=
 =?utf-8?B?Rnk5YmpZbmpPWldBdS9HL3ZYZWlHeHJnaTlHaEJsWFl0WW1HMmg2RTZMdFVZ?=
 =?utf-8?B?K3Jab083VGhmYUwwM080K2hEckZCWHRDTG14UWQrdTZvWm42c2lUV0pNV0dl?=
 =?utf-8?B?d3FISzllbkZ3RU9vbkVJUmJGclljVjVqdVpUTXlPcU96Tk1mSEt2WFl6T2FN?=
 =?utf-8?B?STFtb3FLZ2xsbUZxUTNhNFZCRExwNTlOWnRBaVFQRU02eVZ0djZTd01HN01M?=
 =?utf-8?B?U1AyV0ZpV280c2IraXg3dS9qdEN1VVFxbWZMRlRiZ1o5SnhONkI2ekE2OFdH?=
 =?utf-8?B?MWlqWGhxdjlwRkswUzl0UFdicldoOEMyendremRBQWJLdFRNZnpEYWpnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1cff365-4f65-4a31-3870-08db4028732d
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 16:17:48.2584
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AMSez0nXCwBPEhmLeUyp/B54Yig2fV183rKpt0epGzd4zvpwMZbr2rmtPuDPNWUNcou8SKkHYW7y1I78LHHs82gkrDdoSD3v9TJyWLHQApJg5uLeXHJHTCxwXZl5aXw2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7287
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-18_11,2023-04-18_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304180136
X-Proofpoint-GUID: Qvnve6BxB8IeruVOnUEokxM8YWYaAYIS
X-Proofpoint-ORIG-GUID: Qvnve6BxB8IeruVOnUEokxM8YWYaAYIS
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

On 18/04/23 8:17 pm, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 18:07, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 5.15.108 release.
>> There are 91 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.108-rc1.gz
>> or in the git tree and branch at:
>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
> 
> 
> Following patch causing build break on stable-rc 5.15
> 
> 
>> Waiman Long <longman@redhat.com>
>>      cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> 
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> Build error:
> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2979:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
>   2979 |         lockdep_assert_held(&cgroup_mutex);
>        |                              ^~~~~~~~~~~~
> include/linux/lockdep.h:415:61: note: in definition of macro
> 'lockdep_assert_held'
>    415 | #define lockdep_assert_held(l)                  do {
> (void)(l); } while (0)
>        |                                                             ^
> kernel/cgroup/cpuset.c:2979:30: note: each undeclared identifier is
> reported only once for each function it appears in
>   2979 |         lockdep_assert_held(&cgroup_mutex);
>        |                              ^~~~~~~~~~~~
> include/linux/lockdep.h:415:61: note: in definition of macro
> 'lockdep_assert_held'
>    415 | #define lockdep_assert_held(l)                  do {
> (void)(l); } while (0)
>        |                                                             ^
> make[3]: *** [scripts/Makefile.build:289: kernel/cgroup/cpuset.o] Error 1
> 
> 

We observed same build error.(5.15.108-rc1), and investigated about this.

Please see the below findings.

With defconfig --> build breaks.
With allmodconfig --> build succeeds.

 From the above we know that this is something related to CONFIG.

In 5.15.y -->
cgroup_mutex is defined like this in include/linux/cgroup.h

	#ifdef CONFIG_PROVE_RCU
	extern struct mutex cgroup_mutex;

In 6.2.y --> include/linux/cgroup.h

	extern struct mutex cgroup_mutex;

-- We don't have that ifdef in 6.2.y.

Tom Saeger identified that the below commit moves it out of ifdef.

commit 354ed597442952fb680c9cafc7e4eb8a76f9514c
Author: Yu Zhao <yuzhao@google.com>
Date:   Sun Sep 18 02:00:07 2022 -0600

     mm: multi-gen LRU: kill switch

Given that we don't have this commit in 5.15.y and 5.10.y we are seeing 
this build problem.

on allmodconfig:

~/linux$ grep "CONFIG_PROVE_RCU" .config
CONFIG_PROVE_RCU=y
CONFIG_PROVE_RCU_LIST=y

on defconfig:
~/linux$ grep "CONFIG_PROVE_RCU" .config
-- No match

This explains the failure on defconfig and a build success on allmodconfig.

Thanks,
Harshit


> build log:
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.105-280-g0b6a5617247c/testrun/16291026/suite/build/test/gcc-11-lkftconfig-kunit/log
> 
> --
> Linaro LKFT
> https://lkft.linaro.org