Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5640696rwe; Tue, 18 Apr 2023 09:22:52 -0700 (PDT) X-Google-Smtp-Source: AKy350ZUG/KbTD6xCn/EJsiknhbfvaq8oU06fQSdFASOK3eX5Ey9kHwtdyEOIzsK4YnqM6r8QV83 X-Received: by 2002:a17:903:32d2:b0:1a6:bbf4:ed79 with SMTP id i18-20020a17090332d200b001a6bbf4ed79mr3213755plr.20.1681834972274; Tue, 18 Apr 2023 09:22:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681834972; cv=none; d=google.com; s=arc-20160816; b=EK4AVk246TbVl7/GiU/cJ9wxnfRiXk1hJcFgnqDKJGCamqhU3RRpJh9uApc4floaDV C2GS8XFIiMxZIl759MWmA0BB+EB3pdvGRQF0p9rJDs8LJwn8Aabz4e8efhKXcLUY+69W As+OqA9aZCaqS09m4N9jXl7DLGRby8g3T0ztKHZUGwtuNrnGW5biI/Xlzhe1fKP2ZDNX 3/SSyOwbA6AyOfPyyvtGdufitjA6+l7SNdcpSazyIQKCIP55fCniY43mhZlj9P5xyJgI cBfw8Wauz+orgxc7hhZ2opT8hNV4M9NPq2TWBifyrXFAKJnuSKjQPG/4q8w7oSkNEa5C sJxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=b2qUHxbFNWuVEA2GFkOYquFZaX+TXj0U5db+f7oebUc=; b=WimXvVR6dIm9+VZt8FNNb8CXMklVULFEL/LOf3cRQvmGYhuz5bckPCvHHlTAc1GneN /jRm5Yhtkp+zsn/0S+b0N7L7SorzA2YKqsbD3v8mHBL7e6nV2AFpvKFWbXI/D+6ZcJj5 /hPvBVXhcn+7jJOITjYq0NB7ZRjCDuze01DNGJpLB2CrAHaNdwuIi6nkvE7wFh2NC5Ec zKZVaUzwmrncvfWh/weY9gQG+orPxP9p88ElXkRz4Kw4zZClT34ar/Gd2T2MgelmW9rM fwAIgg86A7b5DbgRI6w9x4LgIH/+cjRstug0PyDHxxZSBHSn9P7qg7LEp6YG0lmTRoDk 3hRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=YprVtvHJ; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020a170903018700b001a6d4f56673si6048143plg.457.2023.04.18.09.22.40; Tue, 18 Apr 2023 09:22:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=YprVtvHJ; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbjDRQRy (ORCPT + 99 others); Tue, 18 Apr 2023 12:17:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231995AbjDRQRt (ORCPT ); Tue, 18 Apr 2023 12:17:49 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D83B3C38; Tue, 18 Apr 2023 09:17:43 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 50E3821A73; Tue, 18 Apr 2023 16:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681834662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b2qUHxbFNWuVEA2GFkOYquFZaX+TXj0U5db+f7oebUc=; b=YprVtvHJtRcqjlb3CsUw2yq2ICBKIMjhBhRuz0tFbup2qCvM5Ywz1qUmcgSSLHy4ffJKti QPVjiXbxBgVO02PXo3Rc0Yke5FyuchVzvW9vF14UdYg4Vem2xful+Ro260ioOiYODQuGLE FjSaZcciQgN60rDLszBPTMWiEMyQwLk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681834662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b2qUHxbFNWuVEA2GFkOYquFZaX+TXj0U5db+f7oebUc=; b=H/2rgK6FudddyhQ9P22occLyWHJ43icsOXCK30w75uiWE++dPUKrrlBZDKldFoK37CqXz3 cZ4ZlCGz/2W6w8CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 410D613581; Tue, 18 Apr 2023 16:17:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id owDcD6bCPmSMHwAAMHmgww (envelope-from ); Tue, 18 Apr 2023 16:17:42 +0000 Date: Tue, 18 Apr 2023 18:17:41 +0200 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki Subject: Re: [PATCH blktests] nvme-rc: Cleanup fcloop resources in reverse order Message-ID: References: <20230418123252.3725-1-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230418123252.3725-1-dwagner@suse.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 02:32:52PM +0200, Daniel Wagner wrote: > We need to free the resources in the opposite order as we allocate them. > The deleting the rport first will also free the other resources. When > we try to release lport and tport they are already gone. I found some more ordering issues with fcloop resources.