Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5667169rwe; Tue, 18 Apr 2023 09:44:04 -0700 (PDT) X-Google-Smtp-Source: AKy350Y2oUCjQtoFU+CZX1ArFjeEzzs+1/dSSTR5VTZAA6tD/nSxitPXHxNq7nIQgBpF7ErlnNTA X-Received: by 2002:a05:6a21:99a0:b0:da:c7e:6ec0 with SMTP id ve32-20020a056a2199a000b000da0c7e6ec0mr379643pzb.25.1681836243808; Tue, 18 Apr 2023 09:44:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681836243; cv=none; d=google.com; s=arc-20160816; b=j073MB7oqFB8jhpo9XOTN80zw1CoVhOZFjuE0ZGl8JbnHi8F0jTNXhwhnvHc/mnUaC bRZNYIxCaNBQIaBv2p4iMaB1Sc2g3oALi2Cy3nDUhoDlFR11AxRIHfWtivL7fEp0Z1rE oW0LKvdlEE64RM7WTb11e9W7ZQUFDedCVfTBb67PGJoMgQXbbuZEOyJtpI+O9+cO7F6g sWHpef2TgOgjOn54azrULfNQHHnxFGpEh8cjygdQlUHQtUFiMlEtVJGNIlWc8JuLCFX6 3RydYfiKM/ErjFqxz5rsDDbD3W58Hq/GwaNLDDJ4LGTIEqXQA9/SNcDRW//q2yLd3Pf/ s7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=PnHeIqQhcqSjPYjup2fw8CkFsVSZdUVKQ9idL5SwNNQ=; b=hWL7nwoD7y666n6DkRgITQFeIiemV0nB8PLORlyR+BWGr8lCbq5bw5LEpswgVTde8k W74UjaGeV1PIMpVMyv+uLeziOQLGMWujNMmIhKuRifFaeAkK6chhE//NS560Gj8QJBTQ ghOTVbDJM0NVvBg8LpoLvTOvb+QfcU5jtiCAvqHh8gv2WbeG9+AvOIPgN8amh264y9v1 AVqCRK+BFTnGPagoOiOIpb8vl2hkXDbSVKMCqn+GRZfMJ5HyKTy0c2/G374s0djoKxqd cw3kO+qVVixcuKpSWhMsd94mzIv5XdE2lpx+yMYUKQAYBZuteBZUPG8Po9mH+E9942QW oHeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=lxLNotAZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020a632a03000000b00519d69a233csi15218779pgq.626.2023.04.18.09.43.49; Tue, 18 Apr 2023 09:44:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=lxLNotAZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231769AbjDRQgh (ORCPT + 99 others); Tue, 18 Apr 2023 12:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjDRQgg (ORCPT ); Tue, 18 Apr 2023 12:36:36 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CE20B450; Tue, 18 Apr 2023 09:36:35 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id dx24so30758529ejb.11; Tue, 18 Apr 2023 09:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681835793; x=1684427793; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PnHeIqQhcqSjPYjup2fw8CkFsVSZdUVKQ9idL5SwNNQ=; b=lxLNotAZUnqMNo2fLitBC0+/A8GBfNQHJXspuNy/BTJV4W/m2eylZeo9EpWO1Cl3gZ Kanq0WpjBZ5HE0eagBe9swmFzdWQiNzVV5W2m4yxelkZhQ9zBKp4Pwc3taE8Qz8pivZM qLREZHFiOy9P0blgdL2BAjbj204BtjoML+UrsLfxkqqpQJqRFNDOrpfPgRw/dwfY2Kz5 9O3JDpQ9abjVdIKUlsHORVt8w99hmuvHq0j7toKAleOC5qrCwHaxz7fhV3E6lKYzv9Ly /iZ4JF3S6qKrADkU4gHmyPmiDJ6spGhF3rzFE/UQTU/WOEctvOmP0vSUpC2TFk0sbbCd mgJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681835793; x=1684427793; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnHeIqQhcqSjPYjup2fw8CkFsVSZdUVKQ9idL5SwNNQ=; b=MmGpJCn9WHNDMLLqsZnnWAbjPF9yBv14dcZhJoX8ATEXytizUZT84UsvUtwsTa3f6X 79/QjrbxlintS7fUCXnF3ulbCfn+N/J+NhSlBS/ggSf2kTVG469WxO1IRzAIp4jncGgl 70TxAEy713t0l/4uIBsbhNzxeS/gZqsKxrL/PWEfiKSqtnc7xXNIu53xaFA8nk25evpm i7XznqTfN4SDAfC+RpOnNT7B23X00ax9DivT9s0DTdlmHAaMbr7S8CvrfXxtvtCMbjYC FdtIyjgGxtkHRZdPhLrsV8RUdRkA9aBRmRZJxgA2muSXnGyl2Jpo4RCF8cvMuMtlHJXU eVPw== X-Gm-Message-State: AAQBX9cjWPPe7veynJ/KEwHA+DnQsmECtCVY+pkfY5kSTjsMF/KWG6bt aRrPrcYFKwdIpoMSEYaOr+2LCUa1xIojTq76ZB4= X-Received: by 2002:a17:906:6708:b0:94a:99a4:58d7 with SMTP id a8-20020a170906670800b0094a99a458d7mr11663701ejp.15.1681835793385; Tue, 18 Apr 2023 09:36:33 -0700 (PDT) MIME-Version: 1.0 References: <20230310144710.1543139-1-robh@kernel.org> <20230418162500.GC1764573-robh@kernel.org> In-Reply-To: <20230418162500.GC1764573-robh@kernel.org> From: Jassi Brar Date: Tue, 18 Apr 2023 11:36:22 -0500 Message-ID: Subject: Re: [PATCH] mailbox: Use of_property_read_bool() for boolean properties To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 11:25=E2=80=AFAM Rob Herring wrot= e: > > On Fri, Mar 10, 2023 at 08:47:10AM -0600, Rob Herring wrote: > > It is preferred to use typed property access functions (i.e. > > of_property_read_ functions) rather than low-level > > of_get_property/of_find_property functions for reading properties. > > Convert reading boolean properties to to of_property_read_bool(). > > > > Signed-off-by: Rob Herring > > --- > > drivers/mailbox/hi6220-mailbox.c | 5 +---- > > drivers/mailbox/omap-mailbox.c | 3 +-- > > 2 files changed, 2 insertions(+), 6 deletions(-) > > Ping! > Pong :) I don't usually reply back that it looks good and will pick for the merge window. I just do that. So yes, it is not overlooked. cheers