Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5705020rwe; Tue, 18 Apr 2023 10:14:27 -0700 (PDT) X-Google-Smtp-Source: AKy350Zwzn01XqQmSAPjxXeBnbF+bakDwnMXsBPF8XAD+jHmQTxvljsEV7Kq+3ZF+LTUfaaIYNfb X-Received: by 2002:a05:6a20:914c:b0:e5:5076:f4d6 with SMTP id x12-20020a056a20914c00b000e55076f4d6mr551912pzc.9.1681838066748; Tue, 18 Apr 2023 10:14:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681838066; cv=none; d=google.com; s=arc-20160816; b=SuQTQYggoA5PS4WReKKYSCTTkwuJLlTSTWENM6wil9cxaiTmbcriTt0CfHwvSXVzVD 7FWZa2B0U15sT2b+w2Jksq5Wig9tACR6xNU1a12uyM8VIqQ+AjvKxW/E/ZICw6N3DIUR VMJE7PJ1AAfc2upESdjrg5RH4nZ+vTYuggNG6dEVVBiBuW91WvEDdeutN+1mNF+QRGQJ YA+yKyJ2sulIp59DYHNvyxEq2ixn6jQtpmd8ze/bOlcuL2bBZgFyGSCpcHF36X49sk3J 7Ks3FQZaUjAcX7N99WrLY/1k9tt7Wn60YQyuFs5wG+zk6/ehXiAxKPtqcqL4OhWW+dbI Ecmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=XFT9JV5GyQiNBSCe1AemNF0qZg+yfPpP2DZKZsBupIQ=; b=b9gFDclCTs++UQdjbT6hDuUY9SvOOZHokGcr/f9uruJsdx5XsxlcU8Bj0lRKneWRyl uVZnM/xAH3kmQTpvsjyOC+zGAKH6Wrn7b3hc1tR3QJF3fEKB6xbHd1/zx/w950o4HqQ7 wC/voEONqF5Rcc8lv+P0Z+qWosfw53cZbZJ81P00mVz3A/5S7MvmickcpkPbdo/kydvV AqwlcjbFrPmhp9W/fnhIH7FRHCKC5Zrq6kdNzF/IzZ+8HR5CegtDK1S9kb12CEwW+FhZ Lyxvo7VdFuMrTu/alqcg6qaYp2r4SKiBp+6iBW3VR0jq8yyYTGAaQbvyQyV8Px7tnmNi d+bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uTY1Ft02; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020a63dc10000000b004fca80d4647si14428778pgg.216.2023.04.18.10.14.10; Tue, 18 Apr 2023 10:14:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uTY1Ft02; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232370AbjDRRLI (ORCPT + 99 others); Tue, 18 Apr 2023 13:11:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232456AbjDRRLC (ORCPT ); Tue, 18 Apr 2023 13:11:02 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D9ED35BE for ; Tue, 18 Apr 2023 10:11:00 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id dm2so75154232ejc.8 for ; Tue, 18 Apr 2023 10:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681837859; x=1684429859; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XFT9JV5GyQiNBSCe1AemNF0qZg+yfPpP2DZKZsBupIQ=; b=uTY1Ft02GOPK/nE7NmdYz03m5k1rE5T7q7DsFkj9wWIv9X5Nj829dMM7p3LYlSZhwp qoLK+zafpJgGnfuJUTYpoWjHkDgWqyg0OsCsc161Dbt60SRe3wskoW07Arxqvc+ACNPz qtCcgsgq/9sNPmToRVrCECVdvpLAMg7RI0mTF9M6TuXFgiYHFCpD8iekawiu1Kn5ZahR oaIiBKzB+TDnaeKkmlFI1w/l8qViMIwvHq1rcRDplYeOM+wqLQ/pbW9etV4Q7Pn/b+Ux DkATLzqkNCe1eyx8cGMDh2Rp4URG/R4AGMpb8+B5sJmsNGlXevWW3GI7O9XvTYrj8use zV1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681837859; x=1684429859; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XFT9JV5GyQiNBSCe1AemNF0qZg+yfPpP2DZKZsBupIQ=; b=Puv6lhzaSWJXHjkx3ymnIJhsYKK7YKMxqxNXbw7nGKntAqaaqBI3Jfvq87IKtqGKEF F48AkKcT5jk/ezRqVL5wdsbxMIrENDGFxhEkBhuSf3I/Webr4uHhqUhmTalnX+T90F0y amd+ZDKCG4Hs1w7joUjtZVuxNw/TL2iGP4Bbfs+Zm9yuHioYwfkiSXr/NSBvam+4mg82 3A4KCxjd5W3x9FvF4XCJy1bLF2oM64e0dBQwdr1IxZz+UmKB1naagaRgHQehwgHQ7Jqn 6lgVy2s2pRq06jIYGzh5k7J3wJSV33B4vngpoLeDLJNtJwdCJ6g1rTIY/KKO7KFb7MtB Jccg== X-Gm-Message-State: AAQBX9d2zl12MX7lLATGjFw33XjAJeI14dIoVK212cWix7bJiF5I5PmK 8RD5fBuj/L1TSpjX12w/VkE96A== X-Received: by 2002:a17:906:d8a9:b0:947:72bd:f72a with SMTP id qc9-20020a170906d8a900b0094772bdf72amr11334696ejb.72.1681837859058; Tue, 18 Apr 2023 10:10:59 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id s13-20020a1709060c0d00b0094e729d333fsm8221908ejf.222.2023.04.18.10.10.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 10:10:58 -0700 (PDT) Message-ID: <30319890-353e-bf52-fa19-0cc7aeb41074@linaro.org> Date: Tue, 18 Apr 2023 19:10:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 8/9] ARM: multi_v7_defconfig: Add PSU, GPIO, and I2C Content-Language: en-US To: nick.hawkins@hpe.com, verdun@hpe.com, linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, jdelvare@suse.com, linux@roeck-us.net, linux@armlinux.org.uk, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230418152824.110823-1-nick.hawkins@hpe.com> <20230418152824.110823-9-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20230418152824.110823-9-nick.hawkins@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UPPERCASE_50_75, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/04/2023 17:28, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > Add the CONFIG_I2C_GXP, CONFIG_GPIO_GXP, and CONFIG_SENSORS_GXP_PSU Why? > symbols. Make CONFIG_SENSORS_GXP_FAN_CTRL=y Why? Please briefly provide rationale in the commit msg. > > Signed-off-by: Nick Hawkins > --- > arch/arm/configs/multi_v7_defconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 084cc612ea23..fcfbcd233fb8 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -405,6 +405,7 @@ CONFIG_I2C_DAVINCI=y > CONFIG_I2C_DESIGNWARE_PLATFORM=y > CONFIG_I2C_DIGICOLOR=m > CONFIG_I2C_EMEV2=m > +CONFIG_I2C_GXP=m > CONFIG_I2C_IMX=y > CONFIG_I2C_MESON=y > CONFIG_I2C_MV64XXX=y > @@ -478,6 +479,7 @@ CONFIG_GPIO_ASPEED_SGPIO=y > CONFIG_GPIO_DAVINCI=y > CONFIG_GPIO_DWAPB=y > CONFIG_GPIO_EM=y > +CONFIG_GPIO_GXP=y > CONFIG_GPIO_MPC8XXX=y > CONFIG_GPIO_MXC=y > CONFIG_GPIO_RCAR=y > @@ -527,7 +529,8 @@ CONFIG_SENSORS_NTC_THERMISTOR=m > CONFIG_SENSORS_PWM_FAN=m > CONFIG_SENSORS_RASPBERRYPI_HWMON=m > CONFIG_SENSORS_INA2XX=m > -CONFIG_SENSORS_GXP_FAN_CTRL=m > +CONFIG_SENSORS_GXP_FAN_CTRL=y No, we want it to be module. > +CONFIG_SENSORS_GXP_PSU=y Same here. > CONFIG_CPU_THERMAL=y > CONFIG_DEVFREQ_THERMAL=y > CONFIG_IMX_THERMAL=y Best regards, Krzysztof