Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5724254rwe; Tue, 18 Apr 2023 10:30:58 -0700 (PDT) X-Google-Smtp-Source: AKy350Z9wCmZZR7h43Us5Z+q4dP5DpUy5xziWER4/F8RcmWf5Pif9JFETaiRors04e/vzWAZpO2B X-Received: by 2002:a17:902:e892:b0:1a8:13fc:a654 with SMTP id w18-20020a170902e89200b001a813fca654mr592823plg.25.1681839058204; Tue, 18 Apr 2023 10:30:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681839058; cv=none; d=google.com; s=arc-20160816; b=D8T6osfaAQnVd3RXnzM3hdl0IHHJCkCKyGBV7bsk6pj9XMGm0rn52wjbUvudQLNrwy mVDL1OrZ/apFJYOY8asY16KcAEy933Q2J/Vxue8m9rW/sOT5MBpPR4aN4x/v9gMrx8Vb eYF6ahtH76RARSbB0l3sxOzHHgPbDqCEU0gGkhHWpxdEocLykoVXzVZjoF7Cnu0Rbt/n WYRbAsVETasiI0fRfon0xhBVQeoVlhahUi+wcmXjPtl3Qvq6T/vejKVsd0uyOfck5ia8 Fvl0RXBvBE+lHdt4cFDz1f+c325fsY3dTNrJVYGGS9HQeqNmiEmUbASx2lWgH3a805yj NWtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=s7I2Ujk4fWNMbH958reTploJwkQ8QuVNWZaR69Sljio=; b=s8aL+VAT6xJNipCthlvgn3LknLb/GTuEdZWPfcnX7VrnkRj6ERf0a1Bqh+KOGpOcob aUm0VFBksjEUa45nSkTX8q1IfxFvbYj4EzV41V3J0wHVoPS7DLeYNp2MejOLkIfR3t2X 2DZRckf/D6KCWvQ8JjgaZRwnksv7o7eddENUuXD9GaoIGJuDoP3ad1Gpf/dSXzIlhrgJ Xc7clF97YJs75Y0zOhT3oZRqfDzJmuH98Nc0iQ7kYVQUBpvnkjhwxt1w7ZIdWCqXW44U oeJ7md7had2y2fhlqBexLX8KDh1e/XBAAF4fMLkkocfPIIerk8UG5/nbUCJENtG1VCpk EDYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Qcq1z/v6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x18-20020a170902b41200b001a6fe422891si2102630plr.205.2023.04.18.10.30.42; Tue, 18 Apr 2023 10:30:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Qcq1z/v6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232449AbjDRR34 (ORCPT + 99 others); Tue, 18 Apr 2023 13:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232513AbjDRR3s (ORCPT ); Tue, 18 Apr 2023 13:29:48 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28BFF9023; Tue, 18 Apr 2023 10:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681838987; x=1713374987; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mvcm9I7oVMk743K1U4CKLSb1SD+72HuGUMTrE4bjIiU=; b=Qcq1z/v6btmLY+arprg69itcm9V4nnp/E4U6pQFwfCrhmM+IzikxOyo2 vtjj7k7wuLAhwTbmlsOiBifGjeB2eBs/a3wBBquJHcsJIUKc7tmQOYP0E Q8uYBDZg5+S8FVmG1YVlwZ6hhTT3/OWO/2Zxhw5oQpAwq6AURT7VYTw4R UlgkQgRS9H7yBZ94NvJKiLjhzxJDy2vv2oPjBqJgNPszYlx8PisoRj4DB aOrw0crkXf2iMqtOunFjfxQTdHP9j71l1Og2pN315TOCM1a6+8sQNmqfL /dB8yvHldfw/neYkqR3pa7eJz6YwHtY/H6q0Cym8D79E/5D+GZ4cQVMpk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="410466447" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="410466447" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 10:29:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="865503470" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="865503470" Received: from rchatre-ws.ostc.intel.com ([10.54.69.144]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 10:29:41 -0700 From: Reinette Chatre To: jgg@nvidia.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com, alex.williamson@redhat.com Cc: tglx@linutronix.de, darwi@linutronix.de, kvm@vger.kernel.org, dave.jiang@intel.com, jing2.liu@intel.com, ashok.raj@intel.com, fenghua.yu@intel.com, tom.zanussi@linux.intel.com, reinette.chatre@intel.com, linux-kernel@vger.kernel.org Subject: [PATCH V3 01/10] vfio/pci: Consolidate irq cleanup on MSI/MSI-X disable Date: Tue, 18 Apr 2023 10:29:12 -0700 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vfio_msi_disable() releases all previously allocated state associated with each interrupt before disabling MSI/MSI-X. vfio_msi_disable() iterates twice over the interrupt state: first directly with a for loop to do virqfd cleanup, followed by another for loop within vfio_msi_set_block() that removes the interrupt handler and its associated state using vfio_msi_set_vector_signal(). Simplify interrupt cleanup by iterating over allocated interrupts once. Signed-off-by: Reinette Chatre --- Changes since V2: - Improve accuracy of changelog. drivers/vfio/pci/vfio_pci_intrs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index bffb0741518b..6a9c6a143cc3 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -426,10 +426,9 @@ static void vfio_msi_disable(struct vfio_pci_core_device *vdev, bool msix) for (i = 0; i < vdev->num_ctx; i++) { vfio_virqfd_disable(&vdev->ctx[i].unmask); vfio_virqfd_disable(&vdev->ctx[i].mask); + vfio_msi_set_vector_signal(vdev, i, -1, msix); } - vfio_msi_set_block(vdev, 0, vdev->num_ctx, NULL, msix); - cmd = vfio_pci_memory_lock_and_enable(vdev); pci_free_irq_vectors(pdev); vfio_pci_memory_unlock_and_restore(vdev, cmd); -- 2.34.1