Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a340030b-ce07-72e8-ba41-2896b31b4f1f@efficios.com>
Date:   Tue, 18 Apr 2023 14:24:39 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [RFC PATCH v8] sched: Fix performance regression introduced by
 mm_cid
Content-Language: en-US
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To:     Aaron Lu <aaron.lu@intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, Olivier Dion <odion@efficios.com>,
        michael.christie@oracle.com
References: <20230417150831.264780-1-mathieu.desnoyers@efficios.com>
 <20230418112151.GA565498@ziqianlu-desk2>
 <40689cd1-af60-542d-2245-c6362c73a365@efficios.com>
In-Reply-To: <40689cd1-af60-542d-2245-c6362c73a365@efficios.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-04-18 12:01, Mathieu Desnoyers wrote:
> On 2023-04-18 07:21, Aaron Lu wrote:
>> On Mon, Apr 17, 2023 at 11:08:31AM -0400, Mathieu Desnoyers wrote:
>>> Introduce per-mm/cpu current concurrency id (mm_cid) to fix a PostgreSQL
>>> sysbench regression reported by Aaron Lu.
>>
>> For postgres_sysbench on SPR:
>> sched_mm_cid_migrate_to() is in the range of 0.1x% - 0.4x%, mm_cid_get()
>> is in the range of 0.1x% - 0.3x%. Other cid functions are pretty minor.
>>
>> For hackbench on SPR:
>> ched_mm_cid_migrate_to() is about 3%-4%, mm_cid_get() is about 7%-8%,
>> other cid functions are pretty minor.
> 
> It's a bit higher than I would have expected for hackbench.
> 
> Can you run with the attached schedstats patch applied and boot
> with schedstats=enable ? Let me know how the counters behave please,
> because I cannot reproduce anything unexpected on my machine.
> 

Also, just to confirm, do you still use this hackbench invocation ?

hackbench --pipe --threads -l 500000

Thanks,

Mathieu

> Thanks,
> 
> Mathieu
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com