Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 18:32:47 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     "longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        Long Li <longli@microsoft.com>
Subject: Re: [PATCH v2] Drivers: hv: move panic report code from vmbus to hv
 early init code
Message-ID: <ZD7iT/+Uil3jTuNO@liuwe-devbox-debian-v2>
References: <1681435612-19282-1-git-send-email-longli@linuxonhyperv.com>
 <BYAPR21MB1688377B56A9A844EAABEEDAD79E9@BYAPR21MB1688.namprd21.prod.outlook.com>
 <ZD2dxHaq8NDzpfYw@liuwe-devbox-debian-v2>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZD2dxHaq8NDzpfYw@liuwe-devbox-debian-v2>
Precedence: bulk

On Mon, Apr 17, 2023 at 07:28:04PM +0000, Wei Liu wrote:
> On Sat, Apr 15, 2023 at 06:16:11PM +0000, Michael Kelley (LINUX) wrote:
> > From: longli@linuxonhyperv.com <longli@linuxonhyperv.com> Sent: Thursday, April 13, 2023 6:27 PM
> > > 
> > > The panic reporting code was added in commit 81b18bce48af
> > > ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic")
> > > 
> > > It was added to the vmbus driver. The panic reporting has no dependence
> > > on vmbus, and can be enabled at an earlier boot time when Hyper-V is
> > > initialized.
> > > 
> > > This patch moves the panic reporting code out of vmbus. There is no
> > > functionality changes. During moving, also refactored some cleanup
> > > functions into hv_kmsg_dump_unregister(), and removed unused function
> > > hv_alloc_hyperv_page().
> > > 
> > > Signed-off-by: Long Li <longli@microsoft.com>
> > > ---
> > > 
> > > Change log v2:
> > > 1. Check on hv_is_isolation_supported() before reporting crash dump
> > > 2. Remove hyperv_report_reg(), inline the check condition instead
> > > 3. Remove the test NULL on hv_panic_page when freeing it
> > > 
> > >  drivers/hv/hv.c                |  36 ------
> > >  drivers/hv/hv_common.c         | 229 +++++++++++++++++++++++++++++++++
> > >  drivers/hv/vmbus_drv.c         | 199 ----------------------------
> > >  include/asm-generic/mshyperv.h |   1 -
> > >  4 files changed, 229 insertions(+), 236 deletions(-)
> > 
> > Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 
> Applied to hyperv-next. Thanks.

This broke allmodconfig. I've removed it from the tree. Please fix and
resend.

Thanks,
Wei.