Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 13:40:02 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     linux-pci@vger.kernel.org,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Yue Wang <yue.wang@Amlogic.com>
Subject: Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt
Message-ID: <20230418184002.GA148053@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cdcd04e2-13dc-3dac-daf5-ea784af75467@gmail.com>
Precedence: bulk

On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
> On 4/18/23 10:43, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> > match other PCIe drivers.  Capitalize "Meson" to match other Meson Kconfig
> > prompts.
> 
> Did you mean, do not capitalize "Meson" or did you intend to preserve the
> previous hunk that had "Meson" capitalized?

I made it match other Meson prompts:

  arch/arm/mach-meson/Kconfig-    bool "Amlogic Meson6 (8726MX) SoCs support"
  drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
  drivers/clk/meson/Kconfig-      bool "Meson8 SoC Clock controller support"
  drivers/gpu/drm/meson/Kconfig-  tristate "DRM Support for Amlogic Meson Display Controller"
  drivers/i2c/busses/Kconfig-     tristate "Amlogic Meson I2C controller"
  drivers/iio/adc/Kconfig-        tristate "Amlogic Meson SAR ADC driver"
  drivers/media/cec/platform/Kconfig-     tristate "Amlogic Meson AO CEC driver"

So I guess could have described as "style Meson with initial cap only
instead of all caps" or something.

Bjorn