Date: Thu, 27 Sep 2007 14:51:25 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: hch@infradead.org, laurent.riffard@free.fr, linux-kernel@vger.kernel.org,
       linux-fsdevel@vger.kernel.org, reiserfs-devel@vger.kernel.org
Subject: Re: [RFC][PATCH] make reiserfs stop using 'struct file' for
 internal xattr operations
Message-Id: <20070927145125.1346901f.akpm@linux-foundation.org>
In-Reply-To: <1190928434.7344.31.camel@localhost>
References: <20070927022220.c76a7a6e.akpm@linux-foundation.org>
	<46FC021F.8060109@free.fr>
	<20070927124833.d2691813.akpm@linux-foundation.org>
	<20070927202607.GA3812@infradead.org>
	<1190926419.7344.27.camel@localhost>
	<20070927210423.GA6117@infradead.org>
	<1190928434.7344.31.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1980
Lines: 48

On Thu, 27 Sep 2007 14:27:14 -0700
Dave Hansen <haveblue@us.ibm.com> wrote:

> On Thu, 2007-09-27 at 22:04 +0100, Christoph Hellwig wrote:
> > On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote:
> > > -int reiserfs_commit_write(struct file *f, struct page *page,
> > > -			  unsigned from, unsigned to);
> > > -int reiserfs_prepare_write(struct file *f, struct page *page,
> > > -			   unsigned from, unsigned to);
> > > +int reiserfs_commit_write(struct page *page, unsigned from, unsigned to);
> > > +int reiserfs_prepare_write(struct page *page, unsigned from, unsigned to);
> > 
> > I doubt this will work.  These are also used for the ->prepare_write
> > and ->commit_write aops, and the method signature definitively wants
> > a file there, even if it's zero..
> 
> Oddly enough, I don't see those functions being used in aops:
> 
> const struct address_space_operations reiserfs_address_space_operations = {
>         .writepage = reiserfs_writepage,
>         .readpage = reiserfs_readpage,
>         .readpages = reiserfs_readpages,
>         .releasepage = reiserfs_releasepage,
>         .invalidatepage = reiserfs_invalidatepage,
>         .sync_page = block_sync_page,
>         .write_begin = reiserfs_write_begin,
>         .write_end = reiserfs_write_end,
>         .bmap = reiserfs_aop_bmap,
>         .direct_IO = reiserfs_direct_IO,
>         .set_page_dirty = reiserfs_set_page_dirty,
> };
> 
> Plus, reiserfs seems to compile with that patch I just sent.  Sure as
> heck surprised me.
> 

That'll be because reiserfs-convert-to-new-aops.patch witched reiserfs over
to ->write_begin() and ->write_end().

So your stuff becomes dependent on Nick's stuff, and Nick's stuff is still
failing on NFS, I think.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/