Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230310144710.1543139-1-robh@kernel.org> <20230418162500.GC1764573-robh@kernel.org>
 <CABb+yY3Y8oZYG1y8zfTCC8g7=T0HQp3G3N_iECudo1gduYpy-A@mail.gmail.com>
In-Reply-To: <CABb+yY3Y8oZYG1y8zfTCC8g7=T0HQp3G3N_iECudo1gduYpy-A@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 18 Apr 2023 14:05:58 -0500
Message-ID: <CAL_Jsq+Oxj4ZDMyS_jOXiZEL2p=mYGr4MOGxiLen1ThRVE5cMw@mail.gmail.com>
Subject: Re: [PATCH] mailbox: Use of_property_read_bool() for boolean properties
To:     Jassi Brar <jassisinghbrar@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 18, 2023 at 11:36=E2=80=AFAM Jassi Brar <jassisinghbrar@gmail.c=
om> wrote:
>
> On Tue, Apr 18, 2023 at 11:25=E2=80=AFAM Rob Herring <robh@kernel.org> wr=
ote:
> >
> > On Fri, Mar 10, 2023 at 08:47:10AM -0600, Rob Herring wrote:
> > > It is preferred to use typed property access functions (i.e.
> > > of_property_read_<type> functions) rather than low-level
> > > of_get_property/of_find_property functions for reading properties.
> > > Convert reading boolean properties to to of_property_read_bool().
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > >  drivers/mailbox/hi6220-mailbox.c | 5 +----
> > >  drivers/mailbox/omap-mailbox.c   | 3 +--
> > >  2 files changed, 2 insertions(+), 6 deletions(-)
> >
> > Ping!
> >
> Pong :)
>
> I don't usually reply back that it looks good and will pick for the
> merge window. I just do that. So yes, it is not overlooked.

Okay. No reply nor applying it in over a month is not a great
experience for submitters.

Rob