Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5843882rwe; Tue, 18 Apr 2023 12:24:18 -0700 (PDT) X-Google-Smtp-Source: AKy350aknrNhRJ06VqSWGRzYzG9aKtz7i//ugWjQ2bZOCh2R+NAlfEeAno6Yb0lMz9qC8/X4jNDz X-Received: by 2002:a17:90a:e54d:b0:246:5787:6f5d with SMTP id ei13-20020a17090ae54d00b0024657876f5dmr784953pjb.10.1681845858434; Tue, 18 Apr 2023 12:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681845858; cv=none; d=google.com; s=arc-20160816; b=eWaNnCoXnGu9ALNt8fLppvD+Nm/QqfRX2BSl9gJ0xyOfKyfUTeeyJ+4IENBlOjD2Rx kcEJIHqh2VgtJapNOCxD2NgfJ6xqX98E/tq+OBEUhFSSslrg/rqf7RGb2/0bboMSP552 FoWQQFz+EoNMHoZGQgD1IkIFjleggTOJLxlBcMFP7NFwLoDpJuK0rF1aKeY8OlBX5dLm u6L/obH5iO/Obn6rO5ZN9+YaSQ6HvtTRPFfZtwTZeJn1NpOXeVDrnFdn3Cm//GPBUa2o i0JimDaBZKtRdXOUizTxaF5/nlZCkMYEea3MyyUJurZYzqlJ0eb87IxZDUKAz6KbdLuk zIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=MVAYFkU4mZduYsk7XhlvO4PjGSkxPXxfIXo1XXy+AEs=; b=0bgIJRftDYwchMWW/bW803MQxT3U23icHRw8m+tHsgJnMjG6UWDUm96T/c1PzSR4GP f8NI3cG8jrW0VZHXSMeXA/nLB44rLNuVIhUMrctQ2/hPXKysKlR8gFD7/BPrXOfd9Dhu LP5ZV/SGVIOvLTSk1vVkvQevE13tTMukMO7u6+hBhbxVkvFC9feUmwK2YebACZ/Hf/gW TB3gevF6xerpOSGvdsL6yQucbe0khLh7MUs1VYwawChhTLUTHDTlHQJq6lWZ/K8+U0Sf xvjzAucsPkuaAwEZK6JrLsRJF8+qJuBGjyfbbJhUQsxUpJZMr4gLPkEav+GX3qvHB1nk Y8fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=VHSLJh7a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a631514000000b00502f4be647fsi14235247pgl.641.2023.04.18.12.24.05; Tue, 18 Apr 2023 12:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=VHSLJh7a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231492AbjDRTWh (ORCPT + 99 others); Tue, 18 Apr 2023 15:22:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232431AbjDRTW1 (ORCPT ); Tue, 18 Apr 2023 15:22:27 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCDDB1721; Tue, 18 Apr 2023 12:22:25 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id fw30so23188114ejc.5; Tue, 18 Apr 2023 12:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681845744; x=1684437744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MVAYFkU4mZduYsk7XhlvO4PjGSkxPXxfIXo1XXy+AEs=; b=VHSLJh7a0+mKe8SJNR4lwJZ0ByLipyZYp6jzwW0N879wOMzn9Tn0xL/cbZMxu+DSV5 4ZF/OeV7jpVoTkqQNSRHhdQYDDswnLXGcgX7/vqMsTosqbF6RETV7WUjoq8M5LbsZKm+ ChbTa16747d2uH6di9ad2XsnFy87gzxUEHQ4wDWQHbx3bssEPWh+W2LPRfY+jpnn6NXz rtnw62vhRqFklBkDZ6JS34otGmzZn/zJ7Rva0SWp/79WuCPEYWI7ZD9Wqv9UPwgadeoO Mklj2jOVUkshn1TX4W1mYOgdM6ZR0ra5MR7nkISGaJlwU7CW9YNYNtyu37tZahbdM6Ir gJEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681845744; x=1684437744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MVAYFkU4mZduYsk7XhlvO4PjGSkxPXxfIXo1XXy+AEs=; b=ixRnIVnGrlhWrz2kXPoznvqM6MLlZm1/ov8MQo8D/Dl8Av8s4cnoGJmeogpo7gM6NV PhGWCgNGS0z+kJYdnlKybhsow5bsrn9b4cClYrgBASTphVXCYLf7pqKz6K3QE2VDWnBk 6uZo6D7CHCXWZmxtw0lVBhbfZIWBDgocRaXezGPaBkH5k3/lb86oqqrUaoYCrMVG8y0z Qvhb9pAfrvwARMtyiwSNBguBCjHdF5toodqAJkuXdXn18y3e/3wmFiaxs37AX43/Mlpk /U/yUj6UGvSI8Hj9Vf/OOvRmK58MY6L7TmoR01e5uvzzJ8WNMIP9S5PvpgrJtnfBWzsW x4/g== X-Gm-Message-State: AAQBX9cV5hmfCBakEX1+Etc/c/vtkBwzmYBnbd57R8y250VfM91jIWLV mmSfwOA1MHGbWxLJq1+1ve9Rl23FXeaB/PM7AUFlSePHcPI= X-Received: by 2002:a17:906:4a82:b0:94f:cee:56f2 with SMTP id x2-20020a1709064a8200b0094f0cee56f2mr11285413eju.4.1681845744201; Tue, 18 Apr 2023 12:22:24 -0700 (PDT) MIME-Version: 1.0 References: <20230310144710.1543139-1-robh@kernel.org> <20230418162500.GC1764573-robh@kernel.org> In-Reply-To: From: Jassi Brar Date: Tue, 18 Apr 2023 14:22:12 -0500 Message-ID: Subject: Re: [PATCH] mailbox: Use of_property_read_bool() for boolean properties To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 2:06=E2=80=AFPM Rob Herring wrote= : > > On Tue, Apr 18, 2023 at 11:36=E2=80=AFAM Jassi Brar wrote: > > > > On Tue, Apr 18, 2023 at 11:25=E2=80=AFAM Rob Herring = wrote: > > > > > > On Fri, Mar 10, 2023 at 08:47:10AM -0600, Rob Herring wrote: > > > > It is preferred to use typed property access functions (i.e. > > > > of_property_read_ functions) rather than low-level > > > > of_get_property/of_find_property functions for reading properties. > > > > Convert reading boolean properties to to of_property_read_bool(). > > > > > > > > Signed-off-by: Rob Herring > > > > --- > > > > drivers/mailbox/hi6220-mailbox.c | 5 +---- > > > > drivers/mailbox/omap-mailbox.c | 3 +-- > > > > 2 files changed, 2 insertions(+), 6 deletions(-) > > > > > > Ping! > > > > > Pong :) > > > > I don't usually reply back that it looks good and will pick for the > > merge window. I just do that. So yes, it is not overlooked. > > Okay. No reply nor applying it in over a month is not a great > experience for submitters. > I sense that. I may be wrong, but I feel any form of ack from a maintainer demotivates others from looking critically at the submission. I have seen revisions asked after many weeks of submission. So my idea is to let a patch roast in public glare. Maybe I should reply after 2-3weeks. -j