Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5844013rwe; Tue, 18 Apr 2023 12:24:27 -0700 (PDT) X-Google-Smtp-Source: AKy350Y8QANTIPxKyps8TwQq+sv1IL8acSgTdOERXcCCuSMXE9inFYEdOJklwlW6PyvEE/XjMyXJ X-Received: by 2002:a05:6a20:7d9b:b0:eb:e22b:efa6 with SMTP id v27-20020a056a207d9b00b000ebe22befa6mr704243pzj.51.1681845866727; Tue, 18 Apr 2023 12:24:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681845866; cv=none; d=google.com; s=arc-20160816; b=wlzEjxvT/g8TNIvFlMd+dVN//BAWuhxFIpLkqVxVWlEFoHImpgYDFbTjepBAsctvje h32KV8j+5Gy9z6K0A/QJk1BRGnB5fO/fQMH5M98w6VigUWhrfrGcMXcBzmoPKTs++6pH IJJc1bwEUS1HOiXFg1dMVIqeqhY4Ce8jWsTP0PDWq8LUAyC1vd0sPQrPmjsDNLkjW7Vo ddW81oog7NNZ0s2SvbPruC991Hp+SCVK7L7jIwV1s2LHvD5qRP861s2uHBIK9uQcK9PB unZ8yLfbvd2p0HKBvCvfx6/OJksgivvwYrA0YcRDpX3Kvy59sO7s/uMycdf55+YlRD2n ugYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aai1WHo4fg1sxKcLX3kD4BGAw1PP+pR+m3nWfdfcZTU=; b=W8m407twH+7JvrmZUP6GXyBWkG/gv/6Sd4binqlccG/gtez6xJ5KfaBDrN4iOrWYJQ sSmRNy1jQ/VqdDYCws8ybWkxE2N9KWdIvVauanDaJikDOd+bNzmZAzlKUGPGMkwswq7f gomJCvRfOAPkGNhl5E3hQ76hYBtDpKkHbNnIXFSrQ4bBO8UVhBARQw+CM6icF4TQZPUU Gp+U5JU7ekI89NeL2eNScRDz7z5CjHanQbEjmgo+NzSZ0I4xGLF8zY9MMtv4QireTxmG 2T4+2kcN86uThFVvyMwxDSQ3sM3Gt5bWJy10OqERuRtLdq0HNjCfBb/5lAx4zkpyO60U +N8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IMwuRS40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x4-20020a636304000000b0051b856ffbc2si9768597pgb.871.2023.04.18.12.24.13; Tue, 18 Apr 2023 12:24:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IMwuRS40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230417AbjDRTWf (ORCPT + 99 others); Tue, 18 Apr 2023 15:22:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231910AbjDRTWP (ORCPT ); Tue, 18 Apr 2023 15:22:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9784C6E8E for ; Tue, 18 Apr 2023 12:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681845655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aai1WHo4fg1sxKcLX3kD4BGAw1PP+pR+m3nWfdfcZTU=; b=IMwuRS40DczLIM+KnKHkEzEMNf3N2WP7SWT89gE9LH4TkZ68SyB3Jf8nTXSfYhKWV/JlpG +DpwaJA2Iz5gp4qL7LJ/FNDwOCdgzmD+xBEAms4pVAxdwt10TwOOjwTp/8LzR0XFU8XLrb erSFX51A7rmNbw9DG5sRWuAoBPSiNTQ= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-2-WgsqY8PMun0uX8Ye7KGg-1; Tue, 18 Apr 2023 15:20:54 -0400 X-MC-Unique: 2-WgsqY8PMun0uX8Ye7KGg-1 Received: by mail-qt1-f200.google.com with SMTP id 13-20020ac8590d000000b003eaf7aca024so9377252qty.22 for ; Tue, 18 Apr 2023 12:20:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681845654; x=1684437654; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aai1WHo4fg1sxKcLX3kD4BGAw1PP+pR+m3nWfdfcZTU=; b=bnY13i+WQqnoj9We3VcaRXiTF0ZN7yiXU4x6ZClA1siBvrIwoBFiCDXGjM7rwhkpqX 8km5TZynEGH8xei7xeGrXEuYetuKpIHGJwzXKNKjcL6+qUin4Hj+mIgFt5qh5Tzrpppx 6SGUDy7+iwOBeRZlqUlSPkx/duL13/31sXQHvfyYGTQsIoYzDPAoNvp/Z4xztidZoH5P ZsLjvWzgJn6pMoAJJPPibEZ7FpJ3R8dJ+/GoeYKVxQRdiUynaOG2tGKiu/kNogOpBy8k vEq+cy8fh/8nG9RoKpywjanyGP7YgQZuhkmTFk5Id3r1AWYREykAzRZK+UrnQQa7Gazx qNDQ== X-Gm-Message-State: AAQBX9e4K3KFO5vpSAa8CIdMhzXnx+/ToVbG33hn3JQNbe0iE1r0EWJc POh2lolCvp0YJwKPpIYi6QnJEY+zYtj/DeTIBPZhhtaLTkgQra5G/yE3/Unm38VKgbPEcwEC8ZY gnxEdaSQ5EVpbEOsMydcKq1QL X-Received: by 2002:a05:6214:410:b0:56c:13cc:d21f with SMTP id z16-20020a056214041000b0056c13ccd21fmr25855301qvx.50.1681845654141; Tue, 18 Apr 2023 12:20:54 -0700 (PDT) X-Received: by 2002:a05:6214:410:b0:56c:13cc:d21f with SMTP id z16-20020a056214041000b0056c13ccd21fmr25855272qvx.50.1681845653894; Tue, 18 Apr 2023 12:20:53 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id 7-20020a370c07000000b0074df3f7e14esm1709609qkm.67.2023.04.18.12.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 12:20:53 -0700 (PDT) From: Tom Rix To: quic_jhugo@quicinc.com, ogabbay@kernel.org, nathan@kernel.org, ndesaulniers@google.com, jacek.lawrynowicz@linux.intel.com, quic_carlv@quicinc.com, stanislaw.gruszka@linux.intel.com, quic_pkanojiy@quicinc.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] accel/qaic: initialize ret variable to 0 Date: Tue, 18 Apr 2023 15:20:46 -0400 Message-Id: <20230418192046.3235870-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang static analysis reports drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~~~~~~~~~ The ret variable is only set some of the time but is always returned. So initialize ret to 0. Fixes: ff13be830333 ("accel/qaic: Add datapath") Signed-off-by: Tom Rix --- drivers/accel/qaic/qaic_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c index c0a574cd1b35..b46a16fb3080 100644 --- a/drivers/accel/qaic/qaic_data.c +++ b/drivers/accel/qaic/qaic_data.c @@ -591,7 +591,7 @@ static int qaic_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struc struct qaic_bo *bo = to_qaic_bo(obj); unsigned long offset = 0; struct scatterlist *sg; - int ret; + int ret = 0; if (obj->import_attach) return -EINVAL; -- 2.27.0