Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp5967433rwe; Tue, 18 Apr 2023 14:34:03 -0700 (PDT) X-Google-Smtp-Source: AKy350Z4j/Fs0+ROP/UzSQI9XcT2TRep+GFn9Xp8HApbiCSmrclYvSxK6a1veZhSPed23qbiEpRX X-Received: by 2002:a17:90a:578f:b0:247:8b5f:59ce with SMTP id g15-20020a17090a578f00b002478b5f59cemr882495pji.20.1681853642741; Tue, 18 Apr 2023 14:34:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681853642; cv=none; d=google.com; s=arc-20160816; b=jznn6PPrHEuRELnJX61gUgM7tzh6KV4OU1APLR6/DP864faHIjEEeaYvfRwJmte4Gv BWrKs7/YQ5sN7K8cYz/vtxzzMclgAgwB3qvA0dv3xevAtwRqZ1xCD08JCnJWliEOk2GE GO6Oym6x+PjRdh/05BAwKuaMeSXT9E5UkeWWtn+07U5C8rsLYMivWp3j7BSZ5xPcXqMl mbnhe7IBkvb+iigCRD7WF5Cb2cdD2HKg2kfzz1wIRT4Wu1nU5Kq11doS169WHt6XXsJO MDE4irs5+Eu4fU1zFhUxC8Rr9XQdMO26C0NBw6IkfqZBH4iRUIgu23UG2VWaQaahJbRD Zksg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Bd0v93pTMpJnE+XmfBtuffRsA9igPcz4qeTPqwb8CFk=; b=ECLHXTbuA73uc22J2JiipN8phDihSwW5a+Hj14U8Flc2XU3KTc/ThyBwvsjccnkwCi SRA88npYVUZj0cTxhZl1oS2nYllC0+OF7q/dj4p2E+gBk0OyfWjRaRFV8IVBRLAq0Tct HY2xoYLpXq/pAlGm5xNKvGzuMbccMSBoRnIsr8yLuu4/d5sA4XKX2UOVBtuF7Nb3HVRM n3IvqkS2wce8WhtA/Jo+45K8Sshlr2h+8G3SM7CO9io4jgj/CrDE1I2YuILTE0y9FWu8 FTK6sPjPo+4eg5G8hajRyt21mfyl5/JuynFn2DBbaIfummRp+RvpDzQ6THqEF3Pk+YMv lvLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=TDvWQVGe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob12-20020a17090b390c00b002468f910624si70048pjb.116.2023.04.18.14.33.50; Tue, 18 Apr 2023 14:34:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=TDvWQVGe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232989AbjDRVaK (ORCPT + 99 others); Tue, 18 Apr 2023 17:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232971AbjDRVaG (ORCPT ); Tue, 18 Apr 2023 17:30:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF829118CD for ; Tue, 18 Apr 2023 14:29:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D82B63943 for ; Tue, 18 Apr 2023 21:28:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 234BDC433EF; Tue, 18 Apr 2023 21:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681853324; bh=2SNZxN9hzt7Hcn612PhEVKLrSU4yAg5SPreBYxtfaP8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TDvWQVGeqhj3/mWi/MRa3z2d2YtdyfUdrfzN4bDApR8Tccgr04pUJspvHZgMWe2sH KAVTt5BWR0pdykBB6joWO8tyUNmSIdqamNfJ5Hu2MwsWjSat5dIAPM4t4AitEminqe RzukRKpSuFilmu6UtJ5QUqZB4vOQeLzDzp70LC/8= Date: Tue, 18 Apr 2023 14:28:43 -0700 From: Andrew Morton To: Ivan Orlov Cc: Zach O'Keefe , Yang Shi , himadrispandya@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, syzbot+9578faa5475acb35fa50@syzkaller.appspotmail.com, Mike Kravetz , "Kirill A. Shutemov" , Matthew Wilcox Subject: Re: [PATCH v2] mm: khugepaged: Fix kernel BUG in hpage_collapse_scan_file Message-Id: <20230418142843.4ef62be30f529458344fa0e0@linux-foundation.org> In-Reply-To: <5dc97e10-8c64-4818-2642-dd8edb21c016@gmail.com> References: <20230330155305.423051-1-ivan.orlov0322@gmail.com> <20230331013301.ecgkjymaf3ws6rfb@google.com> <20230416113335.caeafda1328fdd4bfe2406e8@linux-foundation.org> <5dc97e10-8c64-4818-2642-dd8edb21c016@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Apr 2023 22:28:51 +0400 Ivan Orlov wrote: > Tested today on the latest rc7, the bug still exists. OK, thanks. I'll send this patch upstream during the next merge window. If you, Zach or someone else decides to remove SCAN_STORE_FAILED and perhaps those WARN_ON_ONCE()es then we can address these things later.