Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c33a2f01-b439-9533-79ee-76456eabf08d@intel.com>
Date:   Tue, 18 Apr 2023 14:53:23 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v5 3/3] Documentation/x86: Documentation for MON group
 move feature
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>, <fenghua.yu@intel.com>
CC:     <Babu.Moger@amd.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <eranian@google.com>,
        <gupasani@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <skodak@google.com>, <tglx@linutronix.de>, <tony.luck@intel.com>,
        <x86@kernel.org>
References: <20230330135558.1019658-1-peternewman@google.com>
 <20230330135558.1019658-4-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230330135558.1019658-4-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnBOZnpRdDJUYjNUMEFYVnBvMWFFOEhHSWpuMkd0WC9xZ1VHUFAzMURyeEha?=
 =?utf-8?B?NHp6T1hDYzZKMS92TzdoSjFGSjhTSDJMSHlUUmRubFZYTkZXZENTUG9MOCtV?=
 =?utf-8?B?RHNaZjdxOXJ2Y0Z1YVAwVmxpOTM4WWI0ZUI0U0gzZmRZK0VqZlZvbGZLMHk3?=
 =?utf-8?B?cjdNTHc1NFRhSXFYOWltTmhydVVWeWpCUFl2T0xYQjZuL1ZwallDNHlXVEZG?=
 =?utf-8?B?ajhsZjRud09OVDFIMlAyMEhnNTVLVUpNSm5vSkFlanlONWZOZGp1Z0MwQmxl?=
 =?utf-8?B?S1FWcDMwOUdiUzQrd2FwKytTMEoxVW1BMml0elI2Q09Gbi9jZHBHOWpObzkv?=
 =?utf-8?B?aitONXd2ZDBLMTJ2WHdaajc3VWlNNkd3Q3Vodk5ROWJtU0Z6OUgrejBYdWlI?=
 =?utf-8?B?YWlZZFdqKzlSM0VhV2pvNVZFR0h3blRCd2dGTmJpUm1LNEp4ckhDQzBOU3RU?=
 =?utf-8?B?V2VSMVV2ZXAxUytJZ3Y2c2VtaTJCWWNyaEN6a3pQSW1VV1lhRWZhb1E4U09U?=
 =?utf-8?B?ekZOWUhZbUoxZjlDdDZzRjMzY2pOTHYwQnRqU2dDSmhVWFhIRHBiak4vdUg0?=
 =?utf-8?B?Y3lORmJLUml6bHFVMVZBS1BxZTIzRi8xa3JNc3cyNHVKUWZEL2ZVQ01FNTd1?=
 =?utf-8?B?Qm9UcTRraWpNUG5KWjFpcUpZN0V6QzhMdmllLzZaU0xjMjBpb1RCWHI4dTRU?=
 =?utf-8?B?RnJNTDhIdW9lYXN6R3JtVzliRk1FU2FGM3V1aGxzSTZtbU16UmlOVkZtUmtz?=
 =?utf-8?B?dXRBNzVCcWZrZmJMNlgrdVF1cjJLWGhqTms2VGNJWGJYRWU5OWJzR05PRWdC?=
 =?utf-8?B?d2lkay9GUUwzRWJCblhnVHFqOWZyRldFV3JtTit4WmF4MkwzaUlTVFhIQWN4?=
 =?utf-8?B?emFPSFRpL0pTY0I1MkszTVR0OGNPK0sybThGbTd3MmhvNzRtSVhiYkRJejhQ?=
 =?utf-8?B?MFlWelErQlJXNkNiQ1p0T2I4anRpVmVSV1REbllVTXl0RHhIdG9SNzR0N3RW?=
 =?utf-8?B?bVB0c0RIcVoxSHpjOERyazdQWFgyY204Y0pVUHlWUDc5M0pxTm1KeTUxNGt5?=
 =?utf-8?B?MEtvRUlpYmVNNkNGdTlpVkluWXBoZENSd0Z2b3BPTWFzUEpvM3dMSXR6Y1J5?=
 =?utf-8?B?STFFZ1R2WUdPUkgwUGR0S3NRVEljTkJDdjBwbWRnWXJWSlUzMHBJV3RUZ05k?=
 =?utf-8?B?KzZ4b3BpL2ZYMlhYOFB2dmlzWEJTMlNEa3dmRzRzNFYrUDlzSllBZXhYMEhi?=
 =?utf-8?B?YU9HajFSR3V2SWUwazNJa1UxZnlhMzVIbkpLb1ZEeCtWQU5SMVhTSWhrbHUy?=
 =?utf-8?B?a29UR1ROK2dwVDcyOWpUZG5xZHhMTEVybzR3NTJhRTVyYlNLUGVqYWdxRXpJ?=
 =?utf-8?B?UmZwbjc0RnVOTmZZeUtTaWZ1UFdMeGg4UG0wUGtFVnpoaHk0MVhXQzc5aUFi?=
 =?utf-8?B?dzg1YW9BL1RlYVBFM1RZaDl3a1BTS014MkJGay9xZXlDWEpxTm16alpGY3NJ?=
 =?utf-8?B?SElqeERYUVNpTm81TFZNZW1jY1JuaWJSdk0rOW1ZTkIxL2FmUjJ0ZmVNWW9U?=
 =?utf-8?B?OUlSM0JCUHNzN3kzNjBWVzg1OHdZMWRzT2tvQXVyTkFldEloOHJuaGNBdmtO?=
 =?utf-8?B?dHhZMDNZSGU2L2dDdmsvTG9BcmZWbkN1bTRiYm12WDZ0K2hCUVlOQnRBVGYx?=
 =?utf-8?B?Z2p1akRtNWVDYTgyS0p5MVhQSUJiRzEyT0Fob0d1dWZLMTNNNlc3cm43WFJi?=
 =?utf-8?B?QWp3a282aFZzZzRyOUdIbm9tcjJDN0QrNjF1WFBTOXpQQVRNOENsMFdtdFFu?=
 =?utf-8?B?WjNrZlV1WW5YMks2MEZheGg4UklKalZFWTZpOEZPVmNxU2s4VlBQa29vNlBQ?=
 =?utf-8?B?UjFDWGRSWEo3RkdZSDJXK0k2bmg1emhqazNHMFVyRlZGWEpLbTN2UUxxQlRO?=
 =?utf-8?B?M3hiNDdyUXJaQkxPazhTc2ZmRzlFTlJMWFQ2UXF5czlobWZiUjlsZFExNXBJ?=
 =?utf-8?B?aVpFV1lTbjZVTGdYVXdrU3lJd2JwbDlRYzV5WEYrTVFsaDcrWVlMbUY2Nldn?=
 =?utf-8?B?TXBLUWw5dXFld3lrM1pwS2x1MktsV21oS3k5YUdQellxVXlGcFUvZWhzY1d3?=
 =?utf-8?B?bXFLV1psakw3OXlCWmtDWXBsSGRlWmd5TjFpUWg2cUJMVnA1cjN3YUJUTlZC?=
 =?utf-8?B?eGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4849e34b-897f-4fc5-4274-08db40575651
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 21:53:26.0540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6VcgPIHfElKWt3+tOXDkM/Om4kFJBt1a/iI2hEVblpLmGEzIHntoFIaPoM/nC+VyBKPdTs+14gnqgtSg+YDoVgrTN7E8FDnHd5vXoI81EYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4742
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 3/30/2023 6:55 AM, Peter Newman wrote:
> Describe new support for moving MON groups to a new parent CTRL_MON
> group and its restrictions.
> 
> Signed-off-by: Peter Newman <peternewman@google.com>
> ---
>  Documentation/x86/resctrl.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
> index 387ccbcb558f..cb05d90111b4 100644
> --- a/Documentation/x86/resctrl.rst
> +++ b/Documentation/x86/resctrl.rst
> @@ -287,6 +287,13 @@ Removing a directory will move all tasks and cpus owned by the group it
>  represents to the parent. Removing one of the created CTRL_MON groups
>  will automatically remove all MON groups below it.
>  
> +Moving MON group directories to a new parent CTRL_MON group is supported
> +for the purpose of changing the resource allocations of a MON group
> +without impacting its monitoring data or assigned tasks. This operation
> +is not allowed for MON groups which monitor CPUs. No other move
> +operation is currently allowed other than simply renaming a CTRL_MON or
> +MON group.
> +
>  All groups contain the following files:
>  
>  "tasks":

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette