Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 15:52:15 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Gencen Gan <gangecen@hust.edu.cn>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: amd: Fix link leak when verifying config failed
Message-ID: <20230418155215.24e7e140@kernel.org>
In-Reply-To: <20230417144750.3976715-1-gangecen@hust.edu.cn>
References: <20230417144750.3976715-1-gangecen@hust.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 17 Apr 2023 22:47:50 +0800 Gencen Gan wrote:
> From: Gecen Gan <gangecen@hust.edu.cn>
> 
> After failing to verify configuration, it returns directly without 
> releasing link, which may cause memory leak.
> 
> Signed-off-by: Gecen Gan <gangecen@hust.edu.cn>
> ---
>  drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
> index 823a329a921f..0dd391c84c13 100644
> --- a/drivers/net/ethernet/amd/nmclan_cs.c
> +++ b/drivers/net/ethernet/amd/nmclan_cs.c
> @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
>   } else {
>       pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
>  	  sig[0], sig[1]);
> -     return -ENODEV;
> +     goto failed;
>     }
>   }

The patch looks whitespace-damaged, it doesn't apply cleanly.
AFAICT there is one space missing in the indentation.
Probably your email server is doing something funny to it.

--
pw-bot: cr