Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp15405rwe; Tue, 18 Apr 2023 16:42:04 -0700 (PDT) X-Google-Smtp-Source: AKy350bi06S7tjcUceIJf6vG3kXsc1v0dNrAOhu+whNmwj4+wYqB+QhL4lM+25p4h6i91ZRyGyEe X-Received: by 2002:a05:6a20:6a1b:b0:ef:fe43:4ca1 with SMTP id p27-20020a056a206a1b00b000effe434ca1mr1381692pzk.49.1681861324413; Tue, 18 Apr 2023 16:42:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681861324; cv=none; d=google.com; s=arc-20160816; b=Y4wQygfR8sEYSVOxld6S72zOWxSsiQO736gxSlLiA//b9twtUf3GMYKbSNWgAAKysa CmJp3jjXHgqRPud601ztOTMVaaPlby1k2XPMqzKop3AO8iUxuALKpxEDYc1JtJSOXg5N 7dM/lcgvogSiM19VA4YUuacQHkoLQBYI76cv/RunxgAsD0Z4217YYpuoKi0eqlpmgiz1 7+7rvPSC8fydTwV/p/tbWkByYVx6V8uIHGwLdo2jvK0aj4A82HLJDe9LTudoX+wnBtT3 CUxDMgMu2hGR6ONuM77xDjcjUzD2dID8RMbHmVCCpONpFvVCO8+NjO4iflQ4vnKOKE1J yjIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=k5Bn3juE3fDshVkllxAzqw/tWdNFN8bQYVRW3fhsVrE=; b=E/n6uwcB1qACe2m6iBrJseudYxgXYWk8W9x/WkDxzjxB7vo+owUat5qlu/Fo9AZhcT Du/NwnKqQabPPGlWztmga2EHz33ikxmRHUUl/IofdxsAwTkXtIrZQrMzdaVVXWwCYaeM U7CpuF6sWLnRWiFCyBP1+8pY489I2cWbHq8HNfbPwzR2MpRTMm3arihDwoTjqZdutOu7 i6ZVXLAlObupFc7oAjuN7JSxGRrBzOW9lGEuzm12nq6H0jfOLrWA0dew5SfcgO0HEtnR 8+40BxFzDAvxCqQwoES68W/KJMRS40ehvsgQbCQr+lNzKurPRQRYeZq846a3qrkK+mHq +ybQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Pl3So5w/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a63fa0b000000b00502d81ecf19si14690795pgh.646.2023.04.18.16.41.50; Tue, 18 Apr 2023 16:42:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Pl3So5w/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbjDRXlZ (ORCPT + 99 others); Tue, 18 Apr 2023 19:41:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231223AbjDRXlG (ORCPT ); Tue, 18 Apr 2023 19:41:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B797513FAF for ; Tue, 18 Apr 2023 16:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681861092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k5Bn3juE3fDshVkllxAzqw/tWdNFN8bQYVRW3fhsVrE=; b=Pl3So5w/l3jw5+YK1DOheSihKpYRsMguR7QtyyL2UrZWMfZWgW1euykZlhrb3DJpjjQpGJ W6oJTswNZvdVa1V9CPE7veWDQaA3ueyU/p4aNFetW5/xT5t92tGg0ixEjA4Ps7xJFVFEOI 3PXtvBNMxDQblYW/qzKLqTQXDaw6H4s= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-Y-UfINMINFOJPfmCztTQog-1; Tue, 18 Apr 2023 19:38:10 -0400 X-MC-Unique: Y-UfINMINFOJPfmCztTQog-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-3ef2cb3bfbfso7795761cf.0 for ; Tue, 18 Apr 2023 16:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681861090; x=1684453090; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k5Bn3juE3fDshVkllxAzqw/tWdNFN8bQYVRW3fhsVrE=; b=Cm4xMa62zcMFJDQ6V1dkT2oKnTpy98D2nYJyBsm/IvwVb9DBptRPNpvuCkV5JR0XTk p5QHSDKRvw7t10QGmAvy4aDaADJPFE0xtBAAHsqKIP1yQ9ZtKuIRrTshmY3UV3eVA9Jv Zld/Fk8Pnw+DMNoFShS5Q0v2nNF4WJnA0kLR25khLTL8IwRCkS8m+ndNSlQoPyX++TK6 P1rAxI4Zgtv8HYeM33qya5uOCz5QnUK3Sml8C6JMO8AJynTjGUEa9iqwRUKAE3RWiBSA 7Xs7lnQ73qw42KT86yBkeXWph2W/Xfa/lM0mzOhvBaElDrUtwgPLEGJIKEHgKy+OwVnJ RFpA== X-Gm-Message-State: AAQBX9ct01bAR3fc4MANdGcrm+p8TKK+z61Cadc4xjN+XQnGL4U/15m5 CI0DYUOn2gNwio4iUrwv+IvA0MLYSK1/nEUUAU09PhLpEhigx8yz+HlY5KvjOwVcIti5Qzgnk56 acCHP4j8ssf9Sg4sxYd2HAx5e X-Received: by 2002:ac8:5a84:0:b0:3ef:1642:c123 with SMTP id c4-20020ac85a84000000b003ef1642c123mr14027846qtc.3.1681861090246; Tue, 18 Apr 2023 16:38:10 -0700 (PDT) X-Received: by 2002:ac8:5a84:0:b0:3ef:1642:c123 with SMTP id c4-20020ac85a84000000b003ef1642c123mr14027812qtc.3.1681861089946; Tue, 18 Apr 2023 16:38:09 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id de39-20020a05620a372700b0074ad4cc603dsm970121qkb.131.2023.04.18.16.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 16:38:09 -0700 (PDT) Date: Tue, 18 Apr 2023 19:38:07 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: Matthew Wilcox , akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 1/1] mm: do not increment pgfault stats when page fault handler retries Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 03:58:26PM -0700, Suren Baghdasaryan wrote: > Sure. How about replacing my prior "Register both successful and > failed faults in PGFAULT counters." comment with "To preserve the > behavior of older kernels, PGFAULT counters record both successful and > failed faults, as opposed to perf counters which ignore failed cases" Looks good here, thanks! -- Peter Xu