Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 19:20:55 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Fei Shao <fshao@chromium.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Douglas Anderson <dianders@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: goodix: Add powered-in-suspend
 property
Message-ID: <ZD8z57MBvcfExJx8@nixie71>
References: <20230418124953.3170028-1-fshao@chromium.org>
 <20230418124953.3170028-2-fshao@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230418124953.3170028-2-fshao@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VcMCqy5sCQ4cgECxVnI6jdi0Y8zjURklhLFHzqJoIWsXi/z/qDd5Rt4GazFO?=
 =?us-ascii?Q?bH0D5YLcqZf/23oorzzON537SBMVExFt/j13mbLP4VjQe/Mjj2u+Lnl6w+R+?=
 =?us-ascii?Q?0v+4DFPkZon4k9UeNADlHanolRqDf6lWi9oFK7Wok+Y8t8y7QKBT8ZF7aRZT?=
 =?us-ascii?Q?9bnsYe55i8Qa9hjbkYelDYDJBK9ga0p/+C1Lx0jOCF8Hg2kfrk1Od6uhyWxW?=
 =?us-ascii?Q?xiBXpiLcXSk3LY2suyvzzs4SIIVJd99SEHWMIy/vVFrnwM9nAVXJ0tYIn4Jv?=
 =?us-ascii?Q?ce7yOQUucl8dtgWpXg3iTr8Qf08PIY7ri7rwcp+oSCOhnqQQIXeqoxKvbQCW?=
 =?us-ascii?Q?+ftDtRpneUSbw3oEKF2oWrEJFH9XqFWVzkyr8uyv40dFJTHgOkmSa5KW/aR8?=
 =?us-ascii?Q?apleqilqAl6IcmKA0kdkgqANZqNqMvLfpn3htCUYrmsm3RTf3Mgj6WHUEQ9O?=
 =?us-ascii?Q?/pNIjIvfcvabFT9NoVpHoyyn45/7Pwo8nXHa8n9wajY9TegxY9DxHgSKuB92?=
 =?us-ascii?Q?CG3J1LRoyh5e0OkHdP6SJrqra5d3WxfjdnGKuol6Mdz3sBUv+D2Tf6ov0jx+?=
 =?us-ascii?Q?SShJhzGkeaYKI6w43mJu7tvut9k75+QI7egzsztirbNBl8/ohqhf28gndaP6?=
 =?us-ascii?Q?vSHDYSBsPl/GXxNB5s42C8U2d6oksirbrJWIW3WUhZao0lQR1EsxLS7H+hVP?=
 =?us-ascii?Q?jZ/rlqkhOw8SDrlxmC1dAJ0WTGSIys4nWQLVEDRyXRwiJXNv1/nl3C6W3HzX?=
 =?us-ascii?Q?H/QWymYTUmPl3a/g0DMOfqg3y1lJdeeSwpVniYq2DI3rG1waEmkYnPWqf7x3?=
 =?us-ascii?Q?CdxKeOkLdCKzxbqPRpx0Yh9BtkC0D05s7DhjXeroURkURjlGKQSfg1UhTuqP?=
 =?us-ascii?Q?n3mzsdt9hixLr7tytEo/XpxedXyF9HovAK1kWxuImMzgD/Wcv7pusMFk7cBF?=
 =?us-ascii?Q?PQQ8L7rwqcS4ndWVfBRfrRKDghAcpB6MsNsgXdLyeLVRSfpI6VfH8j0yi+aB?=
 =?us-ascii?Q?17Kdwit8F7ZWGAoM1XOG5TXQLiCBuvavFbLbXs5iL9Is9l+14UtzIRnJ+qwO?=
 =?us-ascii?Q?MXeaLwqY+jnTKmf/15zbQYqRnvNTe6ZRAXamPOoJh6r4TBsrSPC6AaJ/7+hK?=
 =?us-ascii?Q?S/+zT1IEEIJk6b2vwFF5IlR0e6uu7jd2XSZqmXsERQ+tLCqB3JlCcns9M5rj?=
 =?us-ascii?Q?f5MRtcUWIc0lYAec7bDc4nTshYL5uDSV4f/Ci87gpe3ZRpjwzDRDAd29L5JY?=
 =?us-ascii?Q?vn7ERJKaAZJA7KScAnZIHxhRPylhCjuxKm0LR6WJSyMbxWWroBRyvQ3QffX8?=
 =?us-ascii?Q?U41pUI6AE+k+t3DjxtUGDV6Z41L+Pyk0Wty6tix8y4xntbV4mkEM8CJOw9vf?=
 =?us-ascii?Q?N3vi30+1VRmNM9ODnlepZoUR4fHPKHipFNrKN0iZiYAjOH5W45KrsRmHbcRI?=
 =?us-ascii?Q?HRbqMpxr3O/XV/Xf0gY5cSESpFd556NmJGDMbhBuDj+h1MJUUUA+TBCxWQPR?=
 =?us-ascii?Q?OxSCLxyP/6Cy7J2G83zoggHEiA4KJgT/Lmi49tx7NPMzLouCWmIemWtXaPoQ?=
 =?us-ascii?Q?iir2PnXaD/aRi1lUextLrqfAoMD271nkDTF4Ek4Z?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99a990de-7de2-407b-ced1-08db406bf48e
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 00:21:02.1367
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IrTTaYfDA04YS3Y7lem3YQ0uQt1UubG/LdhZGno9ig15p/Y7H+idXSIsimXqQzJF54r8n/GJWuv0qHhD65ewhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR08MB7621
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fei,

On Tue, Apr 18, 2023 at 08:49:51PM +0800, Fei Shao wrote:
> We observed that on Chromebook device Steelix, if Goodix GT7375P
> touchscreen is powered in suspend (because, for example, it connects to
> an always-on regulator) and with the reset GPIO asserted, it will
> introduce about 14mW power leakage.
> 
> This property is used to indicate that the touchscreen is powered in
> suspend. If it's set, the driver will stop asserting the reset GPIO in
> power-down, and it will do it in power-up instead to ensure that the
> state is always reset after resuming.
> 
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---

This is an interesting problem; were you able to root-cause why the silicon
exhibits this behavior? Simply asserting reset should not cause it to draw
additional power, let alone 14 mW. This almost sounds like a back-powering
problem during suspend.

If this is truly expected behavior, is it sufficient to use the always_on
constraint of the relevant regulator(s) to make this decision as opposed to
introducing a new property?

> 
>  Documentation/devicetree/bindings/input/goodix,gt7375p.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> index ce18d7dadae2..942acb286d77 100644
> --- a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> @@ -43,6 +43,12 @@ properties:
>        itself as long as it allows the main board to make signals compatible
>        with what the touchscreen is expecting for its IO rails.
>  
> +  powered-in-suspend:
> +    description:
> +      This indicates that the touchscreen is powered in suspend, so the driver
> +      will not assert the reset GPIO in power-down to prevent power leakage.
> +    type: boolean
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.40.0.634.g4ca3ef3211-goog
> 

Kind regards,
Jeff LaBundy