Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b1fb3fc4-9051-2545-a273-c05b1f9b143e@gmail.com>
Date:   Wed, 19 Apr 2023 08:32:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v7 09/12] clk: nuvoton: Add clock driver for ma35d1 clock
 controller
Content-Language: en-US
To:     Stephen Boyd <sboyd@kernel.org>, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        lee@kernel.org, mturquette@baylibre.com, p.zabel@pengutronix.de,
        robh+dt@kernel.org
Cc:     devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        arnd@arndb.de, schung@nuvoton.com, mjchen@nuvoton.com,
        Jacky Huang <ychuang3@nuvoton.com>
References: <20230412053824.106-1-ychuang570808@gmail.com>
 <20230412053824.106-10-ychuang570808@gmail.com>
 <4f57a7ccc946d18be5eb9a47fa69e5f8.sboyd@kernel.org>
 <71f646cb-7114-0c78-493c-99bdb5217801@gmail.com>
 <f817937cfd494c3f619adda97ebd6346.sboyd@kernel.org>
From:   Jacky Huang <ychuang570808@gmail.com>
In-Reply-To: <f817937cfd494c3f619adda97ebd6346.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Dear Stephen,


On 2023/4/19 上午 04:23, Stephen Boyd wrote:
> Quoting Jacky Huang (2023-04-14 20:58:57)
>>>> diff --git a/drivers/clk/nuvoton/clk-ma35d1.h b/drivers/clk/nuvoton/clk-ma35d1.h
>>>> new file mode 100644
>>>> index 000000000000..28c60f081788
>>>> --- /dev/null
>>>> +++ b/drivers/clk/nuvoton/clk-ma35d1.h
>>>> @@ -0,0 +1,123 @@
>>>> +/* SPDX-License-Identifier: GPL-2.0-only */
>>>> +/*
>>>> + * Copyright (C) 2023 Nuvoton Technology Corp.
>>>> + * Author: Chi-Fang Li <cfli0@nuvoton.com>
>>>> + */
>>>> +
>>>> +#ifndef __DRV_CLK_NUVOTON_MA35D1_H
>>>> +#define __DRV_CLK_NUVOTON_MA35D1_H
>>> Is this header included in one C file? If so, remove the header file and
>>> put the contents in the C file.
>> Both clk-ma35d1.c and clk-ma35d1-pll.c include this header file.
>>
> Do they both use all the defines from it? Move as much as possible out
> of this header file and put them in the only C file that uses it.

Okay, I will try to eliminate the header file.


Best regards,
Jacky Huang