Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp191484rwe; Tue, 18 Apr 2023 20:25:05 -0700 (PDT) X-Google-Smtp-Source: AKy350bdUezoZidKiNmiUi2NfD+1hpDLcwzZfw3jrJAdTm5DEVOs3JgVZXq0blknx3xzsbv62JQa X-Received: by 2002:a05:6a00:134d:b0:63d:5cb7:2dff with SMTP id k13-20020a056a00134d00b0063d5cb72dffmr868350pfu.33.1681874705699; Tue, 18 Apr 2023 20:25:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681874705; cv=none; d=google.com; s=arc-20160816; b=jK9caDAWnNhaLYPpxm3syW3ecbQjmH2rX2IVO8GSgBgF+fWTmY6OnUFmlhAV8iwv2i SAUoU15iWF3u0e4H0mEE5pGvq0iybsE3J5KkPjYIIxZPn5P/9XkreslyphV0Pjz5DnCK hQmvwc1bHqKzBLuPhw4K/Zxc4EgCI02forfGUI8OOOxNF3EY+PYlxN6gbogRL2DMmrGq XoDNE4VEkm1w6l/X9F98CKfA3MgTbrRuu3RYWxWQZTn3QOxhgMkqjPk8q3RGay37oqyK kz/EFkrACprccDjJKlqyI8NIldOg+zEgV1n/YhjUZrKfFRjIYeWVgk5wAAwyei1CRlWg leUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sL7n544M2FFx8zOMKVb8XqVFksAtc7Bt0XJozZeFb8U=; b=iq/WpvnXYaZAUsSQ/Rqxbo83CJSrjw262+EnmlLkxhOG9ghAPxfjaAgSMT9mE5BcU9 x7+ASMAmP1qoxDv4sCIcIY3ktVzszPlYX5mumQRTHaLonhTELKf/5/4N6haeyeBfOWRG 4/pdcXIi6r0VtApBhmV9dETMoBBMUf4lW/uS3qK9Z0DbzI3b+Sqmbh5TE8Qko4zc5M+5 zu0ye+WEdXz3mi+lxlxWFy/tS04p57pE5g1o9pf+XprpzcfFYPA8q++bmwobjJ9Q6XeD TSQUDToOAtHmUb4b2H9OgfycEUr5NvKQZEqerzvS0FdIORFiEwXjAtnzhdmWVX6M+n6n lrdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=fLo+neFQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c188-20020a624ec5000000b0063b7b2669absi9835760pfb.130.2023.04.18.20.24.52; Tue, 18 Apr 2023 20:25:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=fLo+neFQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbjDSDU3 (ORCPT + 99 others); Tue, 18 Apr 2023 23:20:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbjDSDU1 (ORCPT ); Tue, 18 Apr 2023 23:20:27 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24D8110CF; Tue, 18 Apr 2023 20:20:26 -0700 (PDT) Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33ILqAPH031839; Wed, 19 Apr 2023 03:20:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-03-30; bh=sL7n544M2FFx8zOMKVb8XqVFksAtc7Bt0XJozZeFb8U=; b=fLo+neFQYgBy4L/+1t9vg9kyb/DRLnJKCpYq77PDGzXjUhWs82/MtnxVKtPriBxnnorj FFDmaDFpoP2He7jYEci7t56I0C5/FgHxoNE8d8R7PtvIjv2m0vPAMoMYlWe7yr3hquCC hsLvHtXdCTvuY/bOakpf6esBhwB5m3Gg8q4zmF/Z3OTLASOOMVBcZQa6SOxLxbvbH9oL vj9oDdQEvkkEGZC9ONicCiaWsw6cOfMG0vBng3Xp0XXj1b10St0kCCwE1DMJXs6uqlFX QORlRIqaYZXOm0fjHAV2BX7DIy5Zb9j4SKU6TaF+3SGVSdTrc+Pc5PdFJiBwaXFxiCH4 DQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pykycy92y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Apr 2023 03:20:24 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33J0LGWi037066; Wed, 19 Apr 2023 03:20:23 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pyjcccvv8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Apr 2023 03:20:23 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33J3KLpC012748; Wed, 19 Apr 2023 03:20:23 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3pyjcccvts-4; Wed, 19 Apr 2023 03:20:23 +0000 From: "Martin K. Petersen" To: Harshit Mogalapalli Cc: "Martin K . Petersen" , error27@gmail.com, kernel-janitors@vger.kernel.org, "James E.J. Bottomley" , John Garry , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] scsi: scsi_debug: Fix missing error code in scsi_debug_init() Date: Tue, 18 Apr 2023 23:20:13 -0400 Message-Id: <168187437337.702980.15149771115917556403.b4-ty@oracle.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com> References: <20230406074607.3637097-1-harshit.m.mogalapalli@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-18_17,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 bulkscore=0 mlxscore=0 mlxlogscore=801 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304190029 X-Proofpoint-GUID: MPrdhA1pkuzGGh3vAzFJGXTPAFJOc7Nl X-Proofpoint-ORIG-GUID: MPrdhA1pkuzGGh3vAzFJGXTPAFJOc7Nl X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Apr 2023 00:46:07 -0700, Harshit Mogalapalli wrote: > Smatch reports: drivers/scsi/scsi_debug.c:6996 > scsi_debug_init() warn: missing error code 'ret' > > Although it is unlikely that KMEM_CACHE might fail, but if > it does then ret might be zero. So to fix this explicitly > mark ret as "-ENOMEM" and then goto driver_unreg. > > [...] Applied to 6.4/scsi-queue, thanks! [1/1] scsi: scsi_debug: Fix missing error code in scsi_debug_init() https://git.kernel.org/mkp/scsi/c/b32283d75335 -- Martin K. Petersen Oracle Linux Engineering