Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f4a2c1b-4e37-a760-e6fd-2af285190a76@collabora.com>
Date:   Wed, 19 Apr 2023 06:11:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] Revert "media: mediatek: vcodec: Fix bitstream crop
 information error"
Content-Language: en-US
To:     =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     kernel@collabora.com, Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tiffany Lin <tiffany.lin@mediatek.com>,
        Yunfei Dong <yunfei.dong@mediatek.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20230418215052.2371755-1-nfraprado@collabora.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230418215052.2371755-1-nfraprado@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Il 18/04/23 23:50, Nícolas F. R. A. Prado ha scritto:
> This reverts commit cd61f3c6794bea2b717fe6083ca2ad189db75418. That
> commit's purpose was to prevent the padding from being decoded when
> userspace didn't set a selection, relying on the default one.
> 
> However, as described in the Step 6 of the Initialization procedure for
> the Memory-to-Memory Stateful Video Encoder Interface [1]:
> 
> "Set the visible resolution for the stream metadata via
> VIDIOC_S_SELECTION() on the OUTPUT queue if it is desired to be
> different than the full OUTPUT resolution."
> 
> And from the Note:
> 
> "To avoid encoding the padding, the client needs to explicitly configure
> this selection target"
> 
> Hence the behavior in the original commit doesn't follow the interface
> and needs to be reverted.
> 
> This fixes the following v4l2-compliance failure observed on
> mt8192-asurada-spherion:
> 
> 		fail: v4l2-test-formats.cpp(924): sel.r.width != fmt.g_width()
> 	test VIDIOC_S_FMT: FAIL
> 
> [1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/dev-encoder.html#initialization
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

On MT8192 Asurada Spherion and MT8195 Cherry Tomato:

Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>