Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760463AbXI1AV3 (ORCPT ); Thu, 27 Sep 2007 20:21:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759216AbXI1AVV (ORCPT ); Thu, 27 Sep 2007 20:21:21 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:49785 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756896AbXI1AVV (ORCPT ); Thu, 27 Sep 2007 20:21:21 -0400 From: akepner@sgi.com Date: Thu, 27 Sep 2007 17:20:19 -0700 To: Randy Dunlap Cc: Grant Grundler , Jesse Barnes , Jes Sorensen , David Miller , Roland Dreier , linux-kernel@vger.kernel.org, jejb Subject: Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface Message-ID: <20070928002019.GK30013@sgi.com> References: <20070926000057.GL30013@sgi.com> <20070925221333.bb722dc4.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070925221333.bb722dc4.randy.dunlap@oracle.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 813 Lines: 28 On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote: > On Tue, 25 Sep 2007 17:00:57 -0700 akepner@sgi.com wrote: > ...... > 1. Function signature should be on one line if possible (and it is). > Aw crud, I looked at dma-mapping.h and it uses this format sometimes. > Well, it's undesirable, so please don't propagate it. > > 2. No parens on return: it's not a function. > > static inline int dma_flags_set_dmaflush(int dir) > { > return dir; > } > > > Similar comments for patch 2/4: sn-ia64. > Both fixed in next version. Thanks, Randy. -- Arthur - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/