Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230417165246.467723-1-zyytlz.wz@163.com> <2023041756-scoop-splendor-0e01@gregkh>
In-Reply-To: <2023041756-scoop-splendor-0e01@gregkh>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Wed, 19 Apr 2023 13:29:15 +0800
Message-ID: <CAJedcCx_BxWyJFje+iwsJXoW0bngUD79cBuj+VSv08azDN1FjQ@mail.gmail.com>
Subject: Re: [PATCH] misc: hpilo: Fix use after free bug in ilo_remove due to
 race condition with ilo_open
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Zheng Wang <zyytlz.wz@163.com>, matt.hsiao@hpe.com, arnd@arndb.de,
        linux-kernel@vger.kernel.org, 1395428693sheep@gmail.com,
        alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Greg KH <gregkh@linuxfoundation.org> =E4=BA=8E2023=E5=B9=B44=E6=9C=8818=E6=
=97=A5=E5=91=A8=E4=BA=8C 01:43=E5=86=99=E9=81=93=EF=BC=9A
>
> On Tue, Apr 18, 2023 at 12:52:46AM +0800, Zheng Wang wrote:
> > --- a/drivers/misc/hpilo.h
> > +++ b/drivers/misc/hpilo.h
> > @@ -62,6 +62,7 @@ struct ilo_hwinfo {
> >       spinlock_t fifo_lock;
> >
> >       struct cdev cdev;
> > +     struct kref refcnt;
>
> You now have 2 different structures doing reference counting logic on
> the same structure.  That's just not ok at all, and is totally broken.
>

Thanks for your reply. I'll look into it and figure out effective fix.

Best regards,
Zheng

> greg k-h