Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230417013107.360888-1-zyytlz.wz@163.com> <20230418213340.153529d7@kernel.org>
In-Reply-To: <20230418213340.153529d7@kernel.org>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Wed, 19 Apr 2023 13:30:05 +0800
Message-ID: <CAJedcCx3B58NaBHYZ_xurKjp=7DjmMgHvSta2axCu5ToQObwMg@mail.gmail.com>
Subject: Re: [PATCH net v3] net: ethernet: fix use after free bug in
 ns83820_remove_one due to race condition
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Zheng Wang <zyytlz.wz@163.com>, davem@davemloft.net,
        horatiu.vultur@microchip.com, edumazet@google.com,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, 1395428693sheep@gmail.com,
        alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jakub Kicinski <kuba@kernel.org> =E4=BA=8E2023=E5=B9=B44=E6=9C=8819=E6=97=
=A5=E5=91=A8=E4=B8=89 12:33=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, 17 Apr 2023 09:31:07 +0800 Zheng Wang wrote:
> > +     netif_carrier_off(ndev);
> > +     netif_tx_disable(ndev);
> > +
> >       unregister_netdev(ndev
>
> It's not immediately obvious to me why disabling carrier and tx
> are supposed to help. Please elaborate in the commit message if
> you're confident that this is right.
>

Hi Jakub,

Thanks for your reply. I'll figure it out to see if it's really necessary.

Best regards,
Zheng

> --
> pw-bot: cr