Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760736AbXI1BTA (ORCPT ); Thu, 27 Sep 2007 21:19:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759216AbXI1BSw (ORCPT ); Thu, 27 Sep 2007 21:18:52 -0400 Received: from smtp.ustc.edu.cn ([202.38.64.16]:46409 "HELO ustc.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1757639AbXI1BSw (ORCPT ); Thu, 27 Sep 2007 21:18:52 -0400 Message-ID: <390942329.08474@ustc.edu.cn> X-EYOUMAIL-SMTPAUTH: wfg@mail.ustc.edu.cn Date: Fri, 28 Sep 2007 09:18:46 +0800 From: Fengguang Wu To: Rik van Riel Cc: Andrew Morton , Nick Piggin , OGAWA Hirofumi , Kumar Gala , Pete Zaitcev , Greg KH , Linux Kernel Subject: Re: [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout() Message-ID: <20070928011846.GA5496@mail.ustc.edu.cn> References: <390857819.00313@ustc.edu.cn> <20070927111610.68584fdd@bree.surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070927111610.68584fdd@bree.surriel.com> X-GPG-Fingerprint: 53D2 DDCE AB5C 8DC6 188B 1CB1 F766 DA34 8D8B 1C6D User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 23 On Thu, Sep 27, 2007 at 11:16:10AM -0400, Rik van Riel wrote: > On Thu, 27 Sep 2007 09:50:16 +0800 > Fengguang Wu wrote: > > > We don't want to introduce pointless delays in throttle_vm_writeout() > > when the writeback limits are not yet exceeded, do we? > > Good catch. Thank you. > > Signed-off-by: Fengguang Wu > > Reviewed-by: Rik van Riel It could be a good fix for 2.6.22/23. But for -mm, I'm not sure if throttle_vm_writeout() will be eventually removed ;-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/