Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230419072736.172593-2-haifeng.xu@shopee.com>
In-Reply-To: <20230419072736.172593-2-haifeng.xu@shopee.com>
From:   Miklos Szeredi <mszeredi@redhat.com>
Date:   Wed, 19 Apr 2023 10:05:23 +0200
Message-ID: <CAOssrKfCiByavRNekRUOCv==AEvWAO6B6=tAASyYdvWj9XRhBw@mail.gmail.com>
Subject: Re: [PATCH 2/2] vfs: clean up d_backing_inode() function
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     viro@zeniv.linux.org.uk, bigeasy@linutronix.de, mcgrof@kernel.org,
        xiubli@redhat.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

If we are touching that function, I'd just get rid of it completely
(s/d_backing_inode/d_inode/).

Thanks,
Miklos

On Wed, Apr 19, 2023 at 9:27=E2=80=AFAM Haifeng Xu <haifeng.xu@shopee.com> =
wrote:
>
> Using an extra variable to record the inode is unnecessary, return it
> directly.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---
>  include/linux/dcache.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/dcache.h b/include/linux/dcache.h
> index 13023c7211d6..97324b6434e5 100644
> --- a/include/linux/dcache.h
> +++ b/include/linux/dcache.h
> @@ -540,9 +540,7 @@ static inline struct inode *d_inode_rcu(const struct =
dentry *dentry)
>   */
>  static inline struct inode *d_backing_inode(const struct dentry *upper)
>  {
> -       struct inode *inode =3D upper->d_inode;
> -
> -       return inode;
> +       return upper->d_inode;
>  }
>
>  /**
> --
> 2.25.1
>