Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 09:10:19 +0100
From:   Matthias Maennich <maennich@google.com>
To:     Yifan Hong <elsk@google.com>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Daniel Mentz <danielmentz@google.com>, kernel-team@android.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kheaders: Follow symlinks to source files.
Message-ID: <ZD+h60QyBYEXnCHQ@google.com>
References: <20230419002946.2566272-1-elsk@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20230419002946.2566272-1-elsk@google.com>
Precedence: bulk

On Wed, Apr 19, 2023 at 12:29:36AM +0000, Android Kernel Team wrote:
>When the kernel is built inside a sandbox container,
>a forest of symlinks to the source files may be
>created in the container. In this case, the generated
>kheaders.tar.xz should follow these symlinks
>to access the source files, instead of packing
>the symlinks themselves.
>
>Signed-off-by: Yifan Hong <elsk@google.com>
>---
> kernel/gen_kheaders.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
>index 1ef9a87511f5..183d9a44aa39 100755
>--- a/kernel/gen_kheaders.sh
>+++ b/kernel/gen_kheaders.sh
>@@ -87,7 +87,7 @@ find $cpio_dir -type f -print0 |
> # pre-sorted, as --sort=name might not be available.
> find $cpio_dir -printf "./%P\n" | LC_ALL=C sort | \
>     tar "${KBUILD_BUILD_TIMESTAMP:+--mtime=$KBUILD_BUILD_TIMESTAMP}" \
>-    --owner=0 --group=0 --numeric-owner --no-recursion \
>+    --owner=0 --group=0 --numeric-owner --no-recursion -h \

I would have a preference for the long form --dereference as it is more
descriptive.

With that, feel free to add

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias


>     -I $XZ -cf $tarfile -C $cpio_dir/ -T - > /dev/null
>
> echo $headers_md5 > kernel/kheaders.md5
>-- 
>2.40.0.634.g4ca3ef3211-goog
>
>-- 
>To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>