Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b98ca138-c020-cfd0-510d-30916120734d@nxp.com>
Date:   Wed, 19 Apr 2023 11:21:44 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] ASoC: fsl_sai: Fix pins setting for i.MX8QM platform
To:     Chancel Liu <chancel.liu@nxp.com>, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, shengjiu.wang@gmail.com,
        Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com
References: <20230418094259.4150771-1-chancel.liu@nxp.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <20230418094259.4150771-1-chancel.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGFseG5ubmd6S0lmeXZ3anF1UUZQQmNta29UV0doZTBxazNoMy9ieXhxOUM5?=
 =?utf-8?B?YVpNK3ExT0l2VkRWYkVEdDdQRTlWdDFYdDBRdzJqa2crZ1BIWUpCZUJkdWFI?=
 =?utf-8?B?c2llemtxOTRaaEMwRytMQlVwRFJDcUpkQWpvZElxYURmQjhCNnVKWW9SUlZ5?=
 =?utf-8?B?bTR3ZkhYQWY3YisxMFZXd3hCWnFXY3lOT1gwMC9GbFpqelo0RXE3UzFGekxj?=
 =?utf-8?B?U0JYVXZDUjJUakVlZWJvNG9DTkVSbkJmTnQxakFXSTIyaitZS1F6cTJnYmNH?=
 =?utf-8?B?Rm11bmtkRERmb2JkY2xaRlRvRE4reFk1TmlTUjRqb0dJTWVHSnFZVGg0WHJR?=
 =?utf-8?B?SWdrQjNVZno2d1A1UVlCMzVoeG85MlFOTysxUnVWd3BRZjZ5Mlp1K2d5S2tj?=
 =?utf-8?B?MWVLaCt1cWcvYzBmYmNsNkZ3L2l4Ui9xazBxREJnSUR0dFBaenZ4eTlDUncx?=
 =?utf-8?B?dXJCdmFQTjRUVlRsem9JdDNRdzlYcmhod2VPMnpCcEZxdFRhRGpuQ281ZUN0?=
 =?utf-8?B?N1U2VVBpUCswNml3QW9KVTVBdERJNExNckM4Nk05Nkp6WithRGlGQ3JONE5R?=
 =?utf-8?B?MHdVQXVkeDVmcHZwNC9jNjBkbnBBZVdZVkI5bUowdFFaR2oyYlNXSUFHdmFS?=
 =?utf-8?B?R2dtVk81SmV1ZEd1bEdXaWVMTFhmeklSMnBBTjNOM2sxT2FRMWJWdFY3a2F5?=
 =?utf-8?B?eHNlVXlZck1pT3BsNEhBVFFaWHZJblNFSGhYWVZ3cGFhNS9uVzlORUpjL2li?=
 =?utf-8?B?QnhhZUp5RUF2Sk9oMldvczJkUG1WOWprTitxdDZGMzFsbzMzOUJ6cnpXbTcv?=
 =?utf-8?B?NzZTblVrK0FTa2ZoTnYvSFBEZzloNFZjSU1hN3F6YXRRcnRHYjJsSkxpRTJq?=
 =?utf-8?B?S041SVFMZTJuQWY3b1B1ZlZHcW8zbGV4NWNUbnQ4VG5ML2VkVkhxdXROaGJK?=
 =?utf-8?B?OWF0MFdVaEFmc3lVd0YxdDRxd0NPcEFqRnhxZllvM0QrSlgzclEzYXlMOFg0?=
 =?utf-8?B?aGVrbTNYM1dwbU9qaGdBQ1kzVnk5ZnV6Q1lNc3NHRjlyS0hKNlc1S1NGS0pK?=
 =?utf-8?B?UkxMd2owQzZxTkZxWkc2R2dtZytNcFlXbFdGVS9NaXdqZjFTcVNZQXJ3RWkv?=
 =?utf-8?B?RjZwZ2ZWWFVCWDZScTdzQ1Z3SlpWZk1BMmQzSzdQMzdvTXRDenZjQ0VGclBV?=
 =?utf-8?B?NGV0WUJYSmdqcE5jd0lBWkR1RGdJRGVDTkZUSWlXRkZRZWxiZW8xYnJZaWIv?=
 =?utf-8?B?OWorTlBjblFxY3AybjR6Y2FObzRnUnFXL3g2NmxweVRKZjBCUHB4WWZtdkRW?=
 =?utf-8?B?clpzQnNKZk1IcUQ3ZFdCOU9rMEY3WnRjWTNoVzN2a1N4RTNZa2o0UzdGampz?=
 =?utf-8?B?bExWaHFMejQ5ajdocTRVdmdPZEhUSis5WWl5cnYwSFR3Ym8rY1o2bUtiQU9N?=
 =?utf-8?B?eGhyanlDNlBuT3NNcmszWUVLMVhWSUFobVlmYkRaaUU3WFNTWFYvZmxIOTB2?=
 =?utf-8?B?NkZVMW96c0Q0RkY3elllczREcTJkak9KbWRYNXZRYi90ZUJNa1d3WmtrelFC?=
 =?utf-8?B?dS9VYUt1U3lscTE1a21IZ1YwVDlMdDBtKzFqMnd6N2VMTWhiUVB6S2d1MVBN?=
 =?utf-8?B?VGlIdVE4MDJEVzl3M25zU2pYbi9HSUlRWlc4OGZJZGhzNWlwcWZ4QmZBMGc4?=
 =?utf-8?B?eXYrUmpSeDlwMHpIWGQ3L1B0dy9UeHdJbDhuQzFIUXQrK2kzZklrdHgxaTB6?=
 =?utf-8?B?dHl5VmxmVGw0UTJZVDNRbW4xTXRLTE1pVk9DVk5KTVUxL25pQkZTMU1JM0VM?=
 =?utf-8?B?TFhxL3FrWjFoWjViV1AzZy8wQUFSZFpKSjZwTm9TZllRb2JyZkhubW92cGhT?=
 =?utf-8?B?WFhsbUpCZ3dvQ0Vzc0ZUVjEvc0dEOWRPRW5hMmxaUTd0NnlQZ2x6elVWdDFq?=
 =?utf-8?B?Qmk3bmZlR2oyWU5xNUlvaXJRS20vSE4yYTk4czZUbmFqaW5SQW83bEtRcVo5?=
 =?utf-8?B?NTMxZ1JkWVJWQVFyaDJYSUJ6QUFtK0FtNllWOVMxNGx5a05RUFY3R3F3aVlI?=
 =?utf-8?B?MjhUa0t0US9WV3U0Q3ZaeFNXV0F0K21xazhPUEx2cHY0QStUUEZGTnVlUzR3?=
 =?utf-8?B?L01wcE9jOGtzV0htWUd6OTFRTGRRanVaRGo1QWFESStpeHE4NkZJeUFuZFdW?=
 =?utf-8?B?bHc9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3134499d-58e0-4d92-7f60-08db40af1e53
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 08:21:47.6673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wzgx3Q1j2+SM5GPX4ErImQQZ8ngZKn24HgSfl0+TlC0/9ecRBVh2bIGNBwrRyogihL/zaxzRQuTYrtfTpThOog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8820
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/18/2023 12:42 PM, Chancel Liu wrote:
> SAI on i.MX8QM platform supports the data lines up to 4. So the pins
> setting should be corrected to 4.
>
> Fixes: eba0f0077519 ("ASoC: fsl_sai: Enable combine mode soft")
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia

>   sound/soc/fsl/fsl_sai.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 07d13dca852e..abdaffb00fbd 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1544,7 +1544,7 @@ static const struct fsl_sai_soc_data fsl_sai_imx8qm_data = {
>   	.use_imx_pcm = true,
>   	.use_edma = true,
>   	.fifo_depth = 64,
> -	.pins = 1,
> +	.pins = 4,
>   	.reg_offset = 0,
>   	.mclk0_is_mclk1 = false,
>   	.flags = 0,