Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CGME20230419094754epcas2p3901ad6f3171a2be1a144d957c2e0d8ad@epcas2p3.samsung.com>
 <20230419094838.136349-1-hy50.seo@samsung.com>
In-Reply-To: <20230419094838.136349-1-hy50.seo@samsung.com>
From:   Stanley Chu <chu.stanley@gmail.com>
Date:   Wed, 19 Apr 2023 18:32:56 +0800
Message-ID: <CAGaU9a-k9iDUNeT0s85o0GEeXSWsi98_QC+nK=jT9Yb1V=-SZA@mail.gmail.com>
Subject: Re: [PATCH v1] scsi: ufs: mcq: add 1 to the max Queues value
To:     SEO HOYOUNG <hy50.seo@samsung.com>
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, beanhuo@micron.com, bvanassche@acm.org,
        bhoon95.kim@samsung.com, kwmad.kim@samsung.com, sc.suh@samsung.com,
        quic_nguyenb@quicinc.com, Po-Wen Kao <powen.kao@mediatek.com>,
        peter.wang@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

SEO HOYOUNG <hy50.seo@samsung.com> =E6=96=BC 2023=E5=B9=B44=E6=9C=8819=E6=
=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:56=E5=AF=AB=E9=81=93=EF=BC=9A
>
> If read the MAXQ field value verbatim, can use a value
> that is one less than the supported Queue.
> So read the MAXQ field value and incremented it by one
>
> below is the specification
> Maximum number of Queues (MAXQ):
> Maximum number of Queues this controller can support.
> In this version of specification, maximum value is 31.
>
> NOTE To support 1:1 topology, the Host HW controller must support
> HW resources for MAXQ number of Completion Queues too.
> Host SW may use less number of completion queues for N:1 topology..:1 Que=
ue
> 0: 1 Queue
> 1: 2 Queues
> =E2=80=A6
> 31: 32 Queues
> 32-255 : reserved
>
> Signed-off-by: SEO HOYOUNG <hy50.seo@samsung.com>
> ---
>  drivers/ufs/core/ufs-mcq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index 31df052fbc41..a1ee3318c605 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -150,7 +150,7 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba=
 *hba)
>         u32 hba_maxq, rem, tot_queues;
>         struct Scsi_Host *host =3D hba->host;
>
> -       hba_maxq =3D FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities);
> +       hba_maxq =3D FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities) + 1;
>
>         tot_queues =3D UFS_MCQ_NUM_DEV_CMD_QUEUES + read_queues + poll_qu=
eues +
>                         rw_queues;
> --
> 2.26.0
>

This seems to be the same patch uploaded by Powen:
https://patchwork.kernel.org/project/linux-scsi/patch/20230307065448.15279-=
4-powen.kao@mediatek.com/