Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1681108984-2-1-git-send-email-lizhijian@fujitsu.com> <1681108984-2-2-git-send-email-lizhijian@fujitsu.com>
In-Reply-To: <1681108984-2-2-git-send-email-lizhijian@fujitsu.com>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Wed, 19 Apr 2023 12:37:31 +0200
Message-ID: <CAMGffEngGE=X3VYYcOg=mHhW+O71JUhwonrvY6YuugnxeoGeRg@mail.gmail.com>
Subject: Re: [PATCH for-next 1/3] RDMA/rtrs: Remove duplicate cq_num assignment
To:     Li Zhijian <lizhijian@fujitsu.com>
Cc:     haris.iqbal@ionos.com, jgg@ziepe.ca, leon@kernel.org,
        linux-rdma@vger.kernel.org, guoqing.jiang@linux.dev,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 10, 2023 at 8:43=E2=80=AFAM Li Zhijian <lizhijian@fujitsu.com> =
wrote:
>
> line 1701 and 1713 are duplicate:
> > 1701         cq_num =3D max_send_wr + max_recv_wr;
>  1702         /* alloc iu to recv new rkey reply when server reports flag=
s set */
>  1703         if (clt_path->flags & RTRS_MSG_NEW_RKEY_F || con->c.cid =3D=
=3D 0) {
>  1704                 con->rsp_ius =3D rtrs_iu_alloc(cq_num, sizeof(*rsp)=
,
>  1705                                               GFP_KERNEL,
>  1706                                               clt_path->s.dev->ib_d=
ev,
>  1707                                               DMA_FROM_DEVICE,
>  1708                                               rtrs_clt_rdma_done);
>  1709                 if (!con->rsp_ius)
>  1710                         return -ENOMEM;
>  1711                 con->queue_num =3D cq_num;
>  1712         }
> > 1713         cq_num =3D max_send_wr + max_recv_wr;
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Thx!
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/=
ulp/rtrs/rtrs-clt.c
> index 80abf45a197a..c2065fc33a56 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1710,7 +1710,6 @@ static int create_con_cq_qp(struct rtrs_clt_con *co=
n)
>                         return -ENOMEM;
>                 con->queue_num =3D cq_num;
>         }
> -       cq_num =3D max_send_wr + max_recv_wr;
>         cq_vector =3D con->cpu % clt_path->s.dev->ib_dev->num_comp_vector=
s;
>         if (con->c.cid >=3D clt_path->s.irq_con_num)
>                 err =3D rtrs_cq_qp_create(&clt_path->s, &con->c, max_send=
_sge,
> --
> 2.29.2
>