Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 13:03:46 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna <saikrishnag@marvell.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, leon@kernel.org,
        sgoutham@marvell.com, gakula@marvell.com, lcherian@marvell.com,
        jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com
Subject: Re: [net PATCH v3 10/10] octeontx2-pf: Disable packet I/O for
 graceful exit
Message-ID: <ZD/KklR3coHRY580@corigine.com>
References: <20230419062018.286136-1-saikrishnag@marvell.com>
 <20230419062018.286136-11-saikrishnag@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230419062018.286136-11-saikrishnag@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WM4eh3wlHTLR4c2emn8gsXNhRJ1EAxD6LQ6PaYdqoQQZrw3FWxXa5DO/78ZL?=
 =?us-ascii?Q?kSXgtptYfIfZ8qTtdLOPXX+WpmzdwwhgBY8gDaAeQQnfIHdFFTdlF5/r0BO4?=
 =?us-ascii?Q?ScV2ALmH3LSPO9r9XAtqOaM5g3ReTUF8Pcewi52qLjzT/TSGL0gNUUILhKFu?=
 =?us-ascii?Q?mtj9I4H28ifsbYBU5W1+IynTxPAaJifY0V4uQMPLouHS06aJT0NzJU88Wt4j?=
 =?us-ascii?Q?PXDoAvBFtwb/QBaLthO0+fuz3F1BwgXalPB5AlKx9CbfNyQqkZEmjGXhvJte?=
 =?us-ascii?Q?HYqP2A53+ZgiWC8tfwvs+Nf+Z+H5Tf6i0479AcaicLJKdhc/QbD6kyosq3gt?=
 =?us-ascii?Q?l3XWfaeUuKKMqYeHcYNw11xt1whwLSpsFdbEjl7ll6MM9TDRJHtcuheMtaeG?=
 =?us-ascii?Q?9COYy/046qnmDMF8xTmC0LyEc9oB+YrOedZL4Izdk+Vstft95AMF2yaK9ydr?=
 =?us-ascii?Q?wUZHXRJ4EuwvJMP4wMZg5i2v6xRKI5vggSYGrW/RKUxAsCjFon2rmhfceEiA?=
 =?us-ascii?Q?qMk/Aqba5mYpaZuSpuy+xQhTk9fc0c2XTXbaJO5SBs6irMfecX60xFMO9RuN?=
 =?us-ascii?Q?8q1om/BBT89wIKDooYb9QPAvaAwF7zVJz3BE9tMB8g+NZ4ZJlUfk8CTlLHcw?=
 =?us-ascii?Q?63UGqw0wqC+12suqhf+pR82qjb0M1FfEaJLAk077vPsAbB1BCARKKHUSLMrN?=
 =?us-ascii?Q?AA1ZN6iMp3I/h8oMfg8jNOuVVGjnIhJK+BfasWam55d8FrUYqTe/MJSxpH4g?=
 =?us-ascii?Q?oRC+M/gmDBgYMWyVUI+8vJ+lxaysZ87QckI2pu5pZ02U8bzDEBDbU4FwJ7ea?=
 =?us-ascii?Q?ht3MnOG3ySCHXjyiEVNXLi1Fj1XLf1cdUSGbUvCaKVqGa2aXSwM2JQFdn5X0?=
 =?us-ascii?Q?3rULTRA4jLUUQSDDBZU7GIjpZv8LSdCFHd+o8pO/PDtQ5j8eQ49KnFE3iyal?=
 =?us-ascii?Q?70i70BBaQfdKBktFoZ90shfA9dlzQ4p4Orxrp1Ls5aT8ZaIol8xhhtPBgENm?=
 =?us-ascii?Q?ikscZyXb17n/nmML+J4hXDxeQQ2Xw3VdND9jlNmDKvBR51yvd1i5D+uunDH5?=
 =?us-ascii?Q?a2dMiVsICa/BYIls9gQ52Ytq6mKFMRXpk0d/DDVSniGsAWj01ish0kbG5cpV?=
 =?us-ascii?Q?0Lyli2U2tVPLpjJVZA4BmcqwDcbV3t5jLfSk/H81vCYG+vat5PmKCr7giebt?=
 =?us-ascii?Q?texMBuMsiIIcy6IGZcOjxkvZ9bUxwd7jAFMWcStin9nwDW1ZG48whXaKJ5PC?=
 =?us-ascii?Q?HcYVxUKNizedax7r/O8hje45pkPqD9z5gNny4kvut5yAQaxTOYwERDbVLC90?=
 =?us-ascii?Q?47bfn/2Lw8i9oXu0lGVKScAvGfRP9q+BylNzbKyoHyq4s+qa/vV/kS13/JdT?=
 =?us-ascii?Q?Smy2hRG9PPadl3dFEGHvvLm1hEZptPTHxEXYqUkTOLlXNJ5n8PJmrHA9+M6u?=
 =?us-ascii?Q?C7oOKVakhSOv/DefZPWO0XJxlc9c3z47dfWQIMGilcDjh7kUCjHp1y+tWJR3?=
 =?us-ascii?Q?G4rSR7bqt/aaSS4aUtm0KHgMkR8595TcROQAdHPzN9K3zLpaM1EDQSMqT/SJ?=
 =?us-ascii?Q?x8JJVu5mBAC8ONc1AkB711RCepFyvhIIYs0ifV/FDU0yrK9OTEVkzP9stnDc?=
 =?us-ascii?Q?AX2t/HDJCbiDQlOpMFlKQY7QJUHGM96wHHK3xif7IHcWC36tRKujwusMt2/5?=
 =?us-ascii?Q?gyivLw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 668dcf84-1241-4737-a45c-08db40c5ca66
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 11:04:05.3370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WrRB/x3oJn3cA5XQIRzoMKuiOxknRPQyuL/lfU64QGBiKVmEop8p/MhEMdHuDThPiDtK8ZlOmoeMwxNu0GI7Znc1K/goJApsw28S4/atQe8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5503
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 19, 2023 at 11:50:18AM +0530, Sai Krishna wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
> 
> At the stage of enabling packet I/O in otx2_open, If mailbox
> timeout occurs then interface ends up in down state where as
> hardware packet I/O is enabled. Hence disable packet I/O also
> before bailing out.
> 
> Fixes: 1ea0166da050 ("octeontx2-pf: Fix the device state on error")
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> ---
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 11 ++++++++++-
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c |  2 +-
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 179433d0a54a..52a57d2493dc 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -1835,13 +1835,22 @@ int otx2_open(struct net_device *netdev)
>  		otx2_dmacflt_reinstall_flows(pf);
>  
>  	err = otx2_rxtx_enable(pf, true);
> -	if (err)
> +	/* If a mbox communication error happens at this point then interface
> +	 * will end up in a state such that it is in down state but hardware
> +	 * mcam entries are enabled to receive the packets. Hence disable the
> +	 * packet I/O.
> +	 */
> +	if (err == EIO)
> +		goto err_disable_rxtx;
> +	else if (err)
>  		goto err_tx_stop_queues;
>  
>  	otx2_do_set_rx_mode(pf);
>  
>  	return 0;
>  
> +err_disable_rxtx:
> +	otx2_rxtx_enable(pf, false);
>  err_tx_stop_queues:
>  	netif_tx_stop_all_queues(netdev);
>  	netif_carrier_off(netdev);
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> index ab126f8706c7..53366dbfbf27 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c
> @@ -621,7 +621,7 @@ static int otx2vf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  
>  	err = otx2vf_realloc_msix_vectors(vf);
>  	if (err)
> -		goto err_mbox_destroy;
> +		goto err_detach_rsrc;

I think it would be worth expanding on this part of the change
in the commit message. Because it's not obvious to me.
And I do wonder if it is a separate fix.

r 
>  
>  	err = otx2_set_real_num_queues(netdev, qcount, qcount);
>  	if (err)
> -- 
> 2.25.1
>