Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 13:05:38 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna <saikrishnag@marvell.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, leon@kernel.org,
        sgoutham@marvell.com, gakula@marvell.com, lcherian@marvell.com,
        jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com,
        Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [net PATCH v3 07/10] octeontx2-af: Update/Fix NPC field hash
 extract feature
Message-ID: <ZD/LAqE1eIxxoCya@corigine.com>
References: <20230419062018.286136-1-saikrishnag@marvell.com>
 <20230419062018.286136-8-saikrishnag@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230419062018.286136-8-saikrishnag@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UOxwHVIHPd+RdBToaDVzAA1ktemCLF+iQadR2+v4xxYV/jgEELTJBAo2/Mde?=
 =?us-ascii?Q?DPGO5oJddZMyhZgs/pf5Cg39G07UBRSr0rRxlTPf8z2bn17hG2pnfmWJeepR?=
 =?us-ascii?Q?tEBQoGZLQtqw/cfgeTeh3xl1ZxRpEBpbDIsRAxjEhLOWvCVdba45uz9oILnl?=
 =?us-ascii?Q?T1sAqVJaKJH/r1XtPyujqPv/AoGDF0xbCgQIxKt5/EVmXNqbC93H8IrCGRNl?=
 =?us-ascii?Q?dQ7zMMn8/0QeT73BJYCSJwrFSHikNim8UOs55f/sFrWyqpCKi51VbwoTbu2W?=
 =?us-ascii?Q?tStkEExdGmfAZUgrwJRs2l1p0QwC+BotYMlwHwoxArYNhnBDRyFdfK9pL3bm?=
 =?us-ascii?Q?czXlfWUY8UiiOlPYwLT0+ea9bRQMzlSF2MjRjdVODDe94bZBWMLougvf20YL?=
 =?us-ascii?Q?xXsyHYdiRRCNG+35FFkU3Yq32soiGqmT4DcCHG8DYJJIn1b1+1FsJbazDicI?=
 =?us-ascii?Q?a/G1B+8sNdeAB9N+B2Z14aFJkxMZf0RMqsdrHrmhrGFSlzz2GeRrHHW9fDvh?=
 =?us-ascii?Q?hV/OsGIDIMeczrKb25c2sjDPxc9a4A9Zk3fWFvhZ1zRZLKA2okvLF4nBG+cp?=
 =?us-ascii?Q?Cc5Tfh+RkGgACsk7Qv/ZXf8ORCkAqRwSyJjw/E8kgWCD8n04Ao2YVSsAZTT6?=
 =?us-ascii?Q?5VWtBy5zeKH75Mdj89Sq2Sd9mw/oZb1BIuCqIDABkvY+hnDl4mlsw8x4nbqc?=
 =?us-ascii?Q?nM+GxKFTya+b4pXDOZklUG40cmvLJnfrt1FH8ZZY931ECVBl7yUtmz5ACExE?=
 =?us-ascii?Q?+jUdt6rmr2y8zqtV5YCPCyln+uvtWKUsP+Av17MMo59pyutzrviB/0okmNdy?=
 =?us-ascii?Q?8DrEv/ljqTQ0dF+MS8WB1iTt2kfDVqwYI8bL8eQ4SDhedc11jWmiKnOHsHV0?=
 =?us-ascii?Q?8QaoWUpPzgnW/tm/QgbSAAKieZtDWshAQ4A2f/owgg/WI8ilZoq87PXVS9hq?=
 =?us-ascii?Q?D0yLimtegy1E3RoBPLoQZvnArrhTyrZb9PKul1I7jo3QQVTvou7iZrbx4ii+?=
 =?us-ascii?Q?quTKogWKGlxzRLypBchjdLiiCXIL/NEPhZX5o0z5oKu/EzRxt7JQyh/g5FU+?=
 =?us-ascii?Q?hV//1649jmG3XKUo7RCp7ynljpNPqhZ0x1ZMMf0GEZtLJGaqZ3FoSwJhh2KW?=
 =?us-ascii?Q?Fa66B9T71rxXWSMI02xjNuPSK13AYDoflSxW41GlVt4B5jEBqDlKQvAp2MJL?=
 =?us-ascii?Q?y5IzRJViUXqZ3L/+Ik6fmmfrm+Ard7YYBYDqy5IY2xWl+wbG7A9OXgljEIFc?=
 =?us-ascii?Q?B8tGqwyHVJDQQ4OnVrUog4pxrGioQQlQTqAjGWbT8cXpfifDlrU9BlS58kt4?=
 =?us-ascii?Q?xjUyGLEYqmWHlAIm1Rern6Dv/ZAFRxtrSUmypo/Pede0nYbjPL3bj/NZOG43?=
 =?us-ascii?Q?vpFQpFXnNheBTNlT9D5c/NXU/dckYBOM91L73fA7lGqFs+Bm9qF4i4soY9q6?=
 =?us-ascii?Q?fFntALhq4guAAp5dehKr4mUyffe3xxw6l8+6ynvJjMvX9sHBRZHyvvABhO69?=
 =?us-ascii?Q?f50m1VMz7a9eRD+hn0P2ZA5C1T5AifZBeqW5iY0DwbO6nM/V9GdD6Rzl64kg?=
 =?us-ascii?Q?byoT2Dpu85Vqb9q9QogQ/W0Y5phKX+obcsdWWQF2mIla6FnkntB01ZEE4a5b?=
 =?us-ascii?Q?pqf98gyVwsqH63n7/BCgxT16es7HtvHNzJVmAHXn25oROh3z07QvPjYQ2ama?=
 =?us-ascii?Q?v/SXjQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 152f2954-c413-46bb-1668-08db40c605ab
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 11:05:44.7587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VSttZOTfu/NGhCtA2gMyQD9gvbMpKEQvx0bbiadKBCfFlpfm4dB4UsuX5YRTHXDx6ALwrqaOl/JsRGwRJMimO4kS1XsE+9risro5GgpPzBM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5491
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 19, 2023 at 11:50:15AM +0530, Sai Krishna wrote:
> From: Ratheesh Kannoth <rkannoth@marvell.com>
> 
> 1. As per previous implementation, mask and control parameter to
> generate the field hash value was not passed to the caller program.
> Updated the secret key mbox to share that information as well,
> as a part of the fix.
> 2. Earlier implementation did not consider hash reduction of both
> source and destination IPv6 addresses. Only source IPv6 address
> was considered. This fix solves that and provides option to hash
> 
> Fixes: 56d9f5fd2246 ("octeontx2-af: Use hashed field in MCAM key")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

As an aside. The indentation of some of this code is quite deep.
You may want to consider cleaning that up at some point.