Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 07:27:17 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v4 4/4] counter: 104-quad-8: Migrate to the regmap API
Message-ID: <ZD/QFa+2cU/tFivr@fedora>
References: <cover.1681753140.git.william.gray@linaro.org>
 <1f1f7920d2be94aedb6fdf49f429fe6137c8cb24.1681753140.git.william.gray@linaro.org>
 <ZD5KeYJoIZ1PFKud@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="eaU7fGgbrcA6c2RU"
Content-Disposition: inline
In-Reply-To: <ZD5KeYJoIZ1PFKud@smile.fi.intel.com>
Precedence: bulk


--eaU7fGgbrcA6c2RU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 18, 2023 at 10:44:57AM +0300, Andy Shevchenko wrote:
> On Mon, Apr 17, 2023 at 03:50:50PM -0400, William Breathitt Gray wrote:
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver. With regmap we get boundary checks, read-write
> > permissions, operation synchronization locks, and more for free. Most
> > important of all, rather than rolling our own we utilize implementations
> > that are known to work and gain from any future improvements and fixes
> > that come.
>=20
> ...
>=20
> >  - Use "int ret" for regmap_* return values throughout for consistency
>=20
> Looking into it I would think it might be better to have a precursor patc=
h.
> But it's up to you. It looks good now.
>=20
> --=20
> With Best Regards,
> Andy Shevchenko

Yes, there are a few unrelated changes in this patch just to adjust from
the "err" to "ret" symbol. It's relatively minor, so if I send a v5 of
this series, I'll separate those changes to their own precursor patch to
reduce the noise here. Regardless, would you like me to add a
Reviewed-by tag for you for the changes in this patch?

William Breathitt Gray

--eaU7fGgbrcA6c2RU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZD/QFQAKCRC1SFbKvhIj
K4SOAP9f5EGJvGYHYKsTOfB7EmLLtOOhzZHRVzg5qgY55LWSugEArh/RYJZlvfHZ
P7D6kDPIpDSGZ5ZnyCpOKgsnVXXEvAQ=
=zdkT
-----END PGP SIGNATURE-----

--eaU7fGgbrcA6c2RU--