Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230417094617.2927393-1-slark_xiao@163.com>
In-Reply-To: <20230417094617.2927393-1-slark_xiao@163.com>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Wed, 19 Apr 2023 14:06:53 +0200
Message-ID: <CAMZdPi_WFxQ_aNU1t6dDh7F_aBB99XyeoFGBW2t6DryoJyFJuA@mail.gmail.com>
Subject: Re: [net-next v2] wwan: core: add print for wwan port attach/disconnect
To:     Slark Xiao <slark_xiao@163.com>
Cc:     ryazanov.s.a@gmail.com, johannes@sipsolutions.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 17 Apr 2023 at 11:47, Slark Xiao <slark_xiao@163.com> wrote:
>
> Refer to USB serial device or net device, there is a notice to
> let end user know the status of device, like attached or
> disconnected. Add attach/disconnect print for wwan device as
> well.
>
> Signed-off-by: Slark Xiao <slark_xiao@163.com>

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

> ---
>
> v2: Use dev_name() instead of kobj item and make print neat.
> ---
>  drivers/net/wwan/wwan_core.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 2e1c01cf00a9..aa54fa6d5f90 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -492,6 +492,7 @@ struct wwan_port *wwan_create_port(struct device *parent,
>         if (err)
>                 goto error_put_device;
>
> +       dev_info(&wwandev->dev, "port %s attached\n", dev_name(&port->dev));
>         return port;
>
>  error_put_device:
> @@ -517,6 +518,8 @@ void wwan_remove_port(struct wwan_port *port)
>
>         skb_queue_purge(&port->rxq);
>         dev_set_drvdata(&port->dev, NULL);
> +
> +       dev_info(&wwandev->dev, "port %s disconnected\n", dev_name(&port->dev));
>         device_unregister(&port->dev);
>
>         /* Release related wwan device */
> --
> 2.34.1
>