Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 15:49:44 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Hans J. Schultz" <netdev@kapio-technology.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Ivan Vecera <ivecera@redhat.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] net: bridge: switchdev: don't notify FDB entries
 with "master dynamic"
Message-ID: <ZD/jaASktd2cBlnI@shredder>
References: <20230418155902.898627-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230418155902.898627-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Szv2TJjo9HYHZS1wEvTQjPFKkixZtbRfm5lddE9NVyiH9Zazn7YzFSWcYMH+?=
 =?us-ascii?Q?vYzfR3fGKVF2fIAqrfslqZyygO/LkMgHFZlDHKx/brqSb4waKHcwkcok2cn2?=
 =?us-ascii?Q?GdRQeTzYamPa9KXvOqDYORQvZvMscA7cxoLy2ujbarl5jysH2qH16a7ye36n?=
 =?us-ascii?Q?djiYLDLqeGfF6jaLRFCdzaFOyV8NVMJFkx8c00TrofXuXEgicpvwMGa/VrY4?=
 =?us-ascii?Q?vOFV2YsNmlvD8aqG5x28mgy47qWG8+1Z+uULmcWVntc9gt6KGCdkopWX/Xqg?=
 =?us-ascii?Q?KIY9pXEyOir7NjWLr1m6lapN9lmP0rEhf+1eu+b/W6HoNLXGQxzSXj8JHryY?=
 =?us-ascii?Q?sVOsBXvshgeYDX54Xg6xDDMUhj+P2OQY2EmLehpH4GyCz7vlwDFNmOdy1gtv?=
 =?us-ascii?Q?0GxPET4MWefOPR1Djdt/GIhhBq6rNINt9Aoa//m/7KHbZ9Qki1StuaxtqFE8?=
 =?us-ascii?Q?a5EvHelmfjtFWwXAx4NbWzGhn9akzTEHJKelHeV/zrwUnAoaxklt5RAKHKie?=
 =?us-ascii?Q?m90o/4qwqYBgeeEmymi9g5MJZO0PkHs2Ms7/hn9eRpcdzvQmk3pVkLyzzro9?=
 =?us-ascii?Q?kBSDMhg3XugEyRsVnH/I+hkuCmxFGJQUTmh6zu8QvmCM8WaVueVB5A4Ix6vw?=
 =?us-ascii?Q?2SWwfgMjTF4rYYYDuO9tH/RCtRXd7jxcukVXsIy1564ku7QpqLX/qj4Musfk?=
 =?us-ascii?Q?Wfm7fdryKIx9mh9o3PsMR8IwDWTvcTRffa/CZedSMRYGRMcR9z0uu+AybXp4?=
 =?us-ascii?Q?mzUaGbls8y29LwYOKoQci4GLxXAQCFhl4NZ4Sdu/Ima0ka5QNr3WYjTvpqjU?=
 =?us-ascii?Q?BAxhYbSSzSMgIcQdeMgBQkkaBPvUFd9IBw+TsW0TmUELm+iyXS12vPNQCCvZ?=
 =?us-ascii?Q?8chpLp3us1KmjtqSUCWXwwLYVp0voD2tg6H/AMGsCI81SN3G1p73rzoRO/nZ?=
 =?us-ascii?Q?UqNqaA7ISQcsoQhSAG8UCYgHexV9ihQaiAP4QEBlRVgGSwGxxJt6JKPg8Hye?=
 =?us-ascii?Q?+XKElMQo6PfNU4/GCQ6f+Q8+oTQOrJWraQFM7AgZcVl2PDKP0hGD/pmei0ds?=
 =?us-ascii?Q?Aq4AkTWLbNMyDaSOWleiWCF49SGMFPcWnDmK8gzDl98Py7yrH4qdMtHEgPHy?=
 =?us-ascii?Q?CijE4trWqc8mKjhikT2dkaQbTIS8LcdYYmQKh6CwLVEDRTzAKknSsw8OroZv?=
 =?us-ascii?Q?jcYLcG8RaISmXORpwc2k3VPnr+X/u7XeeGjTloJ6aCIEvbTHMbOyzKH6WFi6?=
 =?us-ascii?Q?JavUVrBjrV3IeWV1r4toeDnjhuNnJUq2GA1ael/NdcbALeKcg07eaPFaU4ao?=
 =?us-ascii?Q?Gotmsyjf6hzJ3kJTAhqkLCTxI5aITccNYOF/9i7SgRYgUEQcWV7NSEjDa3rO?=
 =?us-ascii?Q?LgF9+Ei2zYE+Mw39a1uu4rgbIEuoI1rWHsIgfFvFXDuI41y8QZoW3fiKf4BY?=
 =?us-ascii?Q?ivNjnQhFz4zXC2WaiwMjhVZFT8+HksJ3wlx1/dZenDY85l6HjcXfNwcHuDaJ?=
 =?us-ascii?Q?z4g/pb1moxbjkta5h7KfHyC+uJxxCXDjKh4BrksPZy+05S/jzWK49F2toWsP?=
 =?us-ascii?Q?3N/T4nvlxPwHEbo7CukDys+mtKLCuDLDL71G374f?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b604d04-f8c8-4568-01f5-08db40d4916a
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 12:49:52.2983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jbH3YO2xEU14cGttEv3yINThYs0iRJ5oUjLY52Tq16BZHj1UfVlIOUWRacQSbGHPmd7hRtbS/7yIc62Rvym3tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7835
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 18, 2023 at 06:59:02PM +0300, Vladimir Oltean wrote:
> diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
> index de18e9c1d7a7..ba95c4d74a60 100644
> --- a/net/bridge/br_switchdev.c
> +++ b/net/bridge/br_switchdev.c
> @@ -148,6 +148,17 @@ br_switchdev_fdb_notify(struct net_bridge *br,
>  	if (test_bit(BR_FDB_LOCKED, &fdb->flags))
>  		return;

Thanks for the patch. Ran a few tests and looks fine. Will report full
results tomorrow morning.

>  
> +	/* Entries with these flags were created using ndm_state == NUD_REACHABLE,
> +	 * ndm_flags == NTF_MASTER( | NTF_STICKY), ext_flags == 0 by something
> +	 * equivalent to 'bridge fdb add ... master dynamic (sticky)'.
> +	 * Drivers don't know how to deal with these, so don't notify them to
> +	 * avoid confusing them.
> +	 */
> +	if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> +	    !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> +	    !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> +		return;
> +
>  	br_switchdev_fdb_populate(br, &item, fdb, NULL);
>  
>  	switch (type) {
> -- 
> 2.34.1
>