Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp251346rwr; Wed, 19 Apr 2023 06:11:18 -0700 (PDT) X-Google-Smtp-Source: AKy350bB25fYL+Kr3KurAIikPdGKKgCkVQYZiT2PSTS/uK6ZFJ43Zu2F8J0LIqZDw7jcsCyucVre X-Received: by 2002:a05:6a20:42a0:b0:ef:4321:a8a0 with SMTP id o32-20020a056a2042a000b000ef4321a8a0mr3890258pzj.6.1681909877689; Wed, 19 Apr 2023 06:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681909877; cv=none; d=google.com; s=arc-20160816; b=h6h1jUHwzLJBp7ZKttQ5NgB7c+85fHhK/Y6J1yK9c0gx+aTqndQtiCIP4AaHQmD0a6 rY54fi26ueeCqyUK+gIJdI+pDr2WSmTYM3FtTmZ0qlQJNDLf8Ssg7H5Ug+HZLC+0neAK r+kihPaOhhep7ni+9C+1lyIszEx8BzeB7DY/cC1yGBf9iSUI6ASbbChABOhlz9UucpCH LLuqEhymMpPwOAp+Y5H65OVsIZ1TXc1iTcxj8jLGWl4pXBICd91qrR9ePZmhF9qxZQSz znEMUBpvOZdlDmkF/L4k6QVqVxljPLzBqt5FE6GS2UAUjbWLImk7ugo4DqHgiy+GqfFz z4gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=f16w+eV0+2Sr0OvGkfcho9W3kJDfX6onkCcXskuyqPs=; b=WEsOaxlHyz3CESmzb2+kjqonv5TWUNGqMuUEk43+O5q3PYBHOXOGd6QczCcC+UJfjE ZRguVI9J5BVpRoM50fsmK7SseExpV74IKnXzLHmBIE1Es2zXwryd6AZQc0WJF48mEscW atF/rz0gz4OFMAQjLOom1hOoRs2d8keqnWgN7iYeot9c+X8RVlcZtYV3AvxA+nH44AWo mkAtBjwKbe8zGz4o/NgIM83wXTEoMjQTwlgAaYnTQl2TQbYhGd5HOIYZXlHqobop5Zo2 vTeJ7WuYNiEPlcV+RA2np1su2B7EN+hTbmCLI/a+T2o6ic54Tv/oT1pqEhbUmOTxSV6t 8FGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LS0DFvvP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nv15-20020a17090b1b4f00b0022c24bf1810si1866270pjb.29.2023.04.19.06.11.00; Wed, 19 Apr 2023 06:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LS0DFvvP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232693AbjDSNCP (ORCPT + 99 others); Wed, 19 Apr 2023 09:02:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbjDSNCN (ORCPT ); Wed, 19 Apr 2023 09:02:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE745FC7 for ; Wed, 19 Apr 2023 06:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681909284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f16w+eV0+2Sr0OvGkfcho9W3kJDfX6onkCcXskuyqPs=; b=LS0DFvvP3JAvbrGDqanGPRgIt2r0K8PbecLsaiC0LmBWpUuvzkgC3r/+Xp4FgclBwfxyh2 xqZ/AtEMxsn/YJXUm8n7X3fkQ9mAhK6sbrdqdaGGceGZJKy33Do0WSaxvhI7oqMkyHfW0j +OXiVdHq0t6Z2nWoKFzrwRqk5wZ4Qik= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-99--ci2SF8-NGKZHk1uBniPUg-1; Wed, 19 Apr 2023 09:01:23 -0400 X-MC-Unique: -ci2SF8-NGKZHk1uBniPUg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58F453815EF4; Wed, 19 Apr 2023 13:01:22 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1937C1121314; Wed, 19 Apr 2023 13:01:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <168190833944.417103.14222689199936898089.b4-ty@kernel.dk> References: <168190833944.417103.14222689199936898089.b4-ty@kernel.dk> <1770755.1681894451@warthog.procyon.org.uk> To: Jens Axboe Cc: dhowells@redhat.com, Ayush Jain , Christoph Hellwig , Al Viro , David Hildenbrand , John Hubbard , Steve French , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] splice: Fix filemap of a blockdev MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1842477.1681909280.1@warthog.procyon.org.uk> Date: Wed, 19 Apr 2023 14:01:20 +0100 Message-ID: <1842478.1681909280@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Note that this shouldn't affect direct_splice_read() as that doesn't look at the size of the file, but rather just keeps reading from it until the requested amount is read, the pipe is full or ->read_iter() indicates EOF by returning 0 (so it could work for copy-splicing from a pipe/socket/chardev too). David