Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 15:13:28 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
Cc:     heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: typec: intel_pmc_mux: Expose IOM port status to
 debugfs
Message-ID: <2023041928-step-salsa-3cba@gregkh>
References: <20230419130345.1689915-1-rajat.khandelwal@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230419130345.1689915-1-rajat.khandelwal@linux.intel.com>
Precedence: bulk

On Wed, Apr 19, 2023 at 06:33:45PM +0530, Rajat Khandelwal wrote:
> IOM status has a crucial role during debugging to check the
> current state of the type-C port.
> There are ways to fetch the status, but all those require the
> IOM port status offset, which could change with platform.
> 
> Make a debugfs directory for intel_pmc_mux and expose the status
> under it per port basis.
> 
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
> ---
> 
> v3: Allocate the debugfs directory name for the platform device with
> its ACPI dev name included

{sigh}   No, sorry, this is not correct.

Also, you did not properly follow the rules that all Intel kernel
developers are supposed to follow.  Please consult your local kernel
developer team and do so before sending any more kernel patches out.

greg k-h