Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230419122058.3420-1-hackyzh002@gmail.com> <62ae58cb-9fec-37ca-fd40-12bf0c1c5ba3@amd.com>
In-Reply-To: <62ae58cb-9fec-37ca-fd40-12bf0c1c5ba3@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 19 Apr 2023 09:49:08 -0400
Message-ID: <CADnq5_MTgMtHM87YQJcZLcENevcHOuQihoTz-xRetypJ6BQSXQ@mail.gmail.com>
Subject: Re: [PATCH V3 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     hackyzh002 <hackyzh002@gmail.com>, alexander.deucher@amd.com,
        Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        dri-devel@lists.freedesktop.org, sumit.semwal@linaro.org,
        linux-media@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Wed, Apr 19, 2023 at 8:24=E2=80=AFAM Christian K=C3=B6nig
<christian.koenig@amd.com> wrote:
>
> Am 19.04.23 um 14:20 schrieb hackyzh002:
> > The type of size is unsigned, if size is 0x40000000, there will be an
> > integer overflow, size will be zero after size *=3D sizeof(uint32_t),
> > will cause uninitialized memory to be referenced later
> >
> > Signed-off-by: hackyzh002 <hackyzh002@gmail.com>
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com> for the seri=
es.
>
> > ---
> >   drivers/gpu/drm/radeon/radeon_cs.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeo=
n/radeon_cs.c
> > index 46a27ebf4..a6700d727 100644
> > --- a/drivers/gpu/drm/radeon/radeon_cs.c
> > +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> > @@ -270,7 +270,8 @@ int radeon_cs_parser_init(struct radeon_cs_parser *=
p, void *data)
> >   {
> >       struct drm_radeon_cs *cs =3D data;
> >       uint64_t *chunk_array_ptr;
> > -     unsigned size, i;
> > +     u64 size;
> > +     unsigned i;
> >       u32 ring =3D RADEON_CS_RING_GFX;
> >       s32 priority =3D 0;
> >
>