Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kumar, M Chetan" <m.chetan.kumar@intel.com>
To:     Ruting Zhang <u202112078@hust.edu.cn>,
        linuxwwan <linuxwwan@intel.com>,
        Loic Poulain <loic.poulain@linaro.org>,
        Sergey Ryazanov <ryazanov.s.a@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
CC:     "hust-os-kernel-patches@googlegroups.com" 
        <hust-os-kernel-patches@googlegroups.com>,
        Dongliang Mu <dzm91@hust.edu.cn>,
        M Chetan Kumar <m.chetan.kumar@linux.intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: wwan: iosm: fix a resource leak in probe
Thread-Topic: [PATCH] net: wwan: iosm: fix a resource leak in probe
Thread-Index: AQHZcckfOuYLABRYjUSFfguu+GlGKa8ypogA
Date:   Wed, 19 Apr 2023 13:53:50 +0000
Message-ID: <SJ0PR11MB50087AB2A36558365343EBC1D7629@SJ0PR11MB5008.namprd11.prod.outlook.com>
References: <20230418073858.36507-1-u202112078@hust.edu.cn>
In-Reply-To: <20230418073858.36507-1-u202112078@hust.edu.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F2ygx7wH3QXIJb0B+nNk5Ba0L7y65Bts2S1wkIpSYOa6G8OewM7yc6zq3aQg?=
 =?us-ascii?Q?MaybcnAJQOgn48xYtWvMAVO+3VgYf6h7W0Jj+c0Xcn+S23KB2x6H2di1x6hB?=
 =?us-ascii?Q?7m//RfGyJx/WWzIyObx6HYobC6m5/Z4MfmPCW/q9wEbPWWiI/aFJAl2taATy?=
 =?us-ascii?Q?wJNKBRCqd+zh90XqsLIKIHK+cPXwm+TZydGkKUwPKoD7btjB8RkCJxq+Z/oC?=
 =?us-ascii?Q?IsqGafGpCqRmagjrGMChJG0ebuCTHQ6WvouE7nynDqT6wU6rRFHCwI6rdb56?=
 =?us-ascii?Q?IV3NIIUtk5xqJ1FomqIF1ZybRkupr/Xhj8mgKbrlNLVN+N6NtH2gvuq986ZB?=
 =?us-ascii?Q?2hcfS7cO7xq6HvUlsAn/ZN2sVv9Icj7c0Uk5wSUlh92naA3E6YxE/Ivu/4Pv?=
 =?us-ascii?Q?GYp+tYXVaBDDgja/zQqGLjMT5/fdrzuRAmJ7tnl93M2KykWR7gEZax35IbiP?=
 =?us-ascii?Q?06z3htjuz6i1+4PD7ijoi2Zd7H9wrSrhBmFTRgCzgjtIEhTXpF7AMk2iMxbi?=
 =?us-ascii?Q?WDEKtCeY0kEAzlekD2b7kc9bdZiJ8AAzHaVDPmDxO+0pORCqeLKGdO0SZQph?=
 =?us-ascii?Q?FZHzQHGfm7k+YY17ONIEV55UZrUQ3RIxpiwgHgp+85OY62F7X6jw/xwXo1QT?=
 =?us-ascii?Q?cRL0ZIoy3qR5VOH3IQXA+nSh+BB29CSCIfcsw60FoHI8YVYvEWC2VWGdnqba?=
 =?us-ascii?Q?5EQaXuWWqdusjFZInKbc5sQBHJeencxWEWsFB6oVr/iXmMNLJt5T+hqEDztD?=
 =?us-ascii?Q?PeVoTM88i99idyWTwXzfL2uO8Q4UR9jzFtRoQlTrtGkGxaaybqAhmmrd+d0Y?=
 =?us-ascii?Q?ABPslF9+jBEdI7aecNSvOr3jlhJBBvjrXzTrWEyjr36lDBK6EFBt86RHZrdo?=
 =?us-ascii?Q?TLX4hxsIn3CUDxWCPMmnaeNrQj46saoLFvQTkVHs95BTgWMXevluA/0qqUhN?=
 =?us-ascii?Q?p0HairaH7/LbkVF91qk7TI5PFWxNo0AXYRzvV5FrBJyXOd5lF26od1AsmQ87?=
 =?us-ascii?Q?kMbDSHUI+LTDTkAQBF3JFH6oP1LXbl3+7+m63d3HU7XrMSt/psUEmBGtaHNO?=
 =?us-ascii?Q?le4r0zMPQP6Xv4BaeV4sAu7ulcjd+lwJ/pThFsfyLPc7zzeVRg6t7/IZXXnU?=
 =?us-ascii?Q?hodJt60UKuqi6F+poyqIi6//jEjR8HCkeknU4/B8O/cBoLO3mZBnJBc3b7jZ?=
 =?us-ascii?Q?SenaRAN3JFqd3yaN3pRAG+7rziWtNRfSGslQJO+kwpehiM2+MusArrjZC9ST?=
 =?us-ascii?Q?tRlTmSUUBwgJ/4EMTTxMd8ONS5UUlF04l+iQBEFh3I/m5AaG6TXj19fViG4q?=
 =?us-ascii?Q?wsAy8DPXy+bBMTyj/tvhHcHOIVqMZ06B1OhRRkid6jvToirp+yH1XCNwRw/T?=
 =?us-ascii?Q?35vQClz3/1ApNNyh8g0HVZKEq0NEtzG1xah0GGGsyoIn1J5Kq7N697ADCmFj?=
 =?us-ascii?Q?wzAYysUii0/YRzG7ZbgExNz7Jp9kaqArDDpWJYMr9yvddzr0Owf4y1GvU+dn?=
 =?us-ascii?Q?nc8Gi9IDZnFXFxm3vdrnBwBgE7akAOv2QwzA45eldAc/b211ZDPZ6AadupI+?=
 =?us-ascii?Q?kdCrGlIl5DAHVQrhKUggaSDamdX7V29VZiDMAI+S?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5008.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85405b3c-d079-45ac-368b-08db40dd819d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2023 13:53:50.9416
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FZOtC9w9wsLaOMhWSpi0CApREr3S0u3+7VeUgPZIsLhsQduprTQa9MRE4MngUWW8EuXvgaq7Vf8pye+HmRR+Bcgcye2zixT2IRqvmsAl9mE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5482
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Ruting Zhang <u202112078@hust.edu.cn>
> Sent: Tuesday, April 18, 2023 1:09 PM
> To: Kumar, M Chetan <m.chetan.kumar@intel.com>; linuxwwan
> <linuxwwan@intel.com>; Loic Poulain <loic.poulain@linaro.org>; Sergey
> Ryazanov <ryazanov.s.a@gmail.com>; Johannes Berg
> <johannes@sipsolutions.net>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>
> Cc: hust-os-kernel-patches@googlegroups.com; Ruting Zhang
> <u202112078@hust.edu.cn>; Dongliang Mu <dzm91@hust.edu.cn>; M
> Chetan Kumar <m.chetan.kumar@linux.intel.com>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] net: wwan: iosm: fix a resource leak in probe
>=20
> drivers/net/wwan/iosm/iosm_ipc_pcie.c:298 ipc_pcie_probe() Smatch warn:
> missing unwind goto?
> There is a resource leak in this place.
>=20
> Fix it by changing "return ret" into "goto resources_req_fail".
> Fixes: 035e3befc191 ("net: wwan: iosm: fix driver not working with
> INTEL_IOMMU disabled")
>=20
> Signed-off-by: Ruting Zhang <u202112078@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> The issue is found by static analysis and remains untested.
> ---
>  drivers/net/wwan/iosm/iosm_ipc_pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> index 5bf5a93937c9..33339e8af1dc 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c
> @@ -295,7 +295,7 @@ static int ipc_pcie_probe(struct pci_dev *pci,
>  	ret =3D dma_set_mask(ipc_pcie->dev, DMA_BIT_MASK(64));
>  	if (ret) {
>  		dev_err(ipc_pcie->dev, "Could not set PCI DMA mask: %d",
> ret);
> -		return ret;
> +		goto resources_req_fail;
>  	}
>=20
>  	ipc_pcie_config_aspm(ipc_pcie);
> --
> 2.34.1

Recently it got fixed and patch is applied to netdev/net.git (main).
Refer to the applied patch [1].

[1]=20
https://patchwork.kernel.org/project/netdevbpf/patch/20230408194321.1647805=
-1-harshit.m.mogalapalli@oracle.com/