Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 07:22:37 -0700 (PDT)
Subject:     Re: [PATCH V2] riscv: export cpu/freq invariant to scheduler
In-Reply-To: <20230323172403.nfrtgm5vea4qvinu@orel>
CC:     suagrfillet@gmail.com, Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, Conor Dooley <conor.dooley@microchip.com>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     ajones@ventanamicro.com
Message-ID: <mhng-d4a888a4-a2c5-4520-82d1-b8eb66a7f3d1@palmer-ri-x1c9>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 23 Mar 2023 10:24:03 PDT (-0700), ajones@ventanamicro.com wrote:
> On Thu, Mar 23, 2023 at 08:39:24PM +0800, Song Shuai wrote:
>> RISC-V now manages CPU topology using arch_topology which provides
>> CPU capacity and frequency related interfaces to access the cpu/freq
>> invariant in possible heterogeneous or DVFS-enabled platforms.
>>
>> Here adds topology.h file to export the arch_topology interfaces for
>> replacing the scheduler's constant-based cpu/freq invariant accounting.
>>
>> Signed-off-by: Song Shuai <suagrfillet@gmail.com>
>> ---
>> changes from V1:
>>   - fix the leading underscore and tidy the patch up
>> ---
>>  arch/riscv/include/asm/topology.h | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>  create mode 100644 arch/riscv/include/asm/topology.h
>>
>> diff --git a/arch/riscv/include/asm/topology.h b/arch/riscv/include/asm/topology.h
>> new file mode 100644
>> index 000000000000..727e8d163a3b
>> --- /dev/null
>> +++ b/arch/riscv/include/asm/topology.h
>> @@ -0,0 +1,20 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +#ifndef _ASM_RISCV_TOPOLOGY_H
>> +#define _ASM_RISCV_TOPOLOGY_H
>> +
>> +#include <linux/arch_topology.h>
>> +
>> +/* Replace task scheduler's default frequency-invariant accounting */
>> +#define arch_scale_freq_tick	topology_scale_freq_tick
>> +#define arch_set_freq_scale	topology_set_freq_scale
>
> I was thinking all the right hand side would line up, which means
> the above two need additional tabs and so does topology_get_cpu_scale.

I don't see a respin, but given that the feedback in just whitespace 
changes I've got and picked this up while fixing the whitespace.

>
>> +#define arch_scale_freq_capacity	topology_get_freq_scale
>> +#define arch_scale_freq_invariant	topology_scale_freq_invariant
>> +
>> +/* Replace task scheduler's default cpu-invariant accounting */
>> +#define arch_scale_cpu_capacity	topology_get_cpu_scale
>> +
>> +/* Enable topology flag updates */
>> +#define arch_update_cpu_topology	topology_update_cpu_topology
>> +
>> +#include <asm-generic/topology.h>
>
> I'd also prefer a blank line here.
>
>> +#endif /* _ASM_RISCV_TOPOLOGY_H */
>> --
>> 2.20.1
>>
>
> Otherwise,
>
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
>
> Thanks,
> drew