Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <73859c9e-dea0-4764-bf01-7ae694fa2e37@kili.mountain>
In-Reply-To: <73859c9e-dea0-4764-bf01-7ae694fa2e37@kili.mountain>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Wed, 19 Apr 2023 16:29:42 +0200
Message-ID: <CAMj1kXEiF5kZvaQz5FPHONRM9WWugP4CT6yZZVDiw5=s-OZBEw@mail.gmail.com>
Subject: Re: [PATCH] arm64: delete dead code in this_cpu_set_vectors()
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     James Morse <james.morse@arm.com>, Will Deacon <will@kernel.org>,
        Kristina Martsenko <kristina.martsenko@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Mark Brown <broonie@kernel.org>,
        Liu Song <liusong@linux.alibaba.com>,
        D Scott Phillips <scott@os.amperecomputing.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 19 Apr 2023 at 09:58, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The "slot" variable is an enum, and in this context it is an unsigned
> int.  So the type means it can never be negative and also we never pass
> invalid data to this function.  If something did pass invalid data then
> this check would be insufficient protection.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  arch/arm64/kernel/proton-pack.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c
> index fca9cc6f5581..05f40c4e18fd 100644
> --- a/arch/arm64/kernel/proton-pack.c
> +++ b/arch/arm64/kernel/proton-pack.c
> @@ -966,9 +966,6 @@ static void this_cpu_set_vectors(enum arm64_bp_harden_el1_vectors slot)
>  {
>         const char *v = arm64_get_bp_hardening_vector(slot);
>
> -       if (slot < 0)
> -               return;
> -
>         __this_cpu_write(this_cpu_vector, v);
>
>         /*
> --
> 2.39.2
>