Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91654bbb-4bc1-2218-14e7-99fed3a3408b@amd.com>
Date:   Wed, 19 Apr 2023 11:12:48 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2] drm/display: Add missing OLED Vesa brightnesses
 definitions
Content-Language: en-US
To:     Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>, airlied@gmail.com,
        daniel@ffwll.ch
Cc:     Anthony Koo <anthony.koo@amd.com>,
        Iswara Negulendran <iswara.nagulendran@amd.com>,
        Felipe Clark <felipe.clark@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230412000943.429031-1-Rodrigo.Siqueira@amd.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20230412000943.429031-1-Rodrigo.Siqueira@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NSt2bTkzMlJISndScmZEVkh1MjNjU2pOOFIwYUNyaEhQODJvNUxKQm1BUkVI?=
 =?utf-8?B?UWZldmNRS0o4eU4yT1ZFMTIwQlE1V2FqTTM0czA1TEdlbm40c2xJUGR0TFFC?=
 =?utf-8?B?Uy9yM0pzWFNxNzhjM3lzTkNDMkl4ckkxUjkzTC9peWl0emQvWElRYTE2UzRv?=
 =?utf-8?B?eWg5YzJhenFXMjJpZ0tuckNaK2dsSDVpbHcxbjJiNFVBeFlvc21GakpOdVBV?=
 =?utf-8?B?dmdMb2hvUHZ6WWxKYWhPM0RZNEZoejRkazB2eG5FUjJiNWhNanBHQS9DTHNi?=
 =?utf-8?B?UTlMTHZMbWdNMTRUL01EeW4xTGwyVGoxWXpWUUhvMFZyMHcyTm5RSSt4dnZv?=
 =?utf-8?B?dEZMVkZ1bEpKK1VPak0xUm1YK2VUcjF6a0NYdHdUamordjE0N0pRNW1DeVZh?=
 =?utf-8?B?YktDeDI2UGtRU3c0U1MvSkttc1VqNkhOd1B1WlZKZkdQNWxtMTdlMDN3MWlY?=
 =?utf-8?B?ZWp0WUc4UmtvdTYrR0dMMGUzMjZTNE9WS0hXS25oazlHN1laYjM1WnhZa1JZ?=
 =?utf-8?B?dWZnMTBoNUpXNitxTG0wY25kWUlLZUl0L09iWFhVdldHemJOMkdvVUVZb0Fh?=
 =?utf-8?B?VVBMRFFDdmNRVkdDS1dqbzNFODR3SjYwYmh3OXd4d1hxOWpUdUdHblBZS21V?=
 =?utf-8?B?TFV1K1pKM1lMLzNyZ2krSFNEckdpc2VOMTV6OGRuOEdjZUJsWVdSQzkydGNy?=
 =?utf-8?B?SFNOTFJYck5ONXNmaHlUVWV2VXpUNEgxVnBsMVlJZGxkT09nS2dXRkU4VnNW?=
 =?utf-8?B?QXYzYk1jeGJzaGZvZ2xuckVHWFFGcmRxRnVaRFBXNU5tVmxvWDZEOFcySHpB?=
 =?utf-8?B?ZDAySk9zUXkzTTNGbmh0aUhVY1hTMUJXaG1UeDZrdkVKTFN2Q1Zjb0Vrd29D?=
 =?utf-8?B?Q0ZIdVdJQURZMWIrYTVoNkhjVzNZOEFzVkV5cjVLbjdjNjNMVnJDSThuTW90?=
 =?utf-8?B?UVNtVG45YWxmby90SnIxK2ZRU2oxdnE0RjVNMUJlZ0RsMWxyV2JuVzlIUFgy?=
 =?utf-8?B?T1J3ak0wZ1NlMDVXMGhJQlpDbi9ueFhZdFZacyt4dlJvMEY5cDZTcGJOQno4?=
 =?utf-8?B?OElOVmVweW1Wc1Fvd1krOGR6OTloVjdCTWpnNE4ramJKNnJKZDdhNUpxSmJK?=
 =?utf-8?B?ellvQ2FvUE9pbHYwSDBkZGJiM2tUcDdUakJxN3FxaXV3S3RiS0c1VEFZVXpy?=
 =?utf-8?B?VFJwUXRHSVhxYnAzYmNrN1JVMm1NYko1dWxMTHpxYjZEUEVhZUE0dzc2N1dO?=
 =?utf-8?B?RDF4NlVGUHYrZXBNNk5DWEZmK1NlY0pEdUx2WGVHd0Z3YTRkTXo2UHd5MHQw?=
 =?utf-8?B?NjRyUUZYWi8wcm9LWFFYVHF6dEhxZ1ZhWlBMV3R6cHJldjNDV3crTlZZS3Bx?=
 =?utf-8?B?SXJua1lCOVFaSCtEM21Tc0Z6b2tLR3lmS2tXbVlRSGswZWRZUkpBbVRjeWJn?=
 =?utf-8?B?UFJ5NFBoQWhEUkp1a0dsa3JqVFBCWUp5M09LRitvZHBrQXZVNS9MQlM3U2s5?=
 =?utf-8?B?TzZJV3hMdXU1ekEzUCs5MXdXZDM4bFBvQkRlaVhnZHN6TWREdGNMV2VGTldQ?=
 =?utf-8?B?ZVU4NGpJeVNUTHRQczN2NzFiTEgvN0cxQTRFQTRaN1FLVVJhY2ZzdmxUeEdW?=
 =?utf-8?B?NUdYajNVVUlBbzZUQmNQSUFaTjVDd2dHNkNOelV5Q21ObnNPUTVjK0hDM3cw?=
 =?utf-8?B?MDltZEI1SUxicG5ua1FTT1dncjBJZkwvNVdIM1hLOFNETThBWElHdUphMVJ0?=
 =?utf-8?B?bDY5dW0rY0czK2JxWW5Cbms1Rm94L3o0TmVSODVGT1BjK3I2YVZRS3N2cUtk?=
 =?utf-8?B?U1I0ak4wU241dGZXaEZKUUNhVmxLbGJvK0ZkMS9SRkYydDg0OFordjlrU0t6?=
 =?utf-8?B?UjdSblhvaVNWQ0ZSL2lKb0dXbHd3SktvVVBwNWprenRmWjQzR2NvMW9NZkFX?=
 =?utf-8?B?bEdibEhJcmVSQVNaYlVsWXZHbUdpMHhObjREQ0VEdlJUeGM5bHdtQ00wVXJH?=
 =?utf-8?B?RW9NcFFMREU3dlNCd1h3OGhvM3F3V3hrNWpZajNqV1VYOG5KbEdhREE5Wk9Z?=
 =?utf-8?B?TXlMUDNZYWh6bkx2VnFsTlV4a1ZHaGJMT3d1RHg0QUFUdTROcU5TM1o1M2d1?=
 =?utf-8?Q?uJUV24s5lqRFR1f2AUsX0Mfrn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ae2978e-3ea6-493b-1ff1-08db40e88c3d
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 15:12:53.6073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JvWCeCW75ZzibbD7A6kwPPEdXAIBn4X4+fvG8WGXI2vx5Y3C8LrGJvFWy6cRCVPeR5k6Lz73AP7qHZ0uuxvi9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6155
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/23 20:09, Rodrigo Siqueira wrote:
> This commit adds missing luminance control registers to enable a more
> standard way (VESA) to deal with eDP luminance control.
> 
> Cc: Anthony Koo <anthony.koo@amd.com>
> Cc: Iswara Negulendran <iswara.nagulendran@amd.com>
> Cc: Felipe Clark <felipe.clark@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  include/drm/display/drm_dp.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index ed10e6b6f99d..7ad749423a48 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -973,6 +973,7 @@
>  
>  #define DP_EDP_GENERAL_CAP_2		    0x703
>  # define DP_EDP_OVERDRIVE_ENGINE_ENABLED		(1 << 0)
> +# define DP_EDP_PANEL_LUMINANCE_CONTROL_CAPABLE		(1<<4)
>  
>  #define DP_EDP_GENERAL_CAP_3		    0x704    /* eDP 1.4 */
>  # define DP_EDP_X_REGION_CAP_MASK			(0xf << 0)
> @@ -998,6 +999,7 @@
>  # define DP_EDP_DYNAMIC_BACKLIGHT_ENABLE		(1 << 4)
>  # define DP_EDP_REGIONAL_BACKLIGHT_ENABLE		(1 << 5)
>  # define DP_EDP_UPDATE_REGION_BRIGHTNESS		(1 << 6) /* eDP 1.4 */
> +# define DP_EDP_PANEL_LUMINANCE_CONTROL_ENABLE		(1<<7)
>  
>  #define DP_EDP_BACKLIGHT_BRIGHTNESS_MSB     0x722
>  #define DP_EDP_BACKLIGHT_BRIGHTNESS_LSB     0x723
> @@ -1022,6 +1024,7 @@
>  
>  #define DP_EDP_DBC_MINIMUM_BRIGHTNESS_SET   0x732
>  #define DP_EDP_DBC_MAXIMUM_BRIGHTNESS_SET   0x733
> +#define DP_EDP_PANEL_TARGET_LUMINANCE_VALUE 0x734
>  
>  #define DP_EDP_REGIONAL_BACKLIGHT_BASE      0x740    /* eDP 1.4 */
>  #define DP_EDP_REGIONAL_BACKLIGHT_0	    0x741    /* eDP 1.4 */