Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 19 Apr 2023 17:14:43 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: ksz8795: Correctly handle huge
 frame configuration
Message-ID: <ZEAFYwrReNwcNl+d@corigine.com>
References: <43107d9e8b5b8b05f0cbd4e1f47a2bb88c8747b2.1681755535.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43107d9e8b5b8b05f0cbd4e1f47a2bb88c8747b2.1681755535.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hfDF3/SMBbb1BMMn29FiJosIqhMI3FDRl3tYdfcALo9eLBtitIMsouZ0Jff/?=
 =?us-ascii?Q?jyqpoJu+kphGp0XPD1ZYKbeqDn+wmQfWVDJA7tHmv1+a4xJq87bxKyRIuhFT?=
 =?us-ascii?Q?hAJ2Wh3TLKQiEs7WyowihzBjpF+3SotUApnltizSagUgDVdy8eqtjhe3txJB?=
 =?us-ascii?Q?qZkQ3J2cJHTSWabUBjaquuEaAKELx61yhDQKT4ieRhBcw1k9jZVQ/66OISn5?=
 =?us-ascii?Q?AaRXuTWlHSjR6YdUWOcMpyhgFUZAnl0iJuF21/lVTGoBZzG0c9HLq1iGPbWV?=
 =?us-ascii?Q?8F0MCfXSL+ZyUd+p0OsC1JlHTEBoHh0UoF6Nxf14UZiyxOj7oDZtyHEoxB+k?=
 =?us-ascii?Q?bwwgIjzRFXW4xdRk03nU+ze4tBggt2UjU5VzFoNxT/cTUgWE7DzEjUqh2mzc?=
 =?us-ascii?Q?5SdLKpqP+yP+NSV2KBhdM4wnH6Sa3qBmkps8jVPwVwbPpwUl6SneiSZuChHn?=
 =?us-ascii?Q?SNXlD1QB5juI4Isy1vjuPSymmmcoxPRiRzJcIABHByJOSEZy54soNeGDy2wH?=
 =?us-ascii?Q?dMWo0BlRYj4/QLZQSzESb7K9ZQVSyDXFIRhNQZcTOOMLS2o9CDFPRkG3HknW?=
 =?us-ascii?Q?xdjXurlXiEH8R12yq4Il6Jdzr/wVzZr7h8DHoOdloWBH4Rts2e3M85ubwpRh?=
 =?us-ascii?Q?qxqmxSQwFJQwR+bE5seJUCyvlwNqGrBVrWtWa9pkLp3/eKVptsMM3ecRid3r?=
 =?us-ascii?Q?d4eKnEN2zCuDgjJOJzZ1G+S1sLZvjKNjGYgbQyuV78Mzs4A0JIK7weSoVf1d?=
 =?us-ascii?Q?Rtyd+/iFJiCYWfoGoFCub+2z+Yso8ODjHyut16DN96GD9EzExrLadJd4N1cr?=
 =?us-ascii?Q?Ec4yNMeVM0iEaPKZvmQg2IT/mQwj9viEKJQmmObzsz6Eaj7lUshzsZEZ74fi?=
 =?us-ascii?Q?1GiKZ7g2XUhMtErH8ZgwTgXWPvolmzg9I9LJI7kAXTJL4GcNOCFqRkkgpt2o?=
 =?us-ascii?Q?9fF6cmXNgo+0aVOTicDBWXzEpjh4c/W25K1tBsmANUofqK8ecF0G62+6M/hq?=
 =?us-ascii?Q?4hUhwvLEVURJDRVDgVQwi00st0vhAwWGdhELxTOyKdgHqhpELM1h7N7tlf+4?=
 =?us-ascii?Q?NhP17sjhsHR84Bvllq/GG++HPXMo8MdyVXEaPvguz6Uk+cf1K6X0xNOgamsc?=
 =?us-ascii?Q?jII3UL9HjEs/WIwkn6J6/TwwSSd9O3ms96whOlBCUy9sY/+/CNyU730WDZj4?=
 =?us-ascii?Q?DEidT8uQBE3HE9qnbdnWh0LiFRXMPhqSMTxRoh5seUrA+IA99ZD19SkJD5Gr?=
 =?us-ascii?Q?BnewMtOnlRxMymR4FA5tr+39ZAz+4WLSpRg/rHpW91NuSfkg4Y2/oJPKTE5X?=
 =?us-ascii?Q?G0eZkK4Qz1a1euCXrj//BNJJozDVHWx0j8ctXHDfSlCLRE/4MLbYTTFML/93?=
 =?us-ascii?Q?dQUPXzHhcT9P5AfEskEzexaFKTti/XTMSfeU1BYOC037YlencgYimiXLlw54?=
 =?us-ascii?Q?2VRFSD2UCwAwuu/wf46lhf2M7ttsCnvRTjJZQEHdWNzZrlaHBSoBZetp5pxQ?=
 =?us-ascii?Q?t09aESZa+k4DuqJabha+WzLzPH/vTMN+sd6gTZCiRFadUfv5F02RLiar8LvQ?=
 =?us-ascii?Q?eplnJr0N5RsB9om/NyXYpQ2sQdSTfUTuwHsugK2fPwdPjbhoiZPTprBsoZMN?=
 =?us-ascii?Q?xmJ2/IGfIajAdmWFpN4PmHJfHo1qLKMzp2AIJ23+AOb6Fao6C+Oj58JxubSH?=
 =?us-ascii?Q?PoC9eg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ceca81e-e276-4d19-ece8-08db40e8d248
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 15:14:51.0763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OnPLKwjQdupoBfAZJc5r2Tqna14+4W6G2bJod5eo/uIQ1CPMAr5iAJw6iqSycFbp3Sz6xIXDfFUEt5Iuz3+Av00cn98pdK0GsPgCTrYCSsg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4706
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 17, 2023 at 08:19:33PM +0200, Christophe JAILLET wrote:
> Because of the logic in place, SW_HUGE_PACKET can never be set.
> (If the first condition is true, then the 2nd one is also true, but is not
> executed)
> 
> Change the logic and update each bit individually.
> 
> Fixes: 29d1e85f45e0 ("net: dsa: microchip: ksz8: add MTU configuration support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Untested.
> ---
>  drivers/net/dsa/microchip/ksz8795.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Horman <simon.horman@corigine.com>