Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758536AbXI1I2X (ORCPT ); Fri, 28 Sep 2007 04:28:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755234AbXI1I2Q (ORCPT ); Fri, 28 Sep 2007 04:28:16 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50403 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755174AbXI1I2P (ORCPT ); Fri, 28 Sep 2007 04:28:15 -0400 Date: Fri, 28 Sep 2007 01:26:56 -0700 From: Andrew Morton To: Thomas Gleixner Cc: roel <12o3l@tiscali.nl>, lkml , Andy Whitcroft , Randy Dunlap , Ingo Molnar Subject: Re: [PATCH] spin_lock_unlocked cleanups Message-Id: <20070928012656.0bae3991.akpm@linux-foundation.org> In-Reply-To: <1190967450.18681.10.camel@chaos> References: <46FC2245.50907@tiscali.nl> <1190967450.18681.10.camel@chaos> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 793 Lines: 20 On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner wrote: > can we please add this to checkpatch.pl ? > > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED; > > +DEFINE_SPINLOCK(bpci_lock); That check is already in checkpatch. Problem is that hardly anyone runs the thing. I think we're ready to wire checkpatch up to a email robot which monitors the mailing lists and sends people nastygrams. I bet that'll be popular ;) (I'd love it if it could detect wordwrapped and tab-expanded patches, too. You wouldn't _believe_...) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/