Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Brad Spencer' <bspencer@blackberry.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: netlink getsockopt() sets only one byte?
Thread-Topic: netlink getsockopt() sets only one byte?
Thread-Index: AQHZciCdeGKq7qWD/UKbta8L5WEwQ68yxwaw
Date:   Wed, 19 Apr 2023 15:43:45 +0000
Message-ID: <0c2ea86d55454b55a88db716f967dda4@AcuMS.aculab.com>
References: <ZD7VkNWFfp22kTDt@datsun.rim.net>
In-Reply-To: <ZD7VkNWFfp22kTDt@datsun.rim.net>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Brad Spencer <bspencer@blackberry.com>
> Sent: 18 April 2023 18:38
> 
> Calling getsockopt() on a netlink socket with SOL_NETLINK options that
> use type int only sets the first byte of the int value but returns an
> optlen equal to sizeof(int), at least on x86_64.
> 
> 
> The detailed description:
> 
> It looks like netlink_getsockopt() calls put_user() with a char*
> pointer, and I think that causes it to copy only one byte from the val
> result, despite len being sizeof(int).
> 
> Is this the expected behaviour?  The returned size is 4, after all,
> and other int-sized socket options (outside of netlink) like
> SO_REUSEADDR set all bytes of the int.

It will be horribly broken on anything big-endian.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)