Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Wed, 19 Apr 2023 05:45:23 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Hillf Danton <hdanton@sina.com>
Cc:     jiangshanlai@gmail.com, torvalds@linux-foundation.org,
        peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] workqueue: Automatically mark CPU-hogging work items
 CPU_INTENSIVE
Message-ID: <ZEAMkyXxq_vbQpxe@slm.duckdns.org>
References: <20230418205159.724789-1-tj@kernel.org>
 <20230419014552.1410-1-hdanton@sina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230419014552.1410-1-hdanton@sina.com>
Precedence: bulk

Hello,

On Wed, Apr 19, 2023 at 09:45:52AM +0800, Hillf Danton wrote:
...
> Need to wake up another worker in case the current one with
> WORKER_CPU_INTENSIVE set is going to sleep with works left behind.

Please see below.

> > +
> > +		pool->nr_running--;
> >  	}
> >  
> > -	pool->nr_running--;
> >  	if (need_more_worker(pool))
> >  		wake_up_worker(pool);

That's what this block is for.

Thanks.

-- 
tejun