Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ad5f754-e0f1-899c-b7e4-0f35f47fd50b@intel.com>
Date:   Wed, 19 Apr 2023 09:11:15 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.0
Subject: Re: [PATCH v5 2/3] x86/resctrl: Implement rename op for mon groups
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>
CC:     <fenghua.yu@intel.com>, <Babu.Moger@amd.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <eranian@google.com>,
        <gupasani@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <skodak@google.com>, <tglx@linutronix.de>, <tony.luck@intel.com>,
        <x86@kernel.org>
References: <20230330135558.1019658-1-peternewman@google.com>
 <20230330135558.1019658-3-peternewman@google.com>
 <678ab8b6-9465-cdeb-da65-448c0cf075f5@intel.com>
 <CALPaoCh=1Qq5sqWpY8We8zykmmvk81YVnigtZftqMH6FefnQjw@mail.gmail.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <CALPaoCh=1Qq5sqWpY8We8zykmmvk81YVnigtZftqMH6FefnQjw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkJnMk5ERUZzUU8zVWVHZjRpWjlOZVZvUGJqbHBkazFmR3ZaSGRDMFhURm5k?=
 =?utf-8?B?OERiSW1ZcU43WGFkNzFuNFlpcW9MUnNZbDZNd2h6bkYwR0VSZERMMkpYa2o3?=
 =?utf-8?B?cVlzNE5CZ09sRU5hdmt1NHdOL2ltdUVhMUJOVHRMWDRTd2hvSTBhWmw4R21G?=
 =?utf-8?B?YWZGVWRZaDVGZytPaHErSnVZOFF5czNMNDVZRWNCaW9mVjdVVmxPdk9oVTBw?=
 =?utf-8?B?TUN4ams2Wk0xM0hqTjJ2QWtMTENkb2FNQ3g3dzU0dWY3djZKMHZwdndaRjNq?=
 =?utf-8?B?K3hPQXA2NFVQYTZudE5BUENkSjhTbFFkbCtUQ3h1VWtFOGtHNkFiZklibG5y?=
 =?utf-8?B?c1I0WFNuMkR6dmhhV0tGVHF1Z05vUjJVZk4za2d2blhiYWowcmJGTzl4Q2dY?=
 =?utf-8?B?TjBXanROZmJEYjJETUt1djBZV3ZJbGlqbmQ0UDV0STl0KzB5YWMwNW91bnJp?=
 =?utf-8?B?M1l1MFFTamIyeGZocU9qZmZlVldBUGtrTGpqODZYQnpQWGZQTXpzZ0FYN1ls?=
 =?utf-8?B?cUQ3RnVVZTNkeXY2V2RhQkQ2ZWRpTmxuRW1NY25Sam5DRjc1dG41WG9qR3FC?=
 =?utf-8?B?bzlzZ24vVU5LK1lOWU5sMTRoZ1VWQ3NPK1MwenRiN0RrYTVGS0czZndxd3J6?=
 =?utf-8?B?eFl3VnFMQ2RuVllMMUg5aW5EdGhUOWtJNVE5V1FRUGZucDNneTFiNW1CSnNr?=
 =?utf-8?B?K21tTkhDUmQrMnpPdHBvVmU2d0x1YXBLeGE5cmZVcUl4aStiUEVrUGNIWlFD?=
 =?utf-8?B?c1Jhdyt5Z3F5Vmdhenl5OGowZS9nOWJadi9aNWVpS3ZUSCtiOE9CUWprWERG?=
 =?utf-8?B?R1dJTmtmdW41R1pnZU0xdGV4RE5JTkpBL09DQm4weURqSDZtWWdyeGFzOWtq?=
 =?utf-8?B?ekNPeUJvRnYveXAxeE5hdEFJT2xFbGk3VDhrcUhwTG5oYVJJMjZORzA2cW1T?=
 =?utf-8?B?d3Z1YVNrbkRXN1R3dW44OTZKN1h5dEx2MGhJSDRnUHBMdWJhQklwNW1kY1E0?=
 =?utf-8?B?dXY1UXhyajVlWkRDdEp6SXdKblNHdGJadGlyN2ZBaDU2SW91ZnZKdUpHdUZl?=
 =?utf-8?B?dXpOYVRCTWl4bjFzUHdFZFQxNWhBOG5rcTV2Z2xhdzY3NlNPMHg1K0VMdWp1?=
 =?utf-8?B?WERaQWx6RFFvNWJ0RW1pNVU2YnpYaE56dW1LOTdVZm5DcFBvU1JUMVpORmVr?=
 =?utf-8?B?MDZwakdWZnpkUndZUEZTWndhVGFldkhtRnFFY3ZadTNPelZybjltUVVydUNa?=
 =?utf-8?B?dkgyM2x2MEc4elllMDJPWmhyd0owNkZXTmxLeTJ4RTB2cElRUEZlajFsT2xS?=
 =?utf-8?B?QWpuSzliRXVDeUZENWMzVml0WmdIbko2UEpId1VndE9YLzhwUk1FZEtQZ0NY?=
 =?utf-8?B?eDZRYXJkaTVjL3BSbUh6VS9vSHVzQVlHQ0NETE1kVkw3d1RKaXQyRkdWRDgx?=
 =?utf-8?B?VTkxMzdTSTBldmtyVlJ3ZnFYdzJ0RGhVaGVVS2ZmWVNTVy90dHNhSTU1RWZ1?=
 =?utf-8?B?VnRMNlFVb3YwMHV3QXJqUDdsWDlSeHM2RzFETVlvTHJuazlsUVdzZGdKU0kv?=
 =?utf-8?B?TkdYeDU2aDdoNWpqdGdBVVZtYUJlYWJtdWptSU45d2VwSlBlSTRqN1hOcUdr?=
 =?utf-8?B?Z1hGU3NWV3o3ZEJVY3dBa3hBOHB2Wi9HeVZPUHR0cGFMN0FrSDkrSGpEM2FC?=
 =?utf-8?B?VzRnL3dBNmdvdEd3TVVWVnI4eXd2eHR2Q2lHQzc1YXdzbkd5VkJmK3RXdjRB?=
 =?utf-8?B?ZnYzM3pTV2Q2OS9EZ3JNdzNtTW9QTnkrbzkzWS95NWJlMlQ1WmdQQ1o5T0l1?=
 =?utf-8?B?U3U1bTZYRzE2djQ1OThVVFNlUjFDSkpCZlZpNWtiZVFvZnJOTTZyV2Q3djlL?=
 =?utf-8?B?d1hNc0pDYU5tRHQwQ1lyVmRBc0x6N1gwck5JYlNzYnd6cXkxcXhqY21Zc2dH?=
 =?utf-8?B?djZJcDZVRUlRNnJTbFhkWXNuMW5CUTZNVGdicHNtdktweitDaFlWMm5BOTgy?=
 =?utf-8?B?NWw4MURvNVA1b25GUy9MVGsxYWU5d1EyKzcwNjBpUVd0czlHYnZDa3E0bkha?=
 =?utf-8?B?UXpRZU85RkgyazQrLzF3c2lLTGVuL1VBV3VZdVp4dnlUcnpqaWJzTi95WGkz?=
 =?utf-8?B?QnlnTmNPZzFXUFNUT2trMDlNYmFzM3VSSnhkWkxkYWpCY2ZGWUc0V25MeVJ5?=
 =?utf-8?B?L2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 26ebb8fc-b714-4709-5114-08db40f0b594
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2023 16:11:19.0211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jKXyb7pZmx5tOr1pd8ONFQ1yZ+7Fv6VfukxguC6tpQlYe6lLj9fVKuVEJXH7Pt7fg7cp9Vw8Ej4faIfAxjMuSSXvwZzaAX/hZskSQvI2A4Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7717
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 4/19/2023 2:38 AM, Peter Newman wrote:
> On Tue, Apr 18, 2023 at 11:53 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>> On 3/30/2023 6:55 AM, Peter Newman wrote:
>>> If a container manager is additionally tracking containers' bandwidth
>>> usage by placing tasks from each into their own monitoring group, it
>>
>> The above sentence seems to be missing something after the "for each".
>> It seems to still parse if "for each" is removed.
> 
> Did you mean "from each"?

I did, yes. Thanks for converting it to what I intended to write.

> In any case, I'll further disambiguate to
> this in my next update:
> 
> "If the container manager is using monitoring groups to separately
> track the bandwidth of containers assigned to the same control group,
> it must first move the container's tasks to the default monitoring
> group of the new control group before it can move these tasks into the
> container's replacement monitoring groups under the destination
> control group."

Looks good to me. Thank you.

Reinette